Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7537226rwr; Wed, 10 May 2023 09:22:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qoRUcYDS4cBuOhZfjHou97IkdB2P5ATzdyvyZ0TEnP12b/ZUUcgBY7BZ7t/c3TGxh+vok X-Received: by 2002:a05:6a00:989:b0:62d:d045:392 with SMTP id u9-20020a056a00098900b0062dd0450392mr27017074pfg.32.1683735738525; Wed, 10 May 2023 09:22:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683735738; cv=none; d=google.com; s=arc-20160816; b=Z+/TVCd2jObENVAyRLy0FPRh/iOBYWFJw0HvOBpT6Dnm47RIS0h1ZiDOZ9EpaS9qac YByldEfVeh6hwoslEzrKp4x2lwu77HIRhov017NHqMtJFChxTGqI0VMkOjneDI0Y40mt oS7/1aeNocUOS/GoYaFJC+rttYL3MnWaYJOyDSlUgo5igM7bube/DUiBoZSer2DjCssL TFmNWoBbfncD31UwXlDQbE8rTJaia0sGQR2HCSHwBU7fNZCBg8wbaWPNzUMuS9PIo+L0 liTaQgyoqfJoPVU1aDnjD6tiI26+UVUrksuPUmbeOnh2WPLPWz8XE/Qcom7k+jKb0Ab9 lA/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=Zuc/PKv7BsyYTw5vXjXZ1fRjIXUbnX/cr7+0epdXRww=; b=kgCKnR5aZ89FWdtLcmn66uYQ4yj0ve64q+QYEDcbOEvvDYEY++KIK/jHKTfdUGqoPA 8blELzDmXjzj1V9pie+0qeIn5+Zsqd5pvYE53DibnJedmw8+ewaVwxCXdsnvV9jghzlL NytnzhaAZ6nB/6FBKLSNru5kX9ytFUGSO6VNVqe1M8jBVBilKxLBCZnuv555UdDn5rbc ZIKvFCHSEXVNx8+IcGUZiwMem3yAWyWEZezNSQPKcbCR8dIimRgM2yjHcvJPSdSQTXgZ 4dvAa9sT+hNKo5IvTNTfxjWyeoDLUYAOT/qxG4oCt81N/2VJSNcqjnwB1Ro8cYRyGzFl P92Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa1 header.b=Saz8RKF1; dkim=neutral (no key) header.i=@ravnborg.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u145-20020a627997000000b006391322d3f8si5414616pfc.375.2023.05.10.09.22.03; Wed, 10 May 2023 09:22:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa1 header.b=Saz8RKF1; dkim=neutral (no key) header.i=@ravnborg.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229447AbjEJQDs (ORCPT + 99 others); Wed, 10 May 2023 12:03:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjEJQDr (ORCPT ); Wed, 10 May 2023 12:03:47 -0400 Received: from mailrelay2-1.pub.mailoutpod2-cph3.one.com (mailrelay2-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:401::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F1AF6EA1 for ; Wed, 10 May 2023 09:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Zuc/PKv7BsyYTw5vXjXZ1fRjIXUbnX/cr7+0epdXRww=; b=Saz8RKF1M1YXdMlmGVIqkuk1FPuXvxO3dfsdyGN1k2laX6p636AyrfhO/uoGCbFoVUvgtP9b59+kv 1BadUgz7jkBD1jEF8W6kgH4te9AJLnbWSkEG74Zdsxg4+nPi2bpMe3nUeEFuA/FGEi/xov/kXEPm0m H0akPuwlf8WA0NTWfhNFzEFNUicuV5yYsLzoQ2ZTw0Iy3WQSu4jOx39oyrVt4kws6UYWXvQlL6wdAO HPc687KY08FaOM74C2BxR+DkXcKU16kD9FH4hIb6o9fRshpkrS+t1O530Yq7b0ad0lgde2bu+HdTy3 kgMVtxDZEoWu9w4PL2FyDrg8TQw0HSw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Zuc/PKv7BsyYTw5vXjXZ1fRjIXUbnX/cr7+0epdXRww=; b=vYlFgBJmm67njDAbPDTcXVM7/cVVkBM1o7gKoLKUEN4DM2jZTNDzyMceQlsMPiQw8LGx1sMWLr3GL hKg9eY7DQ== X-HalOne-ID: 3a3e330c-ef4c-11ed-9c7e-13111ccb208d Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay2 (Halon) with ESMTPSA id 3a3e330c-ef4c-11ed-9c7e-13111ccb208d; Wed, 10 May 2023 16:03:41 +0000 (UTC) Date: Wed, 10 May 2023 18:03:40 +0200 From: Sam Ravnborg To: Maximilian Weigand Cc: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Maximilian Weigand Subject: Re: [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank Message-ID: <20230510160340.GA1180686@ravnborg.org> References: <20230510085239.1253896-1-mweigand2017@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510085239.1253896-1-mweigand2017@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2023 at 10:52:39AM +0200, Maximilian Weigand wrote: > From: Maximilian Weigand > > Use backlight_is_blank() to determine if the led strings should be turned > off in the update_status() functions of both strings. > > Reviewed-by: Daniel Thompson > Signed-off-by: Maximilian Weigand Looks good. Reviewed-by: Sam Ravnborg