Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7557139rwr; Wed, 10 May 2023 09:36:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6aDHyK2qTVMUV5vpuiffFlgB/65k+FaxDAQtMsWs++ldoaBGD0lq8/i6bJDlwetth5YF+E X-Received: by 2002:a17:903:2cb:b0:1ac:73e9:de5 with SMTP id s11-20020a17090302cb00b001ac73e90de5mr13914890plk.46.1683736577690; Wed, 10 May 2023 09:36:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683736577; cv=none; d=google.com; s=arc-20160816; b=tdfVuvXG8IlVRMp+40GE5/y5auHMBCUwyd1pwNfL3j0/wpLKsKVjGG7y0T2vZU4OcU UQlRGZsRwYfOm+L9JNQGwmpKgG0eFCn88QPJKdz1lNkWkgnlbfm6KMYM7bA9Yfw8OAF9 vMRXoJBtOuEpHZcmBqLOJM+WaEDautTSp+AS649veK7qDLxl0GkAgf/3Uu/IDlPAJTPd FuBCVxuiq52Pme0SgDcUQrZwKGCOHP5o/hpLUCzJ/q4vR/lk9jzKvZkE/EYRbDSNMRkT ks+s6J5i69c6mKRugZqVQNLArM2upGov7/VEaHWBenVFuJZa4xp+cLYYNsEnGmRG6dLb 9vcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Dk/OU7wmaNZMLcevPTKhSodBVPmPPaEdH0F0dmzNl2M=; b=ULckAIqqCa+mIkSzrcmXkoInIjZEKst/8R3tELP0fjNveWxAB+bmmy2jHsJP6m9keg ftCuo7gHy/996xaG7v+rQ+GGn+apM6Pwx+zW0fzHtqCdkuLhmuDx0M9Kzo0AJhDOqOny 9y4uEULWtSDqAfpzwF/hJt9tOOs5WyzyhttL/PnVSMhe0F+FLSyJ1IsG0lr9cynxTCnp qDrCAhIJMujD5cYSoFaNSpnKajSIZJlKaUSawoh1Am0SrfKjOAOCYI5/pXUF1R2eaN9O PjotHFREF30oB7KacvvabPTkik9QmFvt9CdiYdETCqXdL2mP2j3ZZ5qROKPxBqPUhOoh 6+NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=ZSkl1dXo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b2-20020a170903228200b001a1bfe84f8dsi5199181plh.611.2023.05.10.09.35.55; Wed, 10 May 2023 09:36:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=ZSkl1dXo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229871AbjEJQWC (ORCPT + 99 others); Wed, 10 May 2023 12:22:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjEJQWA (ORCPT ); Wed, 10 May 2023 12:22:00 -0400 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B62F173D; Wed, 10 May 2023 09:21:59 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 08E0E85D1E; Wed, 10 May 2023 18:21:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1683735717; bh=Dk/OU7wmaNZMLcevPTKhSodBVPmPPaEdH0F0dmzNl2M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZSkl1dXoZsDv1eX3hF75wsrkCvp7b4/rkOSTIjabE6uuoC7CLLQQQ8iCNJPnF2ASq Iir6mJpGphckwT24UkqmYcoKfzsxWTH0NpLPU8nNKII7od7uiPMaZzS79TIYApMb/5 6bFLCKg9EQznt86htrJTKdxELxWX07SKYnHN1okVOXlnZmXxeSXE3KjNl2zlELE/K9 83eEAAAwfOBlFoftCYEsg+KjOxmh/gpOKZRR9z9QrwWwCg4SGO0vMCzDVop5xYB+0e 8f8SReLFliXL5HedAEEGByhAEE2+z7l7pZ+grUHftMTuT9otgoynEkHcNPr1K5DWXh CiwG+azR4dAag== Message-ID: Date: Wed, 10 May 2023 18:21:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v6 2/6] drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge Content-Language: en-US To: Liu Ying , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: stefan@agner.ch, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, krzysztof.kozlowski@linaro.org, LW@karo-electronics.de, alexander.stein@ew.tq-group.com References: <20230510092450.4024730-1-victor.liu@nxp.com> <20230510092450.4024730-3-victor.liu@nxp.com> From: Marek Vasut In-Reply-To: <20230510092450.4024730-3-victor.liu@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/23 11:24, Liu Ying wrote: > A valid bridge is already found in lcdif_attach_bridge() and set > to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop > the unnecessary NULL pointer check in KMS stage. > > Tested-by: Alexander Stein > Reviewed-by: Alexander Stein > Signed-off-by: Liu Ying Reviewed-by: Marek Vasut