Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7558759rwr; Wed, 10 May 2023 09:37:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ744wn1elitUgxbyzGYFJlnRUUmlWMw6IravgnWYpyzTeEGV6/jxQ3rcRot5ASkR+rIHjIT X-Received: by 2002:a17:90b:314a:b0:247:ab52:d5d8 with SMTP id ip10-20020a17090b314a00b00247ab52d5d8mr18200694pjb.26.1683736657083; Wed, 10 May 2023 09:37:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683736657; cv=none; d=google.com; s=arc-20160816; b=x01ZHzTfyfz4q2JZ2b55jeB+wDlMDUB7BPSabZQTJ9VmXgldRr5u8g70iiHKIwwVgA F/1+KBaY9nt8st//ZDYBQgDx7Gherw3Uwzi0xe2zKQrlrcU3CI8Of0LTC6mXkrSSPzj5 pLNdOdWKYkVcD4ARvncG0+UN0hfEfzC4PdRIwLgxn0Is8V4r2CGf6zGyCFZ4sSl7N8qy SqXJ1IoyeaZcl9tlQsRJFLfpFfupZ+s4BwnpQeDndZCiFi1WnWJDOyu2H5B+Ju12NdcF M83nkgaOPMz7fmkvf9otYFPOsg70/YP1MKQRF6GqVe0gksr7OXUFwt7PJokg7Vj6t7xB LxNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from; bh=hzpsBev4uYoDvVuKAIq2MZ+ElJ6lU+aDJY+my1tFWJM=; b=hl8lEdvzLU7OMEeKq4d2M62FKycSUKcHthFBUkhfzBPiKys+Stn0Oza6xjxxGpDICK Wn+adu8f1b70/dNseqzr3NbTWZ2OO/vdnKUJO5DtSG8ErVoGWicsEG5harEFIUu7T+4N Vdf42GJ2W+Z5OHP+RJqQmHalhhBxQqGP6m1w8JtxWwEIVoDQmHSGdgoyP2kpqx0mSzNi ghMZMW8bo0qwDkqR+6DPR4Nns1v41svaXkWjflaTN1kT/+pIvg1lyQq4oPSm6LVRirrn roaAp0Be7Amz6Mo52lfoWIZIlGcEycj+/ira7mmPKmwpa9EcSwBrxAsKWVW8CvIo+rNp yyOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t17-20020a639551000000b00518c878b1dbsi4374697pgn.356.2023.05.10.09.37.22; Wed, 10 May 2023 09:37:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235456AbjEJQeM (ORCPT + 99 others); Wed, 10 May 2023 12:34:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjEJQeK (ORCPT ); Wed, 10 May 2023 12:34:10 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B320D6A52 for ; Wed, 10 May 2023 09:34:00 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pwml7-001PDV-C6; Wed, 10 May 2023 18:33:45 +0200 Received: from p57bd9793.dip0.t-ipconnect.de ([87.189.151.147] helo=z6.fritz.box) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pwml7-000RlD-5t; Wed, 10 May 2023 18:33:45 +0200 Received: from glaubitz by z6.fritz.box with local (Exim 4.96) (envelope-from ) id 1pwml6-000BDK-1n; Wed, 10 May 2023 18:33:44 +0200 From: John Paul Adrian Glaubitz Cc: John Paul Adrian Glaubitz , Thomas Gleixner , Marc Zyngier , Rich Felker , Jason Cooper , linux-kernel@vger.kernel.org Subject: [PATCH] irqchip/jcore-aic: Fix missing allocation of IRQ descriptors Date: Wed, 10 May 2023 18:33:42 +0200 Message-Id: <20230510163343.43090-1-glaubitz@physik.fu-berlin.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.151.147 X-ZEDAT-Hint: PO X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The initialization function for the J-Core AIC aic_irq_of_init() is currently missing the call to irq_alloc_descs() which allocates and initializes all the IRQ descriptors. Add missing function call and return the error code from irq_alloc_descs() in case the allocation fails. Fixes: 981b58f66cfc ("irqchip/jcore-aic: Add J-Core AIC driver") Signed-off-by: John Paul Adrian Glaubitz --- drivers/irqchip/irq-jcore-aic.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/irqchip/irq-jcore-aic.c b/drivers/irqchip/irq-jcore-aic.c index 5f47d8ee4ae3..b9dcc8e78c75 100644 --- a/drivers/irqchip/irq-jcore-aic.c +++ b/drivers/irqchip/irq-jcore-aic.c @@ -68,6 +68,7 @@ static int __init aic_irq_of_init(struct device_node *node, unsigned min_irq = JCORE_AIC2_MIN_HWIRQ; unsigned dom_sz = JCORE_AIC_MAX_HWIRQ+1; struct irq_domain *domain; + int ret; pr_info("Initializing J-Core AIC\n"); @@ -100,6 +101,12 @@ static int __init aic_irq_of_init(struct device_node *node, jcore_aic.irq_unmask = noop; jcore_aic.name = "AIC"; + ret = irq_alloc_descs(-1, min_irq, dom_sz - min_irq, + of_node_to_nid(node)); + + if (ret < 0) + return ret; + domain = irq_domain_add_legacy(node, dom_sz - min_irq, min_irq, min_irq, &jcore_aic_irqdomain_ops, &jcore_aic); -- 2.39.2