Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0d3c3938dbd255e21f40884408076fd24222211a.camel@gmail.com>
Subject: Re: [PATCH v1] usb: xhci: plat: remove error log for failure to get
 usb-phy
From:   Klaus Kudielka <klaus.kudielka@gmail.com>
To:     Stanley Chang <stanley_chang@realtek.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Mathias Nyman <mathias.nyman@intel.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 10 May 2023 19:39:41 +0200
In-Reply-To: <20230510075129.28047-1-stanley_chang@realtek.com>
References: <20230510075129.28047-1-stanley_chang@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-05-10 at 15:51 +0800, Stanley Chang wrote:
> Remove this log to avoid non-error conditions.
> If CONFIG_USB_PHY is disabled, the following error message appears:
> [=C2=A0=C2=A0=C2=A0 0.231609] xhci-hcd f10f0000.usb3: xhci_plat_probe get=
 usb3phy fail (ret=3D-6)
> [=C2=A0=C2=A0=C2=A0 0.239716] xhci-hcd f10f8000.usb3: xhci_plat_probe get=
 usb3phy fail (ret=3D-6)
> In this case, devm_usb_get_phy_by_phandle is declared static inline
> and returns -ENXIO.
>=20
> It is easy to pinpoint the failure to get the usb-phy using the debug
> log in drivers/usb/phy/phy.c. Therefore, it can be removed.
>=20
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>

Thanks, the false positives are now gone for those without CONFIG_USB_PHY.

Tested-by: Klaus Kudielka <klaus.kudielka@gmail.com>