Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 18:56:21 +0100
From:   Liviu Dudau <liviu@dudau.co.uk>
To:     =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Paul Burton <paulburton@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Sergio Paracuellos <sergio.paracuellos@gmail.com>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] mips: dts: ralink: Clarify usage of MT7621 ethernet phy
 arguments
Message-ID: <ZFvaxVwVOnzVofrU@bart.dudau.co.uk>
References: <20230509200032.308934-1-liviu@dudau.co.uk>
 <a5fdd37e-6f42-2f37-357f-ad5bb082fa7d@arinc9.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a5fdd37e-6f42-2f37-357f-ad5bb082fa7d@arinc9.com>
Precedence: bulk

Hi Arınç,

On Wed, May 10, 2023 at 02:59:44PM +0200, Arınç ÜNAL wrote:
> On 9.05.2023 22:00, Liviu Dudau wrote:
> > The device tree uses numbers as arguments to the phys property that are
> > confusing for newcomers. Define names for the values and use them in the
> > device tree.
> > 
> > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
> 
> You should document this on
> Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml instead of
> doing this. Under the phys property, add 'description:' and explain this.

There is already some sort of explanation under
Documentation/devicetree/bindings/phy/mediatek,mt7621-pci-phy.yaml, so I'm
not sure what I'm improving by adding new text in the /pci/ section.

Maybe I haven't explained properly in the commit message, this is meant to
give a name to the 1 and 0 values used in the device tree, not to clarify
any perceived missing documentation.

> 
> Arınç

Best regards,
Liviu

--
Everyone who uses computers frequently has had, from time to time,
a mad desire to attack the precocious abacus with an axe.
       	   	      	     	  -- John D. Clark, Ignition!