Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7716786rwr; Wed, 10 May 2023 11:33:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ74nZ0cVvlGpP0+1xrcdkRlIbMp/epeuomk1YjVUtjMbGRNGPMx9KEdL61dMIb3pZ6UA7NQ X-Received: by 2002:a05:6a20:938f:b0:102:a593:a17c with SMTP id x15-20020a056a20938f00b00102a593a17cmr3768926pzh.0.1683743619655; Wed, 10 May 2023 11:33:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683743619; cv=none; d=google.com; s=arc-20160816; b=IUPOQjjAs3MozkAitYl2QvLGe/mtx1bt4OMym9L4toRl9yqDb2X1ShYAwQmozdxa9I N/OPM2GXERUI5J9pSakVkqnlaarKFm+GiAA8/Z72LC9qVdnyR2cUU5Zp000KpEcrBthI /1YbLxKs7O+N3jdKRw/+t+Vomw21HXX+rHSEc+JnuVv6unTzwcV0k+4/n66rZF4gBs2Q yqGe0a27b0jMPbi9QYtdbWpvOiM+8etGnhEt5+GlSsB/OkxzMdnJWnPeHv/T52etS7/z 6QhWr0erOtwKno3du8nB3kdWkWiM5Z6difgBgryj3dsLWFKn8PnWQaz7LAW7KW8PSLk4 TRPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=AxNNeUlKb2mEb7+tC4au3XdhlwF/tDkvv1YeFKn3c7Y=; b=sTcdgHyyjfiyBYZARZ/XgbKEncOkqK/oL/kq2H+H+Vb+MtZRUs753+rUMP5ne1xuYd 2ZkGvq+lCN8TP39YlD2Q/8C7O29rI7PTit4gq9Imshca9tirNwa+k38RirNNNfPwg/F6 qSC4zEnmSjiGjvqqFWOO9E1LHjSX+ctZ3GYHpv1RsPuuFU1x42PSkzByhZTdY+iH+jIp pU3nX0yhNszGAOR6m58dYtjWS01P5Nz6ezALfxEB8lUSZlN9d+hY7F9kWiosPY2X5NMx W5k+l7RXcZC4dn11dpgWwfBCzGU/BakYd4Gk6Gf2iH64b4DmD+6GTRp81mhN4NVCrG55 8R5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=n5a6hSvC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a21-20020a63e855000000b0051b2ba5cb37si4583899pgk.437.2023.05.10.11.33.22; Wed, 10 May 2023 11:33:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=n5a6hSvC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231207AbjEJSUQ (ORCPT + 99 others); Wed, 10 May 2023 14:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231468AbjEJSUA (ORCPT ); Wed, 10 May 2023 14:20:00 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA8ED9EE2 for ; Wed, 10 May 2023 11:18:45 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-64115eef620so52172547b3a.1 for ; Wed, 10 May 2023 11:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683742721; x=1686334721; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=AxNNeUlKb2mEb7+tC4au3XdhlwF/tDkvv1YeFKn3c7Y=; b=n5a6hSvCr1y5VjAamauHZ709dncmRtqSN7cvPA59jqOLcEr4HmcNQQVZOcrcj9PaAk c7ixJ6QXq1PTiEvH3P8NgZ0juhIPoX4oV24jULi20FAaqAmaw01jFUcX/Vu6FnO6gwgc BeJRZ8XCoRYpzSFJF7Ssu/O8OZH0X7isU8oXVm6piyQEAwE1luoxSqHxO179fIERp4bR sFGC/vD2O31U9RyAILJWRumIBiqs+2ME95LCU0EsqopxhKlrLF61/fTnZ0CfFOu7CXOc +cC15Dmr4i3kDITU1i+ARZ0SHKTGjJaqFx0PVAQU8ks0GKJVSI+QPmkoo2ujJwLJ8Jpe CbWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683742721; x=1686334721; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AxNNeUlKb2mEb7+tC4au3XdhlwF/tDkvv1YeFKn3c7Y=; b=DaUl3Uaw0Sx1k8HK6snDue1fG0FCI6g+SLU0EOiIIUlOzamP87+N3FHUtClBpmRIzj iF8FKOa56mdxFybhIWM5Po2X+ZcD9UPaS8GxxzayoTGRcR6c5vDYInTbF0wPIeb22PLt Hsz8l9Lz8fO2WtFEsu4P9MCZUBkiCmBB1UO6AwtAMahOfNtLVTDO9hwi6Hc1nYlvt8R/ zjPUoZkFI5az1zLkzdFTpMQd3tIGZFqC6IvyVKPs1Ttp3DlxjZmi+n06EDQjCdivyWEK G6sF/fE1gY8hPDJ0CHRAcb8uIl/6K0O5mQ3jwwZbBfA4eeF/1VBh+VxnDoAm1ahAjILD VisQ== X-Gm-Message-State: AC+VfDyMUIFXjJeKx7GvfItsAdon+sO6izbHQ5pcLk0Flp1nWEVVlMsy xgeQ0C4/vNDQZpeW6G4D6Tc= X-Received: by 2002:a17:902:b195:b0:1a0:76e8:a4d with SMTP id s21-20020a170902b19500b001a076e80a4dmr21127802plr.14.1683742720606; Wed, 10 May 2023 11:18:40 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id l8-20020a170903244800b001ac2c3e54adsm4105512pls.118.2023.05.10.11.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 11:18:40 -0700 (PDT) Sender: Tejun Heo Date: Wed, 10 May 2023 08:18:39 -1000 From: Tejun Heo To: Linus Torvalds Cc: jiangshanlai@gmail.com, peterz@infradead.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 3/6] workqueue: Move worker_set/clr_flags() upwards Message-ID: References: <20230510030752.542340-1-tj@kernel.org> <20230510030752.542340-4-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2023 at 09:30:55AM -0500, Linus Torvalds wrote: > On Tue, May 9, 2023 at 10:08 PM Tejun Heo wrote: > > > > They're gonna be used wq_worker_stopping(). Move them upwards. > > I got points deducted in fifth grade for using "gonna" instead of > "going to". Here I am, 40+ years later, and I still feel it. > > Please use "going to". And add the missing "in" while at it. > > Linus "scarred for life" Torvalds Aye, Aye, imma update. Thanks. -- tejun