Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7809824rwr; Wed, 10 May 2023 13:01:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7413bgz+fkVvD+I9PS1rXvzB3lq6sEDOEhWWdLRjzefFfnvSwt41zk31KY4TqsLAiVwyXI X-Received: by 2002:a17:90a:f498:b0:252:7f38:ad86 with SMTP id bx24-20020a17090af49800b002527f38ad86mr1081023pjb.12.1683748876210; Wed, 10 May 2023 13:01:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683748876; cv=none; d=google.com; s=arc-20160816; b=Qw5fzEUOki8SqbXBEvHibMm3XNKXX3aYYmyhEXTwqM3803TKojC1xl1WxvC9psHGr0 MwgciYT55/rCZKeCe16jE87DjpEnqEyJfuWqzoBXd9TPRDXb8zt6KxAH9Z+yNzf9LWbT hkFdMqNhrMhQ9+RyfBtofSX3QqMW2xBoUKsRxbJ8aLzeXxn4Ujg3vB/kBza1LrnkCR6G uILuTsRflV1fE9ogHruxKwNLOD+e+QbXDteGLvYys/1TErgxrzX4DpOUTyRxM/mPS8Ys hnf/oFPVYFhLwIWrY5MUh4/hhobpLX+fkXhBXjlzV0AmlRf0fAfYTw/oEjWo7zmz1gFs 0XSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=lDQeDrUgQr9ns4tR7WjjBfCsJgY0JHbmPWw81YSldjI=; b=F/z/krbNz75vKXanOWmtTZAFvJc7BMBsAqiK++HuPwGFpY6lTk+O2N/vDj7XGEnkt8 Gy0Z4k3clRfQ5G30khnIzs0m7AHwMEB9jeOE7bR8nQ0f5RIR+g5HIxaiL8Zp9S1Z6BLX 4elr4HcK8rbn1zvcWyfPfPn700igDfiUOvMMatqMbcPSoc8q0Ek96XmRnEeyI97bPdc8 WEHDFuZupx175tZpbEKMX9lsZ5HA1BoquFAcyhheqZZVxOWZnseUf+5S+WNNJyVSR7l9 si3h2EK1PJdy0Mew+U5BEwpWd6pM8YVri897fefiRNOZbKrFeoamfRF13RcBZalzKg18 A+2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=dntUFt1j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c11-20020a170903234b00b001a64e7b7026si5310341plh.438.2023.05.10.13.01.01; Wed, 10 May 2023 13:01:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=dntUFt1j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236241AbjEJTa0 (ORCPT + 99 others); Wed, 10 May 2023 15:30:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235833AbjEJTaZ (ORCPT ); Wed, 10 May 2023 15:30:25 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E836865A0 for ; Wed, 10 May 2023 12:30:24 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-643a6f993a7so4487840b3a.1 for ; Wed, 10 May 2023 12:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683747024; x=1686339024; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=lDQeDrUgQr9ns4tR7WjjBfCsJgY0JHbmPWw81YSldjI=; b=dntUFt1jUz1mLR9xeX6JZKi6rXqV2nwLbcaew1g+FoL4kYUf4bMS/MoQWW91p4gmul 786l7hOVlSiBOTc/qk1mbG9lyW4JgYjkQ6xrQiHpEap8KxW+uTUKFCiCWzZWo36/T6IP nQAoAjTkSt4v6aL2IPYvkUsjwHbwAOGudPub1gymJ+bPvN1McaSN9yKbo+QfNBG5s4Yb Izsz+Ul50ba7SvgZvla+k4Z5HZHcpI0vsZs9E5/H+8oFobsv6GjG1rGOYULb7XXcbe6i TeeGAEKAb/nS+MUOEv7/uFhQvnXJgvwjA5KzUOxaZus8xey05ub70HYdYxklSdDLJpeP DB/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683747024; x=1686339024; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lDQeDrUgQr9ns4tR7WjjBfCsJgY0JHbmPWw81YSldjI=; b=ULvHaXFyJ/r+jYdaSH8XZ1Auj/7CuAWIpprlOFaQ8ys1uYmwVKNkKnQuKOdzzaKmSu Zbldidw+sKboihWm6/BSwfhcz2LqMnLDIlN9asm94h0qqDF9JdJlgobeeFw7tBzl05I7 DrrosSmkJ/QtjVvXmYf/ZGtC+B29dqBo6GI+yK/uIcF9bA64LFoYC4AxnHGvrkfHSJuG 3LlW807/vQr42WxzpfVHteI4qEA9VfqFcohWplLxoDQqs7EwlMMs48leCPlh0bEjteDD +ps4Z1IRix797Il69SeFa88RAC5jyIshjXPKfZrEZiEtU8wS9lpbODK52umUtkBbTmcu ozRg== X-Gm-Message-State: AC+VfDzX18kykdxTPBl7YVuULi04fzmdAcNwE3eEkiUdOflroAJ3QLqv vavnk/+8XCPBwOuUrTe1wSBV98nzHnQ= X-Received: by 2002:a05:6a20:3d01:b0:100:c3ad:79b4 with SMTP id y1-20020a056a203d0100b00100c3ad79b4mr13168746pzi.32.1683747024211; Wed, 10 May 2023 12:30:24 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id y21-20020a63ce15000000b0051ba9d772f9sm3581921pgf.59.2023.05.10.12.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 12:30:23 -0700 (PDT) Sender: Tejun Heo Date: Wed, 10 May 2023 09:30:22 -1000 From: Tejun Heo To: Anna-Maria Behnsen Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Lai Jiangshan Subject: Re: [PATCH v6 08/21] workqueue: Use global variant for add_timer() Message-ID: References: <20230510072817.116056-1-anna-maria@linutronix.de> <20230510072817.116056-9-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510072817.116056-9-anna-maria@linutronix.de> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2023 at 09:28:04AM +0200, Anna-Maria Behnsen wrote: > The implementation of the NOHZ pull at expiry model will change the timer > bases per CPU. Timers, that have to expire on a specific CPU, require the > TIMER_PINNED flag. If the CPU doesn't matter, the TIMER_PINNED flag must be > dropped. This is required for call sites which use the timer alternately as > pinned and not pinned timer like workqueues do. > > Therefore use add_timer_global() to make sure TIMER_PINNED flag is dropped. > > Signed-off-by: Anna-Maria Behnsen > Cc: Tejun Heo > Cc: Lai Jiangshan Acked-by: Tejun Heo Please feel free to route the patch as you see fit. Thanks. -- tejun