Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <03652ea0-09fc-6185-e71e-5ad603811609@kernel.org>
Date:   Wed, 10 May 2023 13:55:53 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [net 1/2] selftests: seg6: disable DAD on IPv6 router cfg for
 srv6_end_dt4_l3vpn_test
Content-Language: en-US
To:     Andrea Mayer <andrea.mayer@uniroma2.it>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Cc:     Stefano Salsano <stefano.salsano@uniroma2.it>,
        Paolo Lungaroni <paolo.lungaroni@uniroma2.it>,
        Ahmed Abdelsalam <ahabdels.dev@gmail.com>,
        Hangbin Liu <liuhangbin@gmail.com>
References: <20230510111638.12408-1-andrea.mayer@uniroma2.it>
 <20230510111638.12408-2-andrea.mayer@uniroma2.it>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <20230510111638.12408-2-andrea.mayer@uniroma2.it>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/10/23 5:16 AM, Andrea Mayer wrote:
> The srv6_end_dt4_l3vpn_test instantiates a virtual network consisting of
> several routers (rt-1, rt-2) and hosts.
> When the IPv6 addresses of rt-{1,2} routers are configured, the Deduplicate
> Address Detection (DAD) kicks in when enabled in the Linux distros running
> the selftests. DAD is used to check whether an IPv6 address is already
> assigned in a network. Such a mechanism consists of sending an ICMPv6 Echo
> Request and waiting for a reply.
> As the DAD process could take too long to complete, it may cause the
> failing of some tests carried out by the srv6_end_dt4_l3vpn_test script.
> 
> To make the srv6_end_dt4_l3vpn_test more robust, we disable DAD on routers
> since we configure the virtual network manually and do not need any address
> deduplication mechanism at all.
> 
> Fixes: 2195444e09b4 ("selftests: add selftest for the SRv6 End.DT4 behavior")
> Signed-off-by: Andrea Mayer <andrea.mayer@uniroma2.it>
> ---
>  tools/testing/selftests/net/srv6_end_dt4_l3vpn_test.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>