Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7824676rwr; Wed, 10 May 2023 13:12:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5K8TpX+OJz6lrbuagSluhVywHR0aqQ3lWmaJcaVGy3uEE25SK+1Kt9V4vRTxhzgeuI4duN X-Received: by 2002:a17:90b:1d87:b0:247:9d19:311f with SMTP id pf7-20020a17090b1d8700b002479d19311fmr18822212pjb.30.1683749573911; Wed, 10 May 2023 13:12:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683749573; cv=none; d=google.com; s=arc-20160816; b=kWcUjMsYk5NVwa1LtIrD3+me8P/wAooAZq7bKCPtt8gBaBht7/kifMNAbvwoKzyt15 iWog5dlWlfprL312vfn3JPSUg7fgX8ocdy8oX6nlMJ3I8NrQhJJheVW64HY9EFkJOgoo Aa8A96XBASq/49+kIGVAC1cVaaLvFC/CXpUIIljHpT4bW1AgrpXJBesLmOYawrME/zZ6 McqH9kxOQpf7dBVzPKyXBFlRcuzaMGYEHTLWrsK2sclJhxFlCYkjIDNsr1WPd2pot9r3 4u7k1OJfO+wYscCh1Vp+U6pT/IN1SA1vm13bWyrsiZulHehNSqDzGqXGggx4D11Kzp90 eoWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=fylYUP5rEJAcHodlBEttzk3VDx1rMp2AwRs/zRKpKkM=; b=GlO09mAwKEs3jF3O6dSmKQSo90mgONoatWbEIECU5y1OB4BigIm0BuEazFKTCJwiyf 1/WVvZW1MNdb2eobhwjH1hKQMkYamBzx5ZprIMUqyrr14CzfdDJv31eKKHUZLkHL2JOA kDKbFM2f4QLx1g0bnuibovtTWhdhrPwj9aUYdhWRdEtEmNCeBFocdX6oaPpPNHJ9O2bp J1XCTW8prXBvolYyvhhIb1XbU9wfvTkRiECMZWO+Y+DaFqwfgBFJPiixVKX9eXqEfT7Y MuufAHcFd3Hd3EjPp4CIvemSNIDyMH0MGrCeTFwSG+wBClqUCIKXxx7j8dsP5sgRMR5F 6gBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LzQpL+4L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 23-20020a17090a199700b0024e54c31c25si17315418pji.176.2023.05.10.13.12.28; Wed, 10 May 2023 13:12:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LzQpL+4L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232680AbjEJT5E (ORCPT + 99 others); Wed, 10 May 2023 15:57:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjEJT5C (ORCPT ); Wed, 10 May 2023 15:57:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ECEA2126; Wed, 10 May 2023 12:57:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 807186354A; Wed, 10 May 2023 19:57:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51A0AC433EF; Wed, 10 May 2023 19:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683748620; bh=DCbaf6xVpFEDtn0H7lDuPNgtj7JSCv0rwyzi3AwTjg4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LzQpL+4LP9d3GVhwXGOeQaNXtUMYBB8t+NORX9vmt1hf193JvWXJRgjvPg5+V7crn Ab3x3CQk19I5VvbTxQY5TMR9AlLLiD2qtD1pgQJTBYuO+Du7qj/zbp9t2O4yVCMlqH F2B4mFpllWNaOviTJiUWY0ifTir5vQwWNkH92RP0g78GAjnAkElHqr4IsjyxBwKhZw y3VubZG0brs+vC+QTjXOYXFgHlqNB5jn9E9+yWTcAyafp6/1Lquljsei+DxARO8uEU zRWn1u15DFmFru4fnJKPV1bwGt/mMOz2SEr/SX+nSIPjdnhziPeTif2E0s4PXu7k9j x56C6kstXMtsA== Message-ID: Date: Wed, 10 May 2023 13:56:59 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [net 2/2] selftets: seg6: disable rp_filter by default in srv6_end_dt4_l3vpn_test Content-Language: en-US To: Andrea Mayer , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Stefano Salsano , Paolo Lungaroni , Ahmed Abdelsalam , Hangbin Liu References: <20230510111638.12408-1-andrea.mayer@uniroma2.it> <20230510111638.12408-3-andrea.mayer@uniroma2.it> From: David Ahern In-Reply-To: <20230510111638.12408-3-andrea.mayer@uniroma2.it> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/23 5:16 AM, Andrea Mayer wrote: > On some distributions, the rp_filter is automatically set (=1) by > default on a netdev basis (also on VRFs). > In an SRv6 End.DT4 behavior, decapsulated IPv4 packets are routed using > the table associated with the VRF bound to that tunnel. During lookup > operations, the rp_filter can lead to packet loss when activated on the > VRF. > Therefore, we chose to make this selftest more robust by explicitly > disabling the rp_filter during tests (as it is automatically set by some > Linux distributions). > > Fixes: 2195444e09b4 ("selftests: add selftest for the SRv6 End.DT4 behavior") > Reported-by: Hangbin Liu > Signed-off-by: Andrea Mayer > Tested-by: Hangbin Liu > --- > .../testing/selftests/net/srv6_end_dt4_l3vpn_test.sh | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > Reviewed-by: David Ahern