Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 23:33:33 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH net v1] net: mscc: ocelot: fix stat counter register
 values
Message-ID: <20230510203333.473u4sxwbnkwv6kj@skbuf>
References: <20230510044851.2015263-1-colin.foster@in-advantage.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230510044851.2015263-1-colin.foster@in-advantage.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YH78ePjivoqawQSDr4Utljish/3HaW09xtzShWaVJeGiKJV9e2lSY/B1KiuO?=
 =?us-ascii?Q?TjGzx8iWPtLDYk7pQpmeftL86W7f4eCvqteSvkTuo5lp2EJ4/H9n7yPUZbQy?=
 =?us-ascii?Q?unZq/WAswupk3I7huKsKrrCq9dGKQbPdrwnCPSq8atJ0nmPFkCSEApPx+7EF?=
 =?us-ascii?Q?zihCge0hblRhcHLmBrVgj0fj/k0C7ufs8wbltBVrSaVcntXpv33wlKDV5YV6?=
 =?us-ascii?Q?qS38tsaXhTxLicm7UhbgVQGvog9rXaXTkpzahsVlHiTGthHA31a0XlXY++wt?=
 =?us-ascii?Q?oxG8ACXe7fuWAve77vSCi0XLI4wcB+SytlZ4IojtLmm4TGjCW/Mue65k3hRt?=
 =?us-ascii?Q?2r/x2lBPyoSS8EmfTQxQd77PDmSqK2r/mXzg18p84baaXsHHj4yBwuNzAkDS?=
 =?us-ascii?Q?aOu8nCI8Pi/EXq/7A3rD/N54LanTGaK3YREK6uq6HvJbLNRvIH3FxRw8cR2e?=
 =?us-ascii?Q?3m0qg1Eld92DqNB882qesU069OV4rWtb+7rIDOv/IGobMUJ+xmzd3pHf57rT?=
 =?us-ascii?Q?b2M9oAs3MrjYJe3yH3X+CP3X5vuoBJovl5ujOs2xieMDVqTbjdhiIEZQNbHv?=
 =?us-ascii?Q?z0t+VgV6QpTc/vDgT3aSJRpENpe9AFOyPN4ki4AoVR1ok//JZkjHPmE5PRSn?=
 =?us-ascii?Q?PEgyrpdUNYkwbrtzYHvQaM/bsgaM+UiBPRLZIyyIfqVluY2xOsiC3v2WH25B?=
 =?us-ascii?Q?5mMqrC7oKILGumhE2Glm7cin4tU5adXHbvU0iCcyO0pYEb8NYcOVr6ZbhToh?=
 =?us-ascii?Q?TTtHibHMCM2F3itCwHROG5Qur/ylLrF+tDykfiMer2hbiM0APKCQykUnGdAz?=
 =?us-ascii?Q?QGhlacDs/8mIHEKH88t0woCuQ27kU33g6fg8qBWeslRNJJAEiI4NExadJ4DS?=
 =?us-ascii?Q?LLYXE3AiIkFg4G68WSNL1kETKsJwJHeFdMUM6jCL8zmniH9IM1g0EurPEDe6?=
 =?us-ascii?Q?WKcq/G6iIOPHuwpTOkhZ9nv+iyeN/UqA7zA6rCS2ShsBRq9M1YYfBQNUV96e?=
 =?us-ascii?Q?IJxJ1L5KJp9gYQvRAOwPIQ87yw+Oj9KRh+yCJ8qEau807HfRtKv8CRAh04Sj?=
 =?us-ascii?Q?b1HE4ByRBHfNzxocVMAFBPzBRLQg5qXaenAhqpVEPq4VxzMA+9VLLnLufqS9?=
 =?us-ascii?Q?LfjWnLlnt/x1eMHjaNNV4U1KlMva9tCEldgdZqw8wbpw2sdPcL058C00Up1k?=
 =?us-ascii?Q?X0BPphBirKgjX7EqjYxQ7gnqXRpjBqbre2vH05v88Fvz7yKthFafmy0RUDAF?=
 =?us-ascii?Q?m+9hoJdkU/1uq/aqDVG2tqC+f+sppkymBS+wM6zSkCLbYRX8PckWMV55plkg?=
 =?us-ascii?Q?SIF8rcA2wVjputHa4DsJRSVjOyxZO+e4s6CSToyoJ+RHrJHpi30YXsDLdHq4?=
 =?us-ascii?Q?ln7+hVw5N3BPtg73u40MYZOIukz6amTESzDnrlHd2KL+N/4Ix5A6Wezfbxd1?=
 =?us-ascii?Q?4buJgkGpqUTFcwzc19FbeyRbSYCs482sS4oZ0+2ArJPwvfQp3IjlYueVU2ps?=
 =?us-ascii?Q?KYD434QWu5HT0++fGonDBf7zvm2NDRzzp7iZ7Y9zRmM1RkFzQhoQIhkoe9zM?=
 =?us-ascii?Q?mqO7ZGKWoz7zuER2ct7BzPvXDFvCL8gMN12iD/DjklxNCe/JP2hRXCpj6tWv?=
 =?us-ascii?Q?Yw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be7897cc-1c83-4ddb-37b9-08db5195d4e1
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 20:33:36.8948
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V6zyArzfX9ED8cg9cVzFhAYBexjoLbDii6EPycJW+c84BsZozICR/MffLrOe7EOPkHxXtARBFHa9aqKLjTiAEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7348
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 09, 2023 at 09:48:51PM -0700, Colin Foster wrote:
> Commit d4c367650704 ("net: mscc: ocelot: keep ocelot_stat_layout by reg
> address, not offset") organized the stats counters for Ocelot chips, namely
> the VSC7512 and VSC7514. A few of the counter offsets were incorrect, and
> were caught by this warning:
> 
> WARNING: CPU: 0 PID: 24 at drivers/net/ethernet/mscc/ocelot_stats.c:909
> ocelot_stats_init+0x1fc/0x2d8
> reg 0x5000078 had address 0x220 but reg 0x5000079 has address 0x214,
> bulking broken!
> 
> Fix these register offsets.
> 
> Fixes: d4c367650704 ("net: mscc: ocelot: keep ocelot_stat_layout by reg address, not offset")
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Thanks!