Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 17:41:06 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     Yan Zhao <yan.y.zhao@intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, kevin.tian@intel.com,
        yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com,
        =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@redhat.com>
Subject: Re: [PATCH] vfio/pci: take mmap write lock for io_remap_pfn_range
Message-ID: <ZFwBYtjL1V0r5WW3@nvidia.com>
References: <20230508125842.28193-1-yan.y.zhao@intel.com>
 <ZFkn3q45RUJXMS+P@nvidia.com>
 <20230508145715.630fe3ae.alex.williamson@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230508145715.630fe3ae.alex.williamson@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ksAbYT6KcOeHHutdwWZxPJft+lr4QWa/dXba0xznp7aTdafUoseZ614+D5l4?=
 =?us-ascii?Q?W7JHqGNC+d96TR1+WiuSb8LJJ0GavF3lGY1MA6adIIRmHMuJ8vRRM0sj5tfd?=
 =?us-ascii?Q?4zzGMRjDK+cugX5W7jLAxYpGN500xoIdMnGUZ+0J+q5k5+Cj4q5Y2l49tZhf?=
 =?us-ascii?Q?fNlohS+rxNKgavDl0VSJyYmP025CVa6uqXw8jgtueKoThgyFi3f8/yV923A2?=
 =?us-ascii?Q?D78fSK36dMZ5KDU1ZSDOoraMGY+TmeVSyDoMZPc53xTXnjUxYCu5v3z/8DUK?=
 =?us-ascii?Q?/hM7//cDAxSJFbbxOaHUrE+g9286W7F+P71zOfPePBVi9WdWArYPGbji4oBr?=
 =?us-ascii?Q?OqlOF1j+cGXKeofzxFbqxYqsC25XWDmWQJeV6KJxEQU9TIPrmSeLfxiJYTHB?=
 =?us-ascii?Q?LdSLdE04iqK3lIgCpMqefjgAYTzShae41THWq510jbVzjzCMK1A2k5QDbykV?=
 =?us-ascii?Q?uYGotkSkBhaiyJF28Jby9/w8X687nH14dFQHLyNDI0+qphiDZK956PKwMb9K?=
 =?us-ascii?Q?vOiSxa0T/7GRKSaorZ0+vR041M7qg4gz3eldL2LIRR+ipKDFvwSAxOo/uRDz?=
 =?us-ascii?Q?tltUkOr8xMK/CA4nwcEWpw1FgkG80D5Hd18CZuZQQpxNpDaV+J5KRSyHR973?=
 =?us-ascii?Q?0l4HyE/BD3doPzVRSJBnn1fS1467GzjDdRo5k+k85ylcRnQefTiCGGNCLPcn?=
 =?us-ascii?Q?BVzLVIItNjdWB2TMVa3rVg2XXmOcWay4qBpMzLg8Ge4vcRwXEGssdIwfFXZP?=
 =?us-ascii?Q?bnWCe3sKx4CJ84pDMJrzecQ79tx03lBqFu2RE6qAikOWUQ0TTOz1RSzsU9FO?=
 =?us-ascii?Q?E4OpqX56BTmrunXF7IIuYYUUsEC5yCvvPFy4t02692gbwk8HXK20ZpARsJNO?=
 =?us-ascii?Q?h24aVdDbVp+uyCFnOnPWPbiMJFYGYZkAjcrcdpp575rvKF29GUrzYPplcfe/?=
 =?us-ascii?Q?j0YJHqa3bsZYR+CdVgetjjmwv1S21nsn0UKrIz8mVoyjUKp/rn0ua0r0JN/R?=
 =?us-ascii?Q?4w6ZAUCdzHXbU6pq+GmunezgwJwzQew6iNSmLI7gQlWrplE8A9azQt3ioNPv?=
 =?us-ascii?Q?hT/K7uYb3JqLcQ3z4GMtiZZJ8ZAQYCHEEryQoTLkc9NbnACgcv+8q3usXoqZ?=
 =?us-ascii?Q?Y9rMhQc4RFBSlyUeBwQlNF2QODwCwqo+nhYpNomuBr2osh4Eh9I0RsEnmVVi?=
 =?us-ascii?Q?4jK4tibPBJwqljjQru+zbVi2JVU9bAPHtS9CtdLN5mx/Y80Tng0OT687hbNc?=
 =?us-ascii?Q?U36i3BB/yP5tWrJuSJmQqJaPmHQUq2gQYR2RtLc2TSLh1MJrHQa2HUuWTuxe?=
 =?us-ascii?Q?DgMHNnsLnQxp4loIpb4JPyerZGpJF7hxNPuXvT7sPYTbgKrMSKiyLq5Co9Od?=
 =?us-ascii?Q?DIRaAZgkQmWmBz0DukiUoFlmGBl9RoZAbz93sToFOWViSbD1GROJDMNOfp9n?=
 =?us-ascii?Q?lZ3bBfmWvMfrqghYTvgmcF7+nHkrOQsmnpCk+i8la8nJYekklwg0VE89p1un?=
 =?us-ascii?Q?pQsbz1ZnEJI7qSiZH5K3Dvl96V40KsNA9kIZ2ClDxS2h14chgc3gGqPyakgr?=
 =?us-ascii?Q?Myuvx7HLgLghbD+dW2I=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f01f2d22-6c17-4fdb-720d-08db5196e24b
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 20:41:08.8051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PQWXhW9b/WNM2XhWIRQFQiRI8gtdVzZHvLADktS3Sp8/KVVQxJeEm35B6fPowOrU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4966
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 08, 2023 at 02:57:15PM -0600, Alex Williamson wrote:

> We already try to set the flags in advance, but there are some
> architectural flags like VM_PAT that make that tricky.  Cedric has been
> looking at inserting individual pages with vmf_insert_pfn(), but that
> incurs a lot more faults and therefore latency vs remapping the entire
> vma on fault.  I'm not convinced that we shouldn't just attempt to
> remove the fault handler entirely, but I haven't tried it yet to know
> what gotchas are down that path.  Thanks,

I thought we did it like this because there were races otherwise with
PTE insertion and zapping? I don't remember well anymore.

I vaugely remember the address_space conversion might help remove the
fault handler?

Jason