Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7896696rwr; Wed, 10 May 2023 14:25:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6IwgnrCD/v8cN0cqqbMQ16z7jOAUBsqXtRdPGD8z8YcLdkIIXGIeKWHfqyGrS7CLAIsAE/ X-Received: by 2002:a17:90a:7e90:b0:24e:272:2469 with SMTP id j16-20020a17090a7e9000b0024e02722469mr19089858pjl.18.1683753918195; Wed, 10 May 2023 14:25:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683753918; cv=none; d=google.com; s=arc-20160816; b=okI5/+p5ylOes9lbM+dnRCJx1CTf/v/k6Ngz23fnZXFuzp4DM3rmTLSZtgk42Gq55K XQndLTgSwLcA7BeNPIdIMVeM1NdEJCYvwT7HpiKbnFH/dKmk+Z+ahvdDAkWF2TEdtb+e eEZn7kP/GCkQEobBPQFT5QqD6udE4mK+vKbvadbU59ioJW8aA8C0L8k8pVRHT8y0Ea8j p2OO3b599LMxixwoRwOyVTUQZ+CAJdVZqR2540TOJdbA4wzCL/6/XeSkhzZ99FWFk8dB qiOzUaiS/hjJfggDf/kfVkcvqdT/BVzhsYc7oXdLMW//HKj8jYoX93begMrDGQocs+t6 QNSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=27KIjq7CBSBhNB7+NHDWhRflDTQlTyuk3TbNQR93QOE=; b=l1/fP5uVdAp2qdSuYWLVftP0Zw5aibppsXnkjblvfUy0TgXLk8QsDcod4JlZxIcIu6 pBfAGmg8MdYTYVWdMKeG8J9y0qYtv57sVp+OlUyOuQM4RJLdG8lc2lj2ksIdXO7EzyTz Ceuc5stvEslh+ifCPksicXJfY+yTgAcIq2FMLvIAtogF+u9mmeaqNbuEx4df4cnMzYbo e+565unQb5eVSAr9mNLrGF2XmjFdEjdwifrmkWje86rknajMK4nds9hxBroT4es7Qgv2 h1FIEY4jvY7h5pu5q4EMdQQ70ExCReUJtA+amw9Dzjry6veyzcc7hmn31kcYxT0GFVzC qd1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ra0A8gvZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hk10-20020a17090b224a00b00250a6b87c76si6482277pjb.142.2023.05.10.14.25.05; Wed, 10 May 2023 14:25:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ra0A8gvZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236617AbjEJUn3 (ORCPT + 99 others); Wed, 10 May 2023 16:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236538AbjEJUnZ (ORCPT ); Wed, 10 May 2023 16:43:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7E2E6188; Wed, 10 May 2023 13:43:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ECD663DBA; Wed, 10 May 2023 20:43:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4783C433EF; Wed, 10 May 2023 20:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683751402; bh=27KIjq7CBSBhNB7+NHDWhRflDTQlTyuk3TbNQR93QOE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Ra0A8gvZWpxO3dV57jJxQtcMtBgqHhbMsedx0sWbyAAxUv0Nfz+zpPbgUQhXfdR77 38jkUQpcXSNKBlaoBMeHbp5u6EGQMvTU2y8VG2UFoCt3+hz90Ede6PsCBUxetrIMhJ 3JT+Z6G+FcotxuVEtMjVQqnIcxDf4lmA95JIr44ZrwmF9PNzGSrUNjJT46doVBVoX5 vsLdPU78WeShn5LmJmdC30NBIPtbmFeSbUpA+EwCNOmW0ghEboMtJGKCCJmTLTCM6O bMhN83SiHyokHJn0GhcBIHVzAvJ8jxPIQ7kSDObLnEd3uLbREtAprnXxHVwFq6G/ww D1CJkHxDTjOEA== Message-ID: <59316f19892d2e7505b95500eaee25d6.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230430190233.878921-3-u.kleine-koenig@pengutronix.de> References: <20230430190233.878921-1-u.kleine-koenig@pengutronix.de> <20230430190233.878921-3-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH v2 2/3] clk: mediatek: Make mtk_clk_pdev_remove() return void From: Stephen Boyd Cc: AngeloGioacchino Del Regno , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de To: Matthias Brugger , Michael Turquette , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Wed, 10 May 2023 13:43:20 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-04-30 12:02:32) > This function returns 0 unconditionally. Make it return no value instead > and convert the drivers making use of it to platform_driver's > .remove_new(). >=20 > This makes the semantics in the callers of mtk_clk_simple_remove() clearer > and prepares for the quest to make platform driver's remove function retu= rn > void. There is no semantic change. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- Applied to clk-next