Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7900726rwr; Wed, 10 May 2023 14:30:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5o+pEwKlr4VSw8V9xF7vc7X4Ec+GWaYw8cgJtK354m1L2JycM60f3ZaOsaQPU+H/JVwH47 X-Received: by 2002:a17:90b:3ece:b0:24e:3413:c7ff with SMTP id rm14-20020a17090b3ece00b0024e3413c7ffmr28875315pjb.7.1683754210788; Wed, 10 May 2023 14:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683754210; cv=none; d=google.com; s=arc-20160816; b=K5yb5obRh64zlTrI4eCIRLlHrDD/tAUF4WuAaqzjNz4ZolhFRvAR9E/hZAczaMCnoZ K0M4qFJgktwui/swOEO9lVnN8eEXWzUQx8vgKS6ZkHcDp/u6RKcHa56Qi9L6tvgUxDiB 8bkIvKrAeXM9z/fRYw0o/CLiwkc4KXshLetJPOO2x3Jn+R/JLUew0zrffqGPJRo3qMiW ddGP/OGZGFo/5Dt5KMPU6KiwynXu3/GNvGGehiT9a+YyAf52Urp/e/Fd+U4p1ke2gcPE qEa+VVi3mJyCwezQP/QVZsA0oFMCvqvXH0i/h2MMvVxir9mFA2SAJ8dURV/GTm/BZcGK YT8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=NWDN1RwlRHt3BhJW4jKrvFXQD86CLGXa9KCbrw3P78w=; b=J5jnx7K9bh4KEt+ISZGKjfz24HWkMWmx1h8YLsUAq81ci+v7EZZEthHfs9ui3XV8Pz q991S7DCOKPcY2/Dejx97LbMcmgW16GcdSKFnpfgPXwghQ1JRBxam/zBVPN6uG0FDdTA PfrarEMi7oOqHLy5FgLDgTFaDAs/XAnF1QyhOKX8520WF7xzunXsCYoSDe/9qpgcvqX6 6v3IUPa1CJLA8xfVOqt4SSAPy1InwSsIbvxi0Y8gVw2gSdBtXwzj+NS9Cd6DypJN6+yz K8SeAdeZ0aBX8p1LF0qKuOVNyvY1iDnrQ1RCjuvfSrfCpQGDQiybnquN8Wt43vWWovNM Qk+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p19-20020a637f53000000b0052caed664d0si5071423pgn.259.2023.05.10.14.29.55; Wed, 10 May 2023 14:30:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236402AbjEJVUJ (ORCPT + 99 others); Wed, 10 May 2023 17:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbjEJVUH (ORCPT ); Wed, 10 May 2023 17:20:07 -0400 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F5392D46; Wed, 10 May 2023 14:20:05 -0700 (PDT) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-64115e652eeso53409755b3a.0; Wed, 10 May 2023 14:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683753604; x=1686345604; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NWDN1RwlRHt3BhJW4jKrvFXQD86CLGXa9KCbrw3P78w=; b=at+432Lf722bkVNauntLVLrbbo6Y8t7ysoSwU9H+ZiKMSy2HAINqJyjYYIXbvRK0GO CkXXDEwtuJ0DHgzGl8TQIAQZ4XPt3GIOznqD1WwBEbCOPw5FJ0YOTfp2ScMc2jOyCovk joKEUkOv8yS7kLo2Gd8K7MO+P2mIpfIkA2ru1ERYD5lXe6Gl9WJXYypGq9+KtFekkUo6 /ZkHVusdF4fQl3dw7rhkQkNpyPozm992aTTUAHm6V1R9D+uB2FsUXpkgIoIyzoPLrZMo oSUu0FMwdkiU/E+m3CXrGbYfeqkPBdBd6y07M7JWGdx5g+NR+DS5uLSYE/VAOcqEIZL/ 0AxQ== X-Gm-Message-State: AC+VfDyO2s7JO1xtwzhPAMbdIX3/OzbZM1LIyjxHONHsiVHoqaY9VyVk VWLF6AfnYd5jJbKbSNnuRnAPSc0ZY7cBYg== X-Received: by 2002:a05:6a20:7f93:b0:f0:50c4:4c43 with SMTP id d19-20020a056a207f9300b000f050c44c43mr21193080pzj.5.1683753604436; Wed, 10 May 2023 14:20:04 -0700 (PDT) Received: from ?IPV6:2001:4958:15a0:30:b447:995b:bf4d:6d9b? ([2001:4958:15a0:30:b447:995b:bf4d:6d9b]) by smtp.gmail.com with ESMTPSA id j20-20020aa78d14000000b0063d375ca0cbsm3929271pfe.151.2023.05.10.14.20.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 14:20:04 -0700 (PDT) Message-ID: <2adc2439-bfa7-c5dc-ca2c-609c98c9f924@acm.org> Date: Wed, 10 May 2023 14:20:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 1/7] ufs: core: Combine 32-bit command_desc_base_addr_lo/hi Content-Language: en-US To: "Bao D. Nguyen" , quic_asutoshd@quicinc.com, quic_cang@quicinc.com, mani@kernel.org, stanley.chu@mediatek.com, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Eric Biggers , open list References: From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/23 22:24, Bao D. Nguyen wrote: > The utp command descriptor base address is a 57-bit field in the utp > utp transfer request descriptor. Combine the two 32-bit > command_desc_base_addr_lo/hi fields into a 64-bit for better handling > of this field. The "utp utp" in the patch description probably should be changed into "UTP"? Otherwise this patch looks fine to me. Hence: Reviewed-by: Bart Van Assche