Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7901898rwr; Wed, 10 May 2023 14:31:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4mXHV6oj57DqKTvVN9g81UN0NARbsp7fWlyhHzxXM2wVDqM+iAbDKkJM1wveYvUTXFSpDG X-Received: by 2002:a05:6a21:9987:b0:100:c3ad:79a8 with SMTP id ve7-20020a056a21998700b00100c3ad79a8mr13744052pzb.1.1683754269086; Wed, 10 May 2023 14:31:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683754269; cv=none; d=google.com; s=arc-20160816; b=en15z/OZ6b5TOWwIIQByPybZxHXtHkvyFpQdzWHIxAepIRGTMpuUyMWVb3wwQT8BpK WjMh6FQWeatCbxec784WG5vEz4ZLJGek8aCyDYg7nUown+G2UtRrkn3KJ+JSaZU4o2gW NOs5WTy1fq1PQk0lSY06qxckQzMSY/rt/yTVnZQTjH4tvKDyDfVTdqzOcLheSKHN7QQU WilX52aT0b5PtrVnI9SXPhuvQgNbjbw3H+++yIdS50GZLJ5QVk/BERzcajfNLjIUvFtF 4GTcsgGKr4hZ34xrBp5BBXMlUDGDSnzUB8yENcLuqp1CLuSSAjUQBaFOd/M7XoGTiiw5 xm0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=6wnXuR0Uc2BahIDEvzqhRJQCaY9gzOEcQOGZoDtF2ww=; b=XxjyWph0643evOfPSNkCVDBTA+JMTejYG7YUa4ftfMB/gBONJMAkryX1lNWfUvA2mk Eccwj1nvG0jgoZ46ZyAMMBP8EAVsgbmo5hLkSlqKIEQgYGkpq+HEOrnpPOqYVcjZXGoh adKBsKO1sU9QVYfD+I43HDJIoQV3YIrHle/ul6LeW18pfoEinoDtlvfxTYyQZ0ePqKLO 9a0djujooqqHS6EP9Dfr81xIcyW/fMbDe0FNCUi7Ms8RsCL5RyPmKzjPHRwFYMFjsXdh HS12HKcHVRJMfdhpKBsmuhxdKyyVt8kOZxbNsX1ntt5bbqGYseZmyFkCV29Ib52iYLPb 3m+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OzMXZsLU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k198-20020a636fcf000000b00518ebc6f91fsi4858056pgc.851.2023.05.10.14.30.56; Wed, 10 May 2023 14:31:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OzMXZsLU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236982AbjEJVSQ (ORCPT + 99 others); Wed, 10 May 2023 17:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236812AbjEJVSO (ORCPT ); Wed, 10 May 2023 17:18:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58C697A9D; Wed, 10 May 2023 14:18:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD4786153D; Wed, 10 May 2023 21:18:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B841C4339B; Wed, 10 May 2023 21:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683753492; bh=6wnXuR0Uc2BahIDEvzqhRJQCaY9gzOEcQOGZoDtF2ww=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=OzMXZsLU2BSip09Tnai3Lsa4m/Vf/2TWC4pDIQm6uci92fKbsp7dPM+IRDO4emqKO xjAm2DdtUv/nSl/q+cXWS26Syv5ZD5415u1rjvX88fVDVtWtmRPIc5Dt2Hi6lG7PC0 7m16qX2e9QMLNVsRJRjdtqy/xpqmifr+TU1B7AgLXgYXz1RmBhB8Klx8YoS/hwWJBv Ln1knJdZ4hpPgujCm62SO/DsOkzpMn8ODkauHm95KlobPb3ifdyDiPg00lHIYgqMmP J21xGvcW1vr24/0lcfKX8ZdBBw+iOB4jKTlz8MmaOPyQps8e4467/vq+ab/0k0BvLd FQfo0AWIdllsA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230509021214.17105-1-gehao@kylinos.cn> References: <20230509021214.17105-1-gehao@kylinos.cn> Subject: Re: [PATCH] mediatek/clk-mt8173-apmixedsys: use devm_of_iomap to avoid resource leak in clk_mt8173_apmixed_probe From: Stephen Boyd Cc: gehao618@163.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hao Ge To: Hao Ge , angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com, mturquette@baylibre.com, wenst@chromium.org Date: Wed, 10 May 2023 14:18:08 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Hao Ge (2023-05-08 19:12:14) > Use devm_platform_ioremap_resource to take the place of of_iomap for > avoid that we don't called iounmap when return some error or remove > device. >=20 > Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and= allow module build") > Signed-off-by: Hao Ge > --- Is this v3?