Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 18:24:54 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Michael Shavit <mshavit@google.com>
Cc:     Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
        Joerg Roedel <joro@8bytes.org>, jean-philippe@linaro.org,
        nicolinc@nvidia.com, baolu.lu@linux.intel.com,
        linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/5] iommu/arm-smmu-v3: Keep track of attached ssids
Message-ID: <ZFwLph9WXByeHxAW@nvidia.com>
References: <20230510205054.2667898-1-mshavit@google.com>
 <20230510205054.2667898-5-mshavit@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230510205054.2667898-5-mshavit@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z6mdiL2760nXKCkODMe/GuesHtc0loc+BZfCGPNZuZzyU7t7r8pRuEfy0ntn?=
 =?us-ascii?Q?aClVC95jsNVfg6znWsfG8MGW68InaRTXKgsgOs4afzp9NaBvYrNNirnkT/cJ?=
 =?us-ascii?Q?0VN3t/P16vHhsZnmVOwpYlxyjOVAcDsByCkDsLVpv+hCYbdYQF/mpMLKY/tG?=
 =?us-ascii?Q?cmAi7xmL7fLMda3Dr3QAdEPSW3LZ3vESAdaCK6FlS6j85KUP6SLAWOMkt0Rz?=
 =?us-ascii?Q?/Tz+bixfNTmyTeTUjIPJYwprLFkVcmrLPfNK7vpYZ21mF9DJ7wUw8WbmoVgL?=
 =?us-ascii?Q?5VDxK7CoiAqbFhrAsACqZHANLadzjr9yWCpmWKoSdqCwOfLvPO3KbgwFiyiE?=
 =?us-ascii?Q?zvkmp3Q0rUwE3GaUA7pbpNY7KEpifSd4ArC93gx5HTmysusp0qCk3FVlwhmR?=
 =?us-ascii?Q?lKdaUfzQnAz1St4DgWjR5UbOs6s1QDIUAIC8PfI5UrVzFQj8y/athokBTpNU?=
 =?us-ascii?Q?YMdAdWGBgTX6Bs1LFYuocKxIhc14a6RiqXVWRUVCCB973h9zNAvHGmAIv9D2?=
 =?us-ascii?Q?BqJfF/IoDjvv0WekPe9ecmTU+ADGuL7Y5MpbKLRsOpwscypz0/sFTN32oIzo?=
 =?us-ascii?Q?nGcTEsWCdcLNU1Q1akttZFtgfoqRuZncq4D6RFM4dnjLqjxDy8HcC0jwruCi?=
 =?us-ascii?Q?VUQiIs56VDZVO3Y0R21lNpSYjmtxAIIQECnzENC5GJrETyyTdRL7kN/ZHqA/?=
 =?us-ascii?Q?/GXfOOCPK+0xGvMdeYUFMFKJ7OQZoS7gC6LedsL28mjIBCCSPsOAHSLGPX/v?=
 =?us-ascii?Q?9in9QGe7Ua78vimVvOcZM0GInYJl6bNmnaLLsvi02hAJhr8SHJUallU4sxuF?=
 =?us-ascii?Q?Y6w/TaSKIc1WjRinzsm7aT0FmG5c72GKTs/bZD+/wyJ8w2yUVzPakIDuD5FL?=
 =?us-ascii?Q?X6FkUriG0z/qcH2KJ9MnwysOLRbo0KdSZ2wY6zKRU8BtnhalUyfoEE17iP3B?=
 =?us-ascii?Q?DZgnpn+iXQIoWPKl2yM04xFSo82sqbYi1uGNQOq4cXpeMh/ofOxMzqTL4K6t?=
 =?us-ascii?Q?aj6jlkQDwV7QiNY6ldefLhbSY6TX8PvD9M5AzQtXhvTMeinA87FBCsuZXxx6?=
 =?us-ascii?Q?9mYV3UwTyaVSV8t668VERAfMIssoJ9P0aB/bxnvViNEue2K1xRvWL2MS4TD0?=
 =?us-ascii?Q?dq7nMK6i4k8Bn4Hj77HTNU4s/J3MFaWgU94+20GGoiAjrc1SokhS8Z/jbs78?=
 =?us-ascii?Q?+R3Si4vXJbeSbXyHwRSRCqObTf7JAb26uREh+4LlA7YwBH4ccCthjCGu0Hx0?=
 =?us-ascii?Q?ccmqc4NScNlG/tuP+Rg9xt2jl78nXbdQhFgMM1FQvsdKzt4XLoyIDVk4dCQB?=
 =?us-ascii?Q?CN0P45ROfHbzJPjDkg9sEwwRCuYp6vNWsEkuybo+8x/x7DzK0YpxkgUf2bEO?=
 =?us-ascii?Q?vealiUn88sFmEWvAR0hDbtdO7Wp3Njy8c04jitK93WzyhqjTzGEAFauRdlxz?=
 =?us-ascii?Q?zem4d017WOthjUP6HtN2xiqscagxcS6oIkmpCexSlw9p7wWmuYoQcg3CMD2S?=
 =?us-ascii?Q?hpGfHFJOfC+fgFMldN5+kMX6Po+/xN+W2H+UvPmPiIIyII76NOwfDHhnkG3i?=
 =?us-ascii?Q?lqCIRt7QaPI62k1xscg=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0e84db2-41fe-4efb-6a13-08db519d0076
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 21:24:56.4002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ee/Srr2exKMfVahvJ8qi8shz9A/WNeAUp5OGXnglry8ltR2I25+vQ4wEAswOR2JM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8943
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 11, 2023 at 04:50:51AM +0800, Michael Shavit wrote:

> @@ -213,14 +213,14 @@ static void arm_smmu_mm_invalidate_range(struct mmu_notifier *mn,
>  	if (!(smmu_domain->smmu->features & ARM_SMMU_FEAT_BTM))
>  		arm_smmu_tlb_inv_range_asid(start, size, smmu_mn->cd->asid,
>  					    PAGE_SIZE, false, smmu_domain);
> -	arm_smmu_atc_inv_domain(smmu_domain, mm->pasid, start, size);
> +	arm_smmu_atc_inv_domain_ssid(smmu_domain, mm->pasid, start,
>  	size);

You should be getting rid of mm->pasid in this series as well.

When each domain keeps track of what STE/CD entries that point to it then
*ALL* invalidation should iterate over the list of pointing entires
and generate the correct invalidation for that pointer.

Eg we learn the PASID from the fact that a CD at PASID xyz is pointing
at this domain and generate an invalidation for that PASID.

mm->pasid is logically incorrect in all of this code with our
multi-attach model, it was here because this code wasn't tracking at
what as pointing at the iommu_domain.

Jason