Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7903067rwr; Wed, 10 May 2023 14:32:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7mxlNww3gRVHG6cwbgcimN7qggllinE3w9467oQLP3Vq7fgfa3gEt4uhUhdwt06fUL7LI2 X-Received: by 2002:a17:90a:734b:b0:24e:5a5a:1050 with SMTP id j11-20020a17090a734b00b0024e5a5a1050mr19977761pjs.24.1683754338434; Wed, 10 May 2023 14:32:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683754338; cv=none; d=google.com; s=arc-20160816; b=aRfJtnV7Z/Dbv0p/QChNrSXaZIqVc4n2QcWZO2CEPZ28w1xzEp92MF8wFRcZcBrXp+ CzijMZw7wI+9rGyojzNedU8PPqm4G5UeTe1nMjaWdPwScgq60/3RgZiU0HqDwoSecjcf ypz4+LBuEaDc6vUQNAuLDFETsbyQmq0e0LFx/Aqvfxr220WwQJMOJSbx3F78RMUcH2PN vXr23aktnSxAhU5io0vFCgEcw9oTGP30w/XL80+6Vt2VSwuAh2+wH0ZQDdEZjcP3OSHs Zh+ZqXElzbkxbXQujug0r3hqxDOLwC4YNp0o+ltlTd2EfK3OVcKRiPuDqRcJYJbf3Fap OSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=IIacPj4XUMfoP021IVdaoKOIUKuOcFLdZdLoQ79NbTw=; b=oSkup0u1zr5Pwo9KQYlKxzWD90W121J3GOlhR/QZn4fpQRbBozJI5v+U88KWAPkrVt pHZhRrZK8Iy/PuIDSHwe+LQ1EByidq34cuWaZ8VuA0pCIu3Sjy2rwesmxnVzhBLDUvx8 MTRESitjZAViOfONft0aO7E9tnWwUGkCK2KtCJCgILBez5fIRgwXoUM/wJhLAMNK2hoY u+XbKjRNw0P8GiVd+pX9eScjgoD3E8kQcVfQquiqcJPAZF6GSA4gqCNPG6Gn6Ep4x6nL VEZIc9b39+/gVWv9XdJPIypIfMJgqC3DgumM3/xV/xLFZNhN4gHZYBm1R5UiTUb3mipx auGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t20-20020a63b254000000b0052cb36e0c00si241739pgo.223.2023.05.10.14.32.05; Wed, 10 May 2023 14:32:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236398AbjEJVZO (ORCPT + 99 others); Wed, 10 May 2023 17:25:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233254AbjEJVZH (ORCPT ); Wed, 10 May 2023 17:25:07 -0400 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC9034486; Wed, 10 May 2023 14:25:06 -0700 (PDT) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-643aad3bc41so6778944b3a.0; Wed, 10 May 2023 14:25:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683753906; x=1686345906; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IIacPj4XUMfoP021IVdaoKOIUKuOcFLdZdLoQ79NbTw=; b=M1/Uk0tfwFwd3/4w1ph2wc/s99ZM1E970mk0rPOBjbARSF5alWswy6a0Atyg7TmSBN dhCJ0iz0mNuq1brNhvHZ+889Ga6iapyq/prrxnA8OeI/MGzV9uGHPvhU10fNZ7tp0aXi 9vnD2o6+XB+YQ6nlX2kqYglSWgE+rtzzv36ZoCx0xw4exNSROHKbGzzyhjqIFf6m3Guh B5CbzlweGjk22ynKk85UmCI34Wf16PyTTuu333jQ9e1WfSVRzgXps44qLeL8mM1OKX4d pSQAgZ3acRf3EMn82+hgp2H8BmgwHGsBw/W3Ix9aPhyhh2TBmjsHje4xV+VEXKOwDC0O zb8w== X-Gm-Message-State: AC+VfDwo2SoARtJIMvGkqkH22CPXEmWNvitueBL1Vn8WtneRadezpoJ1 FVJFCRaAesISzYdiwICFKandOgKMZvaBdg== X-Received: by 2002:a05:6a20:442a:b0:ff:68f1:679 with SMTP id ce42-20020a056a20442a00b000ff68f10679mr22446714pzb.52.1683753906355; Wed, 10 May 2023 14:25:06 -0700 (PDT) Received: from ?IPV6:2001:4958:15a0:30:b447:995b:bf4d:6d9b? ([2001:4958:15a0:30:b447:995b:bf4d:6d9b]) by smtp.gmail.com with ESMTPSA id y67-20020a636446000000b0051b7e3546acsm3680033pgb.22.2023.05.10.14.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 14:25:05 -0700 (PDT) Message-ID: Date: Wed, 10 May 2023 14:25:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 2/7] ufs: core: Update the ufshcd_clear_cmds() functionality Content-Language: en-US To: "Bao D. Nguyen" , quic_asutoshd@quicinc.com, quic_cang@quicinc.com, mani@kernel.org, stanley.chu@mediatek.com, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , open list References: <6c9990cd13220ceea343b1e5ba463732c4ccffb9.1683688693.git.quic_nguyenb@quicinc.com> From: Bart Van Assche In-Reply-To: <6c9990cd13220ceea343b1e5ba463732c4ccffb9.1683688693.git.quic_nguyenb@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/23 22:24, Bao D. Nguyen wrote: > - dev_err(hba->dev, "%s: failed to clear requests %#lx\n", > - __func__, not_cleared); > + dev_err(hba->dev, "%s: failed to clear requests %#lx\n", > + __func__, not_cleared); > + } Please change "requests" into "request" and "not_cleared" into "pos". Otherwise this patch looks good to me. Hence: Reviewed-by: Bart Van Assche