Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7926514rwr; Wed, 10 May 2023 15:00:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7jshUjr8BlCQOnRG8vCladiRpySpuJ6dxARZO21cQerlVEEyvZ8yzMiq1MXEUfUmLH3Mrz X-Received: by 2002:a17:902:f543:b0:1ac:6084:1f4 with SMTP id h3-20020a170902f54300b001ac608401f4mr21880322plf.27.1683756027252; Wed, 10 May 2023 15:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683756027; cv=none; d=google.com; s=arc-20160816; b=EpsS/pb2oTuqVIHrtFLA++BQSizJal3cN89dODiskwC1FXmlptd/hZVEMP9lolnfXO N1qUro+1Yf41UBk0vCYHQNEMcDf70QwbTvh7hsIzEraIuSa3bnYxScJ5ax/EexmbquXV 8NABmgrA0swWz9LPy3z8F1lCOkWoMA4e0nNxDI9Fo5djnN20ionEpgfRRfEAs6Ey/5JU jYAL7dodX1LSFv3DJ5z2yQMVncrNk/CMiNQ55qHeo645uFwZRepfRS99kxgTjdZix+U7 SDC/o/r9LX72KzpgtILUvQCdvRE70s9s/I+uAOLbdx08HYxlD82Ffo1akrSQZYbJy5Nj ZEdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id; bh=niBRvOua1tXGMYCbxaZZeNyljGsY7f5YW77LPWud2zE=; b=AooDccW288jK6VzrxS0GnE6LRSR9LScQFJ4gaR/zY/JPdYcvrMRSoeOc4y4JHdt148 twxyiNwYsiKjwxG2dvYN3UkGRMyUur7TD3n3j+17rtpWdRzz/KxLtU6wFgmtxUnJSAud teHGOxtkNM9l9K2XS64zR/8clLI1sMahICj3Fd/IBaCW0EQnMQi7Or8rruMaL1+mRaHj 8aO0Eqn/EQ5nc3t0VyFNbzAPCTdDWgkSqPrNRmkn46wrg5wP3uY9RFiVLfsBN9yQIiQ/ IJ5HJ+Knh1U4KupU0Md/ggF9BB5YSSqfGrYzQBdWZc6J010cKD8q0gQ/gUarFq1cM+kY OhOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq5-20020a17090b380500b00250a2c9a793si328950pjb.152.2023.05.10.15.00.11; Wed, 10 May 2023 15:00:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231313AbjEJVqh (ORCPT + 99 others); Wed, 10 May 2023 17:46:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjEJVqg (ORCPT ); Wed, 10 May 2023 17:46:36 -0400 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 136F846A9; Wed, 10 May 2023 14:46:36 -0700 (PDT) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-643912bca6fso6265644b3a.0; Wed, 10 May 2023 14:46:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683755195; x=1686347195; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=niBRvOua1tXGMYCbxaZZeNyljGsY7f5YW77LPWud2zE=; b=Nt4NVWblvO9A4nIkS7TxNNggKxNIQpZZtmapJphrm33xzP2Vb2oB32qhmNazj8/org BWxVYQiGoDHMRTWPaJNoN6RYDxg8RU0UJbRrZjec6TpSzJ8HL2wh7nd89rIu4W0P9a6t bPQn+rpl58rMA3JNWmKfpHBMDmtNQFBomcDI/kChdqfFMK3Dcls7UKADV5P4OHvgm9Dx /B55NhNW1Q7JZAk5hgsYwz5yrE4rSsNgBby88H3JIF9JWh6PZVXoZNuCInZ2wRh5aRdp 0a8ebAVw6js1hll2HjWApa9CwHpL6FGDdVGbksw9PBwi/2Ikh2hyNQv93W1SXnZDtyv+ Wyuw== X-Gm-Message-State: AC+VfDzSDryxpAbgb+9Qkp5D4C2F/5uL5yuXrNKEaNxzOaDxCej47B0R j2d1j12y+HCMar8GBcoRuoI= X-Received: by 2002:a05:6a20:9188:b0:100:d061:52ca with SMTP id v8-20020a056a20918800b00100d06152camr13146462pzd.50.1683755195353; Wed, 10 May 2023 14:46:35 -0700 (PDT) Received: from ?IPV6:2001:4958:15a0:30:d8b7:fa5f:6808:3db3? ([2001:4958:15a0:30:d8b7:fa5f:6808:3db3]) by smtp.gmail.com with ESMTPSA id w25-20020aa78599000000b00649281e2f03sm228362pfn.141.2023.05.10.14.46.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 14:46:34 -0700 (PDT) Message-ID: <3414fe25-b107-f11a-db14-d086233047b7@acm.org> Date: Wed, 10 May 2023 14:46:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH v1] ufs: poll HCS.UCRDY before issuing a UIC command Content-Language: en-US To: "Bao D. Nguyen" , Kiwoong Kim , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, beanhuo@micron.com, adrian.hunter@intel.com, sc.suh@samsung.com, hy50.seo@samsung.com, sh425.lee@samsung.com, kwangwon.min@samsung.com References: <1683620674-160173-1-git-send-email-kwmad.kim@samsung.com> <991cac52-22bc-0150-4332-76ac044c5bcb@quicinc.com> From: Bart Van Assche In-Reply-To: <991cac52-22bc-0150-4332-76ac044c5bcb@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/23 14:24, Bao D. Nguyen wrote: > It looks like you are sleeping while holding the > spin_lock_irqsave(hba->host->host_lock, flags) > in ufshcd_send_uic_cmd()? Right. Please drop my Reviewed-by. Thanks, Bart.