Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 15:01:40 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Raghu Halharvi <raghuhack78@gmail.com>,
        <linux-cxl@vger.kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        <ira.weiny@intel.com>, <bwidawsk@kernel.org>,
        <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>
CC:     <linux-kernel@vger.kernel.org>, Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v5 1/2] cxl/mbox: Remove redundant dev_err() after failed
 mem alloc
Message-ID: <645c144483244_91698294ac@iweiny-mobl.notmuch>
References: <20230509165218.139568-1-raghuhack78@gmail.com>
 <20230509165218.139568-2-raghuhack78@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230509165218.139568-2-raghuhack78@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fgnoxI9jnL86yRV6zud/0RGHPFaiRlrDpjbGK6zkNOZkwxQ7br4xhUyH7zv0?=
 =?us-ascii?Q?e8ByASzcnNryk3IlipYkyfWJiOU4fAJufXlOcpxN/K0bNZcIYzFXrSTkSsQs?=
 =?us-ascii?Q?jqDcEgAxA9+wSHEFXWGY5D6m/n4YAHccIrM84SQrlCtwuGgpGpgjDqjP4k5g?=
 =?us-ascii?Q?kK2zLpZNlwkzUf6vwWVH065UPia0EmDC9P1mIdkJdRgw9TozUxDfPHBcR97l?=
 =?us-ascii?Q?Q5x4n84RcIAC3f7p+8noTWJ4k8/d4ye6sLEMzyo8nK/x9bet66FweMrP01IZ?=
 =?us-ascii?Q?/EpzWSuct/q/OJquGf5b42GBq/qDm6wVxXvcKz69T6O7Z6tdsINYxt+Vl6n3?=
 =?us-ascii?Q?ix/jwTqRHBAm1Uo+sXqMgo8s0UfkDK+peli8lM5MZuKHSjNYxMerozRAmg50?=
 =?us-ascii?Q?QdluBZIcfVRCWy3LCaVfvoeYNUiZlx7+r7wwR+wHiIKOvqyKGg13dzySQCKo?=
 =?us-ascii?Q?LdiJzgf0fISo1CyuBaccRD6VBzw357pbBNTmTRjKDNEF0+5RXPkobtcWjhqZ?=
 =?us-ascii?Q?y1BheHca7TXGBMntG1++2Xp354jImoCGEZtkfgXF+z8FtbEcmyJkjrHryDe0?=
 =?us-ascii?Q?wv5F8w2MHxTSIh4nAbYRQOBH+ktqH/sT5CiBL5HmgunBhUcoH9F++H6aRTnF?=
 =?us-ascii?Q?IA2gzqRPFO+N5TV1SYpL+WhbDlnen1sMWCDhTKJm5DvV6el9QLPlmfzcu29i?=
 =?us-ascii?Q?JLES2JeOgoTK4NoT5MmFkjuSGJZcEpQxgzJWMPrDph68iyKSbW/gLQVfINb3?=
 =?us-ascii?Q?kIx5WydlwunDBjmzy5tlqrpjHu0cNSxnYObg3WxkZ2OQjNMNSH8BzONYdVzM?=
 =?us-ascii?Q?XOuehaFj0ec7x5+90G61Q/ZLOk1Dc4gZoJLHBIfcOneUtM6rxwB0oQBxo1Jd?=
 =?us-ascii?Q?huw6BAEobZzTyL8UYNWrfCb8ps/H7ssVedal7Hd2SvTUUkr6QDD1P5E/M9yU?=
 =?us-ascii?Q?0rldOTVYiuf72pfF/kvPuIOWhyQGxiBAEJJcokPjNShxUedXdQjUBfYu9uu6?=
 =?us-ascii?Q?Z0Z0iScJ3g/v8byHcbCfGQvpxesUyvrwUHFd+lODcEV/Yz42nF0LKEIXAIoo?=
 =?us-ascii?Q?vrkOTtQnpXetnbj3emLtYCTnUXLtzk3leci9fGY86HeC2So99EUHrFCkA+rW?=
 =?us-ascii?Q?01YfxXe7Yy7ieTQ3Ez28r2gUsmjr7WpyxpD+WGKsFyfQQDIn2XTTOjvKWzcm?=
 =?us-ascii?Q?wk6giUquEtmg3xM+1U4PV8G/Lpr9q9526ToS10JXYAAFYrVdShOIByl7eLfC?=
 =?us-ascii?Q?De902DVyZR8NTZWqBf9NxR9NDKxnADBeYPjw8jWm+4P4Kb2EgImoDxRPu6a/?=
 =?us-ascii?Q?jVAXKj45REc8B2Jp8xFf4gF8G2OiOwUA+Y6tDO40ds7RuEUqbapfffANBdPN?=
 =?us-ascii?Q?lZwdos7bBi5SATX0b6lQq7bUTmaYchQ+MnaDjZRyYK4o+E7EdVFzmr481lXT?=
 =?us-ascii?Q?Ebhd1ZIMXCSSocl4R0BoKv8wDB9fNpQW1evh1onUvOPN+tXuqw1K1Q9OPyrj?=
 =?us-ascii?Q?ogFemo7+ik3DWRGsuiLOw43iNMu9/tc2XrCkdty8G9wEgZ+H2LrGWFEP/QAH?=
 =?us-ascii?Q?5LOI32S2VHHQ1i1fAuPzkfk6eapvXWNiy5NkuOpF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dce16d54-b791-474f-de69-08db51a22484
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 22:01:44.7308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2GnsOt1SMwk5RoUxvuI9zdwKZsG3xSYfoLC4VIdG/ETKF8NTaClCiuTtA2kqKteQSVv7jy1BY9gCQFF2GGGLZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4958
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Raghu Halharvi wrote:
> Issue found with checkpatch
> 
> A return of errno should be good enough if the memory allocation fails,
> the error message here is redundant as per the coding style, removing it.
> 
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com>
> ---
>  drivers/cxl/core/mbox.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index f2addb457172..11ea145b4b1f 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev)
>  	struct cxl_dev_state *cxlds;
>  
>  	cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
> -	if (!cxlds) {
> -		dev_err(dev, "No memory available\n");
> +	if (!cxlds)
>  		return ERR_PTR(-ENOMEM);
> -	}
>  
>  	mutex_init(&cxlds->mbox_mutex);
>  	mutex_init(&cxlds->event.log_lock);
> -- 
> 2.39.2
>