Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 15:02:19 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Raghu Halharvi <raghuhack78@gmail.com>,
        <linux-cxl@vger.kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        <ira.weiny@intel.com>, <bwidawsk@kernel.org>,
        <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>
CC:     <linux-kernel@vger.kernel.org>, Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v5 2/2] cxl/region: Remove else after return statement
Message-ID: <645c146ba238f_91698294a5@iweiny-mobl.notmuch>
References: <20230509165218.139568-1-raghuhack78@gmail.com>
 <20230509165218.139568-3-raghuhack78@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230509165218.139568-3-raghuhack78@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XSIVB+DrpOVTuJnACKfIxevtB5lEwGDqVDm4ByOpZI7GBUKFOXIJ14qxhvZ3?=
 =?us-ascii?Q?Ogq01bqWfXNibfxTw10ldZuXFlv2gnCz9i18T3gSOK4lXoOpBgGqNGUNmAeX?=
 =?us-ascii?Q?eGOA+KMfE80xuo+dJSOoujKZa0Tc2QibfbUYXKUeCLvcSwIwBYdyKWIKLjBB?=
 =?us-ascii?Q?rHm9vOKvecgLgn8b8SBvD0vqnoLYAgiC/PNcN9oyfhG5TrzK9GsRrgasO1LK?=
 =?us-ascii?Q?R4CjJ7KtlA+8bBvOXvqzM9bkCU7IIajo+fEkq/9YG8s92T/5sWx6gVGsDxcf?=
 =?us-ascii?Q?GQIjN/Fq9eAArUVZN6i+JGzVJU1fC677XDrluQQbZBrqfG0vVimCYC/3oOpj?=
 =?us-ascii?Q?L2ZX/raanZN5stVIUJpK/nmJ6XHplISBTsrIAK/QI3MpJoP0kYZIPm324V5X?=
 =?us-ascii?Q?QWH7FIThlbx22lGN/56xgV3rZvkh7Njbfg5tPq1HcjI69bviNCrRq+MxEdE5?=
 =?us-ascii?Q?SsR3Ji6E8DLmqLTsiO18O9Cy0vi5aF33GwIs7O3H/VhCIJWXSHFtuQql0MaF?=
 =?us-ascii?Q?u9SzSaxfXt5ZFByIQo/ZxotKqcaNfc0bjzkq/AJmMZOQ6/WYlRzJQoVXZqyx?=
 =?us-ascii?Q?8RAg0CWGhnf0On8Co6I2e3sfjtGI2E9u10J9NcsRZAkegebE+Rm1qHcXFNXc?=
 =?us-ascii?Q?WnYeitlZ45Lnq6Td1GSkou85oJH6NUjBP/jO8SKekPME35gdO+WcCb1NZaJM?=
 =?us-ascii?Q?nunI68YgofiXUrHnwsKpHymblZ2i2SnSzF5M5VDTmmWcGyow4GqqXOJI5zRc?=
 =?us-ascii?Q?BPAKcO4nbCEOPWKwFQRGW63YtyeDg4bPNTNGDqPZFRM4ldnU5HMOrBBvTqQ7?=
 =?us-ascii?Q?AgmZe8bkyK2V5bMlMHMY5w+pndZ6JO065Sx2gWCM5fIPUduAmn4U7sDJ7jnm?=
 =?us-ascii?Q?t/ozYCnKXF+jvyNNV+7+TfsNLvne8bOYM7omqV8DKgyN839tHZud43OGCPYQ?=
 =?us-ascii?Q?uM72IGzITqqS4lhvZQajYp3WDMJTtLJlB6Eq31Xb5u7kv64tdOcS14GJtDah?=
 =?us-ascii?Q?9T5puzxRM6wgnxGfhUHbv0y0wTlTu7Je/ogyD2RB0DA92rLGLyG7hFmb7M6Q?=
 =?us-ascii?Q?+zjuR8/3AMFXNtXb71dDlDGvZdStL8Eq4iHqspVvhQSxLwUOosRjI1ZcBfy6?=
 =?us-ascii?Q?YyBEApuS/DkWtztX+E9/4VUK2Hgqbk5Bt7buj+E9FfOr7EJO/e854GRZHHsq?=
 =?us-ascii?Q?sNVJG36KqAL6aiDjUmh+yy5w2IyhxHozc98lRyHlaqZqmE/onqAH/CY3w7lD?=
 =?us-ascii?Q?pUja7L2lqf5hvhUWhrqaGaYgCFfN857H1e/+iJemOj9TFE5T0Uc6306uPn8C?=
 =?us-ascii?Q?YRrDb5qbSvSAt3V8G07TvH85PLjsBuvCEoD5jotVWeJWkY1e61Zr01xUGgTJ?=
 =?us-ascii?Q?hDO+wyA52PLrwVXEKDjwxvFOGNqKst7tPrrSBpBlBy7pBRy1szrDjYICXq58?=
 =?us-ascii?Q?+KPKs/qKMqyI2RnuIdvnPGr90LdB9AnGgegByUlKfPxZDK4Vh6vmn3O/sAkH?=
 =?us-ascii?Q?lI4HO5Thz5xGfAKlO/F9+Z1ImO0epJJKLrQ1lNnlVTg5mNxMcpog7BXm4jk5?=
 =?us-ascii?Q?iBBLluWCvhf+hsCWewEFG8ChRUejae2CdBxrn1vJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d28c8a9d-6d42-47c9-9eee-08db51a23bed
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 22:02:23.8594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DVRz0271Kk8uQ6heelyreLV2T1hRfh3p+Z9iz1O/hzMAM8FSH3HeVQ6vgwljXrOyMnSBHioj+mJ0Mu1BZ6v45g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4958
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Raghu Halharvi wrote:
> Issue found with checkpatch
> 
> The else section here is redundant after return statement, removing it.
> Sanity and correctness is not affected due to this fix.
> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com>
> ---
>  drivers/cxl/core/region.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index f29028148806..a46d6ad9ef0a 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -2666,11 +2666,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
>  				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
>  			clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
>  			return 0;
> -		} else {
> -			dev_err(&cxlr->dev,
> -				"Failed to synchronize CPU cache state\n");
> -			return -ENXIO;
>  		}
> +
> +		dev_err(&cxlr->dev,
> +			"Failed to synchronize CPU cache state\n");
> +		return -ENXIO;
>  	}
>  
>  	cpu_cache_invalidate_memregion(IORES_DESC_CXL);
> -- 
> 2.39.2
>