Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c95dae02-ba49-8a30-24f3-687810ec1f98@intel.com>
Date:   Wed, 10 May 2023 15:08:11 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH] dmaengine: idxd: Fix passing freed memory in
 idxd_cdev_open()
Content-Language: en-US
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
CC:     <error27@gmail.com>, <kernel-janitors@vger.kernel.org>,
        <dan.carpenter@linaro.org>, Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230509060716.2830630-1-harshit.m.mogalapalli@oracle.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230509060716.2830630-1-harshit.m.mogalapalli@oracle.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzhJVTI3U3NHQ082RFFHQ243dVV3eHFEdFZXQXVtN2lRSERtYlRSMjNlamh1?=
 =?utf-8?B?VVpzMUt1Q1FDbzZvQncvdXZkK2lnekpmUG5XOFV4TUtZVG4rS214dkN2MFM0?=
 =?utf-8?B?c1JRU1NMVlAzQTljdXJNc2ZXRUMxYldYdm9hQVUwbWtXK1hHdER4dUtaS1pt?=
 =?utf-8?B?YnJMalhKT3lLeStmOE9qdVJLK2VWMWlQRlRxditsSWoxR2JBSTZTL2lOdnZH?=
 =?utf-8?B?V0FLd0o1OFhQMGdka1hXdUdtb3E5Z1hYWVQxaUEzT2VZcnVjeWlYWVY5MWVm?=
 =?utf-8?B?R0JIVGZCdG85VEhyeWZDTVNldU5wNnBBR2EvZVZLWVBxNlNVdmRUUTZHalVz?=
 =?utf-8?B?bVBBRkI2TW01eWc4K0R1RUw1dnhuQnlSU05xaDBPaWY2bnAwTVlOSklDWnYw?=
 =?utf-8?B?NkpiV295cUFFSFhuWXNVOWpTOE5iaXRqNG9jMU0yVmtZMVpReDhSZ0JLODRq?=
 =?utf-8?B?UGpTbmpYdGZBMlM2K0pNYWdzTXcvR2YzSmdaRnZoUXBVUjlGeUloeHFCYU5K?=
 =?utf-8?B?UUZXZVFxQXVXZFBjbVR2QWM1R2pQaU9wcjUveWZUOGhFUEpaaVI0c2Rnenda?=
 =?utf-8?B?Y3pjQkp3YzR2a3ZSak92dGw2VEExTno5cCtRdTRrc2hYa2lnU2s2MkZodVdj?=
 =?utf-8?B?eW9FMmhBQXBSci90aXFUZVk2djVKdGQ2RHp0Y1ZaOVZTT2RpTDhVcVhLRnFE?=
 =?utf-8?B?WnNyTmpEUDcvUFh6Wk5xVHBzSU1BYUd0WHZPRWp3Z0xHd2xvSTdELzd5T0lN?=
 =?utf-8?B?K29XYlFEWWRxTkdoL1RNZUw1K0FBMitaYjBMOHVrQUx4cE56TFBUT1IwMDVi?=
 =?utf-8?B?NDB4ZnAxdEMrR0VrZ2lKME8vQ1JzV3VRYkpWb3NGYlpoc3pvdnFBdW9BSXRI?=
 =?utf-8?B?cUVTK0dVRVd4THFxVVBjYlNYVlRkRG0vZS9jZVhNVnhiNnBFVis4ck9WaFpz?=
 =?utf-8?B?amNaTlgxdENSY1pseW5GNkJNcUE2KzJ5Y1pnL1ZIUy9wVlhDK1RkWjV2UlFu?=
 =?utf-8?B?aXhaeGRJRjRXWUZsSGpyUnQ3TVAvWHJvbEtyb2RJWFFEdlVMTXJRL2h5djVN?=
 =?utf-8?B?MzhhZXlLVUU3SUo4eFhmN0Z1RG84cCtWcDBQOE9CYzZyVzZWZG1yVEJhSnVZ?=
 =?utf-8?B?Z1JYb2pwc2JKWHhUaFM2RDNYWktsakNGcGMxK0g0UmRmaXB0bVZNWEhXeGFJ?=
 =?utf-8?B?dUp3cHlHcVBLS2M3aEhXQk9rUzdMS3hRLzJCYmkrRWF3eTVuMGJGOUZSSmFK?=
 =?utf-8?B?ZlRYZUwvbGJFUWNWM3pDdGxrYU5DV3F4Q0lnamROdFkyTjZSeTFwVFJvZFh2?=
 =?utf-8?B?VThUU1YyREplTWxsMnZWVUhMZVYzN3lQWkNJOE12bmxTb2ZOM25ndTd6Tmdt?=
 =?utf-8?B?cW9FeGphV3hIMnNBeU5EbmFTRm5rZWNLMERISllIT3dMazZNaW11UmlCelRo?=
 =?utf-8?B?ejZudmRtMW85cEJXZ3crVEFJZ3Mxb1BjYnIva0tUNm83WDl5d0tOTFpwSEk5?=
 =?utf-8?B?dXNPY1Q5dFNTOUdFVmpxMFh0d2lYYXUxZjRUYllBWFdBK2RGSisvcG03WExW?=
 =?utf-8?B?M0VZdUV5YVdScm5QT2VqKzFGdXlyZE5yelBGNWw2UnorZDNSVlplWHkzK1lr?=
 =?utf-8?B?c3NEUzNMeEhtMXFlMVRnL1dVNXZNZW1lVkR2WlBMRkZnRHVDbERQS2Y2TVFZ?=
 =?utf-8?B?WkhKMmNnQW5vZU0xdzZqSUttZkRXK3ZSRXorTUdVSklGS3prVnBnZHhMeUZQ?=
 =?utf-8?B?Z2wxUUZpVmZ5L1kyclRWNlNqNmg5T2tNWWgwMGNLUWZJUkJuY2pGWUtjaWZy?=
 =?utf-8?B?UGdDUmFzUWdNbVlGQndEYS9wNWk4bUhPZnB2M1pJL1JLZWpRSHRJWHRzb3Rv?=
 =?utf-8?B?QTB5RWhWZFp6M1ZIdzFwR0FORm9FUGp1bXN5emorKzFqWFdpblcveEg4ZDRP?=
 =?utf-8?B?VzhvRCswQjArOTV2aXEwUkhZVVZDMURqdGpiYUpxenZBY0g4WlQwcWdEV1JT?=
 =?utf-8?B?ZWFhVVV5ang2MEhPRDBFRVYrNDdMQWVzQ1B5TnJ4UGlNMHAwN2ZNVUVkWGFj?=
 =?utf-8?B?VXc1TkRGQi93eXpwRUE5NTVkN1h3eVFsMVBocVdNS1J2OUxxazBHQVJKaktn?=
 =?utf-8?Q?GrDldyKIhzCnFj6KC9b3Q3XkZ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 86c4bb58-bb47-4aba-b96e-08db51a2ffb4
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 22:07:52.2201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PXeTvqEEuToiymA9z8DMT6/lhXd4aR8RryMZIyEfpYpccS2eteOOU8NfQvNileifyafQ7Uuot7uuQ5LXTDtA6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4828
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/8/23 23:07, Harshit Mogalapalli wrote:
> Smatch warns:
> 	drivers/dma/idxd/cdev.c:327:
> 		idxd_cdev_open() warn: 'sva' was already freed.
> 
> When idxd_wq_set_pasid() fails, the current code unbinds sva and then
> goes to 'failed_set_pasid' where iommu_sva_unbind_device is called
> again causing the above warning.
> [ device_user_pasid_enabled(idxd) is still true when calling
> failed_set_pasid ]
> 
> Fix this by removing additional unbind when idxd_wq_set_pasid() fails
> 
> Fixes: b022f59725f0 ("dmaengine: idxd: add idxd_copy_cr() to copy user completion record during page fault handling")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>

Acked-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua