Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp8004418rwr; Wed, 10 May 2023 16:22:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4fr12WvTvuK1oWrF1IqwTZfcFXQ/c4JBoLTpdJd+bpyyf5FMTbveey6fmKQtdNn6YhD7Oa X-Received: by 2002:a17:902:7783:b0:1ac:8cd4:a82d with SMTP id o3-20020a170902778300b001ac8cd4a82dmr8554855pll.27.1683760933147; Wed, 10 May 2023 16:22:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683760933; cv=none; d=google.com; s=arc-20160816; b=H3D8yfZlKlBuJXASlO1/m2lZIg2ool9Gw1iUrhqXFw3Wjcwop0OnE6UnZ4RqZn2KbC 3Vs7ZPOyzbBph2a/QPvq4IsU5uaxYtYSLcC83vBIk1oPuwhZeoEsMtmQm9kS1pN0c87a n6zvLqv/tdqiPuRK1JRGy7bfhqPCvDcZILCSvUASYk2NDvfaUTk1gm7hlLOoNZuubj1z uEty7ZfgswmS/MRdSqVHY1Sio3vjO1tGvPkqfXCaNwlkf1ci7vILf6ELcX3gvXt1pejx H73BH9Fbr4Dgp87amE5qsN6YNHRtt1JYus5o/W/fycumE2tGcobgZaDmBfRwXNdcCW/i /Apw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZiW05wKPLD7YCuYetjd69zZZPcMJTzbLVXYOQGMznZs=; b=XgwahjXk9m6SHP8cSm8e2LWMoOvy1A8c/sOlMVrjm3gobMUFfdlqFankDaWv+TDOMr EqWxsq2WC94IxDbKXbxI06/HdWIgzN/xLGRdLFQMUYt3973PgxH1xsxG6Wsa5HeiAoUK psThSCj2j0/qcFOU/211qfWA8NkRSm7F+w5SGg5arSUM8GYe4SN3HdYEKz9N3CpQm9iw moNjClUHI1kptxt8woHdoCJjtP7mblkArAROZ5/GkK/IVEh7lWjKWSSlB7W/D9KPVwf7 9Xeq3fSAT8M1e12eSc2I1IZTAXnayqdeLgpUtFpWaU0POiW5e/uTzCt/NLaKbVsIfz8A uFtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=pqftOVm0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020a1709028f8200b001aadd02b88fsi570804plo.233.2023.05.10.16.21.58; Wed, 10 May 2023 16:22:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=pqftOVm0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236759AbjEJXIR (ORCPT + 99 others); Wed, 10 May 2023 19:08:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236313AbjEJXIQ (ORCPT ); Wed, 10 May 2023 19:08:16 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFAA1B1; Wed, 10 May 2023 16:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ZiW05wKPLD7YCuYetjd69zZZPcMJTzbLVXYOQGMznZs=; b=pqftOVm0RQw6AHZbB4QudUbxlg 8PgU+yebmovbsSnp8RZBjrUQFJhVdeMBQQwMcCduSxr7WDEHL5YCc5RlH8vc6bgkYamcRIt5ZXpjp 1HP6XP9yECMPv8vBm73DFd9t1kboP4PHvRdJ23mq4OjW4njtl4GM/3+WsxO1hu1wAzjA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pwsue-00CUfW-GC; Thu, 11 May 2023 01:08:00 +0200 Date: Thu, 11 May 2023 01:08:00 +0200 From: Andrew Lunn To: Daniel Golle Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno Subject: Re: [PATCH net-next v3] net: phy: add driver for MediaTek SoC built-in GE PHYs Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int mt7988_phy_probe_shared(struct phy_device *phydev) > +{ > + struct mtk_socphy_shared_priv *priv = phydev->shared->priv; > + void __iomem *boottrap; > + struct device_node *np; > + u32 reg; > + > + np = of_find_compatible_node(NULL, NULL, "mediatek,boottrap"); > + if (!np) > + return -ENOENT; Is this documented somewhere in the DT binding document? The rest of the driver just seems to be undocumented magic which nobody except the vendor would understand. Reviewed-by: Andrew Lunn Andrew