Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp8130712rwr; Wed, 10 May 2023 18:49:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7pQnuAH88ra0+PGJfb9OXsAW20bgXxrEgcatnM+leBoZ+1GUqKwWkF4Q88TdXjxKZHdENY X-Received: by 2002:a17:902:d487:b0:1a9:9a18:346a with SMTP id c7-20020a170902d48700b001a99a18346amr25952600plg.5.1683769759077; Wed, 10 May 2023 18:49:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683769759; cv=none; d=google.com; s=arc-20160816; b=eyIjqbFuUUNTd4Qu26p3ruO5n202Jxm2zistt7KVIy5h1eWXm1QA+xCo5P6oUo03e2 rqVvfmU5vmshAKoSvRPdkgW1JF/Ffz1Dt83hE36ehXvGIYI3A0xQeIyGWNe7+7RhPNOB MxMLCGob+5BcbU1Jcl0/kn51yCWVCjuSBbulkfsUV4ppbaGjcw6emzFE+bYvyvO+k5ex SCYkV2Jbzavj6rGQ5sw8eg4K9tFWMJNdnfwHT4YWjQP/AjbHr8CDSmvdgwE7m0e4nEjA mGmyRDLY5vL67rHkw/NP6KU+LXJPP9XcF4oVx0dkqWnchOj94kDKF/nBw7Dl5I9qEA9H Gm2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=J4LmcSEltNprRdLvantG48ZeDxHEKZh6QER1dwTt7us=; b=Pd6lp00wSczudbP0Zy8Bb7djomS2RkYd9gFxwyUBQ+KwNtB6WzVIsX3GD+HEVP3Wmh 6RqtoQnPBWWpkPO741KqHpehiRV7CCROdlGHu4xUTV0EILfizHHGbmqZtZ/Nm3NI6PMe oAM/E1NXHwAFu1jfb13QMxmG1v17z5Ra75p5iHwH+iemQnju1WTJX0vKVcS19VpuGB4K tFHMPiVYUFZCAFwdYwpQc4JpjxZY3sC+mJjgsnWF0kQAClctJJrunq2dU4hYHseJpPpQ CYQlfJy6zVK64iVXR2D+/EKsm742qw8YLaV1D0QEcatCj95fh5wQ9vheji/CNaAzvxBx NtFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IAhOu6Lr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o1-20020a170902d4c100b001a6709378c0si6052121plg.333.2023.05.10.18.49.04; Wed, 10 May 2023 18:49:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IAhOu6Lr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbjEKBeK (ORCPT + 99 others); Wed, 10 May 2023 21:34:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236786AbjEKBeJ (ORCPT ); Wed, 10 May 2023 21:34:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58C2D6A4C for ; Wed, 10 May 2023 18:34:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E29064157 for ; Thu, 11 May 2023 01:33:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8A9AC433D2; Thu, 11 May 2023 01:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683768839; bh=ehqsTiJeXFoWkUX5m5q0zk18w02eaYb37H/12j3Sn0o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IAhOu6LrMht7xbTJep54i6CMeulj3I6IaiVMsI/5MkwveegjGXHRYDTJX+0+mFQHv zpi00o+jL4R/ExIKZ4pX96puTIutUnwczhPtBpsMilapsVzs1cUFBYluTXZMK6Innp toc4yivNoAXKNC5RaBbS76xqCPAfJ8nyvTlKWnbSjNnBX1WgQQgH1D0avorewZOX4s 6sEAlYIduBkv3esrsb62oKZFan4AWeT6PD0tbTUcPagclZuikmOuF/IDIzMvFbzBsD 8Owff3bWC8iKsyHFCULBd/InX9Qjcxp19ty4naH8jDTAwBC193pISEU4M0H43J2wgc vDL95Ri8C3eiQ== Date: Wed, 10 May 2023 18:33:57 -0700 From: Jakub Kicinski To: Angus Chen Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: Remove low_thresh in ip defrag Message-ID: <20230510183357.1b8501fd@kernel.org> In-Reply-To: <20230509071243.1572-1-angus.chen@jaguarmicro.com> References: <20230509071243.1572-1-angus.chen@jaguarmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 May 2023 15:12:43 +0800 Angus Chen wrote: > As low_thresh has no work in fragment reassembles,del it. You're not really deleting it. Please use spellcheck. You also misspelled "unused" in the code. -- pw-bot: cr