Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp8142814rwr; Wed, 10 May 2023 19:03:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4BIOz4ki5uNdAZUcbvrMiVn27Cp8VTlV+rkmQ4aP4rOKDFDHO6KOPIEuLibIombuRph8ul X-Received: by 2002:a05:6a20:3d84:b0:103:ce90:f3d2 with SMTP id s4-20020a056a203d8400b00103ce90f3d2mr952236pzi.9.1683770625641; Wed, 10 May 2023 19:03:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683770625; cv=none; d=google.com; s=arc-20160816; b=U99j5K1GgtdDAdKdTFjiHuE7CTNKGYMwC509YET7oZ+R7JQlUD/H9Hx1Y2VF2Eb+NV xAyOb7WiMDS59ZJl4hbIY6lYgH24AZ4nTp7HxculBO20tnnhMm/ATjfgfeKusE2QQhP/ XNuN+3q3U1w1MxMd4RFxGbVZWWtTljReSASrJIg8WM2W/AWU4NBAp62Lhurg6QIRpaul edOruLkwoHs/bLl1M3l5S0DEW+DKGQW2kmjv4gNlIEU0UihgMYwR9wk90891/ELDjwT7 Su2S6YkrZDD09JAsSLGbdmWSVHoHX8zWdhpt22s1bhuf+tersKoxmOnhhsEzLwi+qJwo pzCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:cc:date:message-id:subject:mime-version:from :content-transfer-encoding:dkim-signature; bh=TCXfahH34hYJqqM1SC8s3Anj/uF5zt4/S2+/aK5TN+I=; b=uzRhzpD3RdRIpmCEbNiJQFcMmTKap6UBcvMPQ7OuxB/GQlZuFoVvFajwe1QwNd2luP NCK3oy8EZp53K40RaDcU3foyR9NMoRkuYJqp2NZK7TO9u8VovlxeetoGesFIkSd+bWmU rQjB1RJGT+odmA8jYZIANeqf3uxOtuhadvLcprddbyjitHOiq4B+UNNyc0ALIOO9i3mZ olqmGqKMPaAi/Orl4gSfFKPcwdW7eTxkAnTzya5KyZcuAYL8wtyBiT0EUbUIc48SxbKn f673a7/Iemf+MOI3+Nv+NEISwwCxUTSkgpZm5XnsmZBljupGpk46ESlSpX34peoiVOpa ZFmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=lYFYwiPr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m125-20020a633f83000000b00528ca427963si5486225pga.709.2023.05.10.19.03.31; Wed, 10 May 2023 19:03:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=lYFYwiPr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229461AbjEKB5W (ORCPT + 99 others); Wed, 10 May 2023 21:57:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjEKB5U (ORCPT ); Wed, 10 May 2023 21:57:20 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.214]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 67B1E5B89; Wed, 10 May 2023 18:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Content-Type:From:Mime-Version:Subject:Message-Id: Date; bh=TCXfahH34hYJqqM1SC8s3Anj/uF5zt4/S2+/aK5TN+I=; b=lYFYwiP rORVUhXZD/CUiM4kmhoO3M+EWN1NOs6+lYJ6oOfi1P2OPnoYs1MTEDRgFg/LyS5G zQniEN2HYeVQF6wbFXKkeUPadp/QGfUEKY5rSd7Sxx8MVbCrJIRDKSMgo4jy4l4f EQ9LA/kBePjJTIN4jaV6NAzpzByBfreTBDXo= Received: from smtpclient.apple (unknown [223.148.153.92]) by zwqz-smtp-mta-g3-4 (Coremail) with SMTP id _____wB3n4ddS1xkRp4sBg--.9829S2; Thu, 11 May 2023 09:56:46 +0800 (CST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Hao Ge Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mediatek/clk-mt8173-apmixedsys: use devm_of_iomap to avoid resource leak in clk_mt8173_apmixed_probe Message-Id: <7F568F0F-1F19-4302-8BBB-556146B3C521@163.com> Date: Thu, 11 May 2023 09:56:35 +0800 Cc: Hao Ge , angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com, mturquette@baylibre.com, wenst@chromium.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org To: Stephen Boyd X-Mailer: iPhone Mail (20E252) X-CM-TRANSID: _____wB3n4ddS1xkRp4sBg--.9829S2 X-Coremail-Antispam: 1Uf129KBjvJXoWrZw4rGw1xCr45Ar1fKr1UGFg_yoW8Jr1kpF ykKFWqkFWkJFy2ka1vva18tay5Aws8ZrZ3Z3Wagr9Ivan8Zry5u34rKFs5XF48trW3Gr4Y qrZ8K3s7KFW7ZaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jI5lbUUUUU= X-Originating-IP: [223.148.153.92] X-CM-SenderInfo: 5jhkt0qwryqiywtou0bp/1tbiNB9sFlaECrAlcAAAss X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =EF=BB=BF > On May 11, 2023, at 09:27, Hao Ge wrote: >=20 > =EF=BB=BFOn Wed, 10 May 2023 14:18:08 -0700 > Stephen Boyd wrote: >=20 >> Quoting Hao Ge (2023-05-08 19:12:14) >>> Use devm_platform_ioremap_resource to take the place of of_iomap for >>> avoid that we don't called iounmap when return some error or remove >>> device. >>> Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock >>> drivers and allow module build") Signed-off-by: Hao Ge >>> --- =20 >> Is this v3? > Hi Stephen >=20 > yes,Perhaps you are too busy,I have not received a response > in the future, so you are unsure about the status of V2. > So I adjusted the code and title make changes smaller and > sent V3 for it.It is precisely because of these that I did=20 > not continue the original mail thread. >=20 > Best regards > Hao Hi Stephen I made a few typos in my previous email. To avoid misunderstandings, I corre= cted them and sent a new one. Yes,Perhaps you are too busy,I have not received a response in the future, s= o I am unsure about the status of V2.So I adjusted the code and title make c= hanges smaller and sent V3 for it.It is precisely because of these that I did not continue the o= riginal mail thread. Best regards Hao=