Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sarthak Garg (QUIC)" <quic_sartgarg@quicinc.com>
To:     Christoph Hellwig <hch@infradead.org>
CC:     "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "Ram Prakash Gupta (QUIC)" <quic_rampraka@quicinc.com>,
        "Bhaskar Valaboju (QUIC)" <quic_bhaskarv@quicinc.com>,
        "Sachin Gupta (QUIC)" <quic_sachgupt@quicinc.com>,
        "Pradeep Pragallapati (QUIC)" <quic_pragalla@quicinc.com>,
        "Sayali Lokhande (QUIC)" <quic_sayalil@quicinc.com>,
        Brian Norris <briannorris@chromium.org>,
        "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: RE: [PATCH V1 1/2] mmc: core: Define new vendor ops to enable
 internal features
Thread-Topic: [PATCH V1 1/2] mmc: core: Define new vendor ops to enable
 internal features
Thread-Index: AQHZZLsSreM1n2UsG0iOAGSJueq9468bFEYAgA9GsjCAAHb4AP//nJxwgADjuYCAJTsTYA==
Date:   Thu, 11 May 2023 05:00:24 +0000
Message-ID: <c1dc3d77db644958b906fa55200a0ae2@quicinc.com>
References: <20230401165723.19762-1-quic_sartgarg@quicinc.com>
 <20230401165723.19762-2-quic_sartgarg@quicinc.com>
 <ZCux+gsR8Nz4Epxw@infradead.org>
 <e492e234b3ec4624ae2f905bdae78785@quicinc.com>
 <ZDjmTi1+WA2BtLct@infradead.org>
 <53eda50111e2402e889bd690a0112ee1@quicinc.com>
 <ZDlR9VB7jRxMsEZH@infradead.org>
In-Reply-To: <ZDlR9VB7jRxMsEZH@infradead.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Thanks for your valuable comments. We didn't ignore the previous comments i=
nstead we tried to address most of the comments by trying the suggested alt=
ernatives as well but didn't see power improvement as compared to this feat=
ure. Moreover we got the intuition that maintainability was the main concer=
n hence we came up with this newer approach of hooks to limit the lines of =
code in core layer. Every change was pushed earlier in the previous posts a=
nd this time we just refactored the code and was about to push the series b=
ut as per current discussion we'll be reviving the old discussion and try t=
o close all the comments. Closing this thread now.

> -----Original Message-----
> From: Christoph Hellwig <hch@infradead.org>
> Sent: Friday, April 14, 2023 6:46 PM
> To: Sarthak Garg (QUIC) <quic_sartgarg@quicinc.com>
> Cc: Christoph Hellwig <hch@infradead.org>; adrian.hunter@intel.com;
> ulf.hansson@linaro.org; linux-mmc@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org; Ram Prakash Gupta
> (QUIC) <quic_rampraka@quicinc.com>; Bhaskar Valaboju (QUIC)
> <quic_bhaskarv@quicinc.com>; Sachin Gupta (QUIC)
> <quic_sachgupt@quicinc.com>; Pradeep Pragallapati (QUIC)
> <quic_pragalla@quicinc.com>; Sayali Lokhande (QUIC)
> <quic_sayalil@quicinc.com>; Brian Norris <briannorris@chromium.org>;
> Wolfram Sang <wsa+renesas@sang-engineering.com>; Linus Walleij
> <linus.walleij@linaro.org>
> Subject: Re: [PATCH V1 1/2] mmc: core: Define new vendor ops to enable
> internal features
>=20
> On Fri, Apr 14, 2023 at 06:52:18AM +0000, Sarthak Garg (QUIC) wrote:
> > Sorry for the confusion by vendor file I meant driver file for Qualcomm=
 SDCC
> controller (sdhci-msm.c).
>=20
> This is still not how we do development.  The two series you've been poin=
ted out
> got valuable feedback that;s been ignored for between one and four years,=
 that
> needs to be followed up with.
>=20
> You're not going to get magic hooks for your driver that you're not shari=
ng with
> us just because you're too lazy to follow up on the review comments.