Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Eiichi Tsukata <eiichi.tsukata@nutanix.com>
To:     paul@paul-moore.com, eparis@redhat.com,
        linux-kernel@vger.kernel.org, audit@vger.kernel.org
Cc:     Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Subject: [PATCH v2 0/5] audit: refactors and fixes for potential deadlocks
Date:   Thu, 11 May 2023 05:21:11 +0000
Message-Id: <20230511052116.19452-1-eiichi.tsukata@nutanix.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W3VsNDQy/QeEf3AY0Vka+C6Asend1OZbAPzSxNO2MWOeeMDhXFZb1JgHG0fK?=
 =?us-ascii?Q?OLdiO3saaqJhG6j5hFz4wQZ2WlF7RvMefZc2v1G0t3c33imyDjsIf10yAnPz?=
 =?us-ascii?Q?0440sx85B/bHTO3ZPSJaEk7/tF1ZMefaXvyCRyqYcHAKBwgxCgrRtXqajhYB?=
 =?us-ascii?Q?NacjkoJ+mE7/ALQfhpBCTBLwEY8QBfOBaSumT7sHN+nnPL2QClcbSPZPncIM?=
 =?us-ascii?Q?pdNhZ0vzGYMZS94nap7uK+2cV0HogyKraq9CaCZ7ECUEtg78rDLKiAKJlUoB?=
 =?us-ascii?Q?ccSdLNai+pFBHG5b3syNBd6CFL8sTyrTJn+qdb7XbzzVnP2CWPdeNTqU3L/c?=
 =?us-ascii?Q?MkORhbYM9Q7mPvbJqjerjnRhuYBxVJkmmCUvOl2NmlKrDUNDTscPWbyJ9sgY?=
 =?us-ascii?Q?HBZhQpooPIrYVUS+hsIaJNvbu0mYDxC35VC4BShyuCTmWOKcl4ZGJ4e4W1ZK?=
 =?us-ascii?Q?rCq8GlEI60/s/soqeeMRwaGmGGgZ3w+VN2P9ityqvQeAJaTIO59PPyM3ElV/?=
 =?us-ascii?Q?qjqcy6xQdq32VKD6lC/LSNQpOEB9XO9amazXRjhpSD172fX4ph+BZM4eamON?=
 =?us-ascii?Q?XtIVnM1mrHzb3UQndThT5y4UPreSAytdA7whhbPQbpnpisP+t4JPbrGz8hfo?=
 =?us-ascii?Q?28xWsBa4EKEDUh0wamJ3lZZ6r3/Idu9nnqMzEqhvWyzMdE0TTtagWNtFfdAf?=
 =?us-ascii?Q?fB6ukRi0weSXBBXsfqgjd6RZ+8IcJDVOoiI6TQtITsHGN0ySqeLZsYlLJkoH?=
 =?us-ascii?Q?R3M98PNE3konsaZXUadF5E9udJzpu7AtuG1Gb2dCdRAV0n8l+KZECJp2ewDU?=
 =?us-ascii?Q?rNK8DrS2hLVg3LvEDcibzzZRV0TIg+1ZxnlQ5ZSfdZ5SeZuKGI1o4g7YudeM?=
 =?us-ascii?Q?evewclsyL8FN8od5KzJcIg5Wbu7PMka0fhyyY1XGb4vk1kbfVhV44Bgya021?=
 =?us-ascii?Q?1yk/yTvmQcdGXvGMn7LYWv3kXR7uqhUUzugzJ3nwmxktrxVPpYR/DbnTqSU8?=
 =?us-ascii?Q?u6plTSONNk7gEPy9qLYXEb8wpP1XXnjiHyKXZIO1cJdtqrt8idKpSIMh/47O?=
 =?us-ascii?Q?4sJMYHEoYU0Fz4ry7C+V/mWcFemQ7TH+pyajOfEyjhy/TGpz1zRc/mzVBC9/?=
 =?us-ascii?Q?nWlalFJY2CWhaURLpNCknSFXyFw7St0QaS3zi2YA1nfTlt1IR+O6PvCWIxE/?=
 =?us-ascii?Q?wkrtp2YOpBU/qF8mXZyW53TYmMGrZUFqvf4nhICQmCCNs9xjymaq/MFKgSFn?=
 =?us-ascii?Q?vnQ34KI3HRuIWy4dCRQ/5bzfGHyY6VnbRchALalspv8xnLHUT/GOKFSdWnAX?=
 =?us-ascii?Q?1vUB7vv/rrsNCR2NY1LQifTLZD/cQF2cIoP3cbfJVR/TzJF6QiVm4hOZpzC/?=
 =?us-ascii?Q?xwR/IttAwkE1C+0sg2JINr1AZa2jQz3xQLCbNasBZH4Tf+rkIL2mBz204zBa?=
 =?us-ascii?Q?TNCMRKaO1I0WOuh3NNpizx80htBbxC5M4Loj+Yw3+LZecYEaHT2ETShyuVmQ?=
 =?us-ascii?Q?+uyRAPH/+u0wzOlQh+nmiheyPuFtNZvoJx5d0cmwa4APsu9WDyX0eYwew09E?=
 =?us-ascii?Q?OchV+xjAPrhBgY3sY6sN5zgWV5wR4n3VnOJYj0IVm1IYliYY3KevTCROSBZu?=
 =?us-ascii?Q?qg=3D=3D?=
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05f6373d-4a9d-42d2-0bc2-08db51df9347
X-MS-Exchange-CrossTenant-AuthSource: CH0PR02MB8041.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 05:21:29.5440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cry6IstuDLQlfIFoNqHyMYWDTKtV+sfn7ILRId3zwd1u/InzkbxAtQKlnK8GsHwmSMYupat7pizciwAydNi0OiL0XioJs1GmVth/8nX2hN0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR02MB10006
X-Proofpoint-GUID: yfYWgw0knsazVdvVszAUWvyw72HWo6oN
X-Proofpoint-ORIG-GUID: yfYWgw0knsazVdvVszAUWvyw72HWo6oN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-10_04,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Reason: safe
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patchset consists of the following refactors and fixes for
potential deadlocks.

  Patch1-3: Refactorings and a small fix preferable for following deadlock fixes
  Patch4: Fix for deadlock caused by wait/wake_up race in @audit_queue full
  Patch5: Fix for deadlock caused by missing wake_up

v1->v2:
  - wait_for_kauditd(): returns 0 if @audit_queue is not full
  - Add another fix for deadlock caused by missing wake_up

Eiichi Tsukata (5):
  audit: refactor queue full checks
  audit: account backlog waiting time in audit_receive()
  audit: convert DECLARE_WAITQUEUE to DEFINE_WAIT
  audit: check if audit_queue is full after prepare_to_wait_exclusive()
  audit: do not use exclusive wait in audit_receive()

 kernel/audit.c | 78 ++++++++++++++++++++++++++++++++------------------
 1 file changed, 50 insertions(+), 28 deletions(-)

-- 
2.40.0