Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 14:49:00 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Shenghao Ding <13916275206@139.com>, devicetree@vger.kernel.org,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        lgirdwood@gmail.com, perex@perex.cz,
        pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com,
        shenghao-ding@ti.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, x1077012@ti.com, peeyush@ti.com,
        navada@ti.com, gentuser@gmail.com, Ryan_Chu@wistron.com,
        Sam_Wu@wistron.com
Subject: Re: [PATCH v2 2/5] ASoC: dt-bindings: Add tas2781 amplifier
Message-ID: <ZFyBzHWo3ORKAskX@finisterre.sirena.org.uk>
References: <20230508054512.719-1-13916275206@139.com>
 <ca9d45cf-8a84-4fbc-e1dd-c96eef36fe25@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="47a7kOxwYBW8LpQL"
Content-Disposition: inline
In-Reply-To: <ca9d45cf-8a84-4fbc-e1dd-c96eef36fe25@linaro.org>
Precedence: bulk


--47a7kOxwYBW8LpQL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 10, 2023 at 09:04:26AM +0200, Krzysztof Kozlowski wrote:
> On 08/05/2023 07:45, Shenghao Ding wrote:

> >  - Submit together with tas2781 codec driver code

> Fix your patchset threading. I don't think it's possible to apply your one.

While it would be nice if things were fixed (if git send-email is being
used then passing all the patches to one git send-email command should
do the trick) it's not an insurmountable obstacle.

> > +  ti,audio-slots:
> > +    description:
> > +      Multiple tas2781s aggregate as one Audio Amp to support
> > +      multiple audio slots
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    maxItems: 4

> You said you can have here two addresses. You don't allow it, test it.

> Missing minItems, but...

> > +    items:
> > +      minimum: 0x38
> > +      maximum: 0x3f

> ... So these are fixed? No need to encode them in such case...

I'm not sure I understand your concern here, there's up to 4 possible
values from 0x38-0x3f which has more than 4 possible values.

--47a7kOxwYBW8LpQL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRcgcsACgkQJNaLcl1U
h9ABwAf/UGnEBEYwgTIBxNSeCc1i8G9It3B7G0r2531DWgIxGpaz5TefmjVPGWKr
YiW7aW0M/S/8RSGc9/BjXurgS8RrsHvXte03SNbCebMUl5USNKPDokSxuuVT4Hdi
hGdU1tcSgMKXG5zAegpQ3odlkRD/Xyy42vVv4xTnG67AZ2/7QgvudVDvNZXvKjky
+vYbi+PHuTQ5hgouUVQ7OiPzs8Thw5AbCRupqr5lxS5wuH02zISQ1rKAVG3kOuJP
ngITS9NSFVwU4kbbD/tMhhKqiqCZ2dYZsjWsojJasD9oTPw04u+dhpQxATVKkmlu
rkJmDSC/kC7stMcaelEucwU66jYVFA==
=Hau5
-----END PGP SIGNATURE-----

--47a7kOxwYBW8LpQL--