Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 14:28:16 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Binbin Wu <binbin.wu@linux.intel.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <seanjc@google.com>, <pbonzini@redhat.com>, <kai.huang@intel.com>,
        <robert.hu@linux.intel.com>
Subject: Re: [PATCH v8 5/6] KVM: x86: Untag address when LAM applicable
Message-ID: <ZFyLAGastgJ5NGrN@chao-email>
References: <20230510060611.12950-1-binbin.wu@linux.intel.com>
 <20230510060611.12950-6-binbin.wu@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230510060611.12950-6-binbin.wu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fOQVcYLVOBRWLiKkJpMkmHUbbVFrrUjTQyphV2yM3eytDmyDMFek8shbhwbk?=
 =?us-ascii?Q?M8ddIGr6rxMW64whXoaaPJBbebZCLNpSSrHubC9arsCptWN+SjSLyzjQjD86?=
 =?us-ascii?Q?58l2QD+fxMMDgM4ZwtLQB0EYazT8KdfprKmOObWroIhRISE4PqLtl1zAxULO?=
 =?us-ascii?Q?a2vpUS9S1tByP55TEYX3h8FM8DJzRrqWGf59B94oz4CthupcbAZYgx+RLN/c?=
 =?us-ascii?Q?Fu36cgJHUhjNmcGAWa+qgKLfLRdZ6Len1s2P27nVBJv5psHn5igTpu5ggx1k?=
 =?us-ascii?Q?2etPbdfJODdd25TBZFzUBNVDoKZHAcmyLbyY7s4qKGacqi/sRP+skvDPFTPU?=
 =?us-ascii?Q?5zflBr7+jaxjIw5yjeZxDkE6t+XSUN8BAEKlvCu/wIhBt9ZcYkl2OTftE0cZ?=
 =?us-ascii?Q?E04I6TKGUEGtn+RC3BPdQ8jVajhHkkYe89ekccdOphjwjY/ZMF8VZdE942Fr?=
 =?us-ascii?Q?RRjFZifzha93X693eO2FAZ2/FGF0vfPtVHElUHSrX7rT1D+q8Bmz5OI6e406?=
 =?us-ascii?Q?Zp+v7qKDVyNsRAi3+cYVrZUh4ZPijGBc1ege8Jnbuwy3IzbZmHg9JzlI1IMf?=
 =?us-ascii?Q?BLGeQZMYXmf/y//mBnxlluNnlXCoSOpaDW44zbbHKyJpQvfhnJnVealwR8sj?=
 =?us-ascii?Q?QWGqtavIr/91REffLjpksEDTwxCx1fd3DWxBrDe+MiRqc5Yk09HaUobjM6bn?=
 =?us-ascii?Q?1LwXrlZQlU2sj+23wszPkxEbtLI3CepyrYAl1E0t4K5ei6QBPkVBiRTSoerT?=
 =?us-ascii?Q?nHVxd5nzbkPyx1P6/dyMkS82mpK5nDbcZXYSzNY0I3Qqqli+C3HBWh6wMlcC?=
 =?us-ascii?Q?AO939HPDhpMyebgakC4pNp5HKleFT0BMCpTsCyilP4jaZGLC10ETMoXE4XH8?=
 =?us-ascii?Q?7psw8S//zFqU1uaxdm7p/+eFh3yPZoH9sli/2Q6RoZDPO3X2xO/qtanJ50xp?=
 =?us-ascii?Q?/jeqfd/v7dTBp8AK8eVGRREmLcYrrPjakNvTpTQnkQAWPn+IMCdNX1vQdv77?=
 =?us-ascii?Q?CKU759LnwOarV48cpo/9FmNcaRddV1KlOkS9NwGC/EhbtZZSLJMyQKWciPnG?=
 =?us-ascii?Q?0qn7XT46WNUzXxocT3oPKJE4QdGUjBI1PNPFlVPQF8sxUsFTtHYRhN3rLpG1?=
 =?us-ascii?Q?B7pbI1PXKXJBQo8VLgN8PsSOTFj9Ee5+t5Easx2sceIR9MgFIO3k7eRO9eu1?=
 =?us-ascii?Q?tPcZqHit2JY1aDvi528O6BXNvQBfFKyOfOrIPOOY46mA3qyKiYigbU92QR9s?=
 =?us-ascii?Q?HydxpJ8iWE3pWGu+1bBoJHxTAk3+lw/vXxyn7MdN6VU8zqpxsSZzLkjXEkmA?=
 =?us-ascii?Q?1UaKJ+Px33oYrIpjrmwZ/0D+sTxIUA1tBOX4Earu/SOnE5WrhsR/dcph2gax?=
 =?us-ascii?Q?9HSkGuY40zVC+6Ew/5gGJ6CppUNKXJhi8zbht918aldfCsPOd5Rd/GBABtfb?=
 =?us-ascii?Q?ryl3EkokaE9ZhdTGZA0R1Hvsz163gXVX4Xwtl2fM2VLJNXN0ZxNmW5LMU9Cc?=
 =?us-ascii?Q?a8pmbbecpXJFNRwbHtA+mtUYXUfRRasy7JESxD7CpRs3vakBhQP0K8jgurcL?=
 =?us-ascii?Q?a0p6ZhjDgDsDYhSOR2H2RD6pex9pp8aFwkeCC09f?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dd0cdd6-9a26-43a9-520a-08db51e8ef39
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 06:28:29.3594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /UQzeEUec7S40t47jtm94hK0sVrcd8lMBnMIxBADTuCH4RHGIeUQ9r5iyFD50tyy6knZ6+cR4qQFPdhfiMxPJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8137
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 10, 2023 at 02:06:10PM +0800, Binbin Wu wrote:
>Untag address for 64-bit memory/MMIO operand in instruction emulations
>and VMExit handlers when LAM is applicable.
>
>For instruction emulation, untag address in __linearize() before
>canonical check. LAM doesn't apply to addresses used for instruction
>fetches or to those that specify the targets of jump and call instructions,
>use X86EMUL_F_SKIPLAM to skip LAM untag.
>
>For VMExit handlers related to 64-bit linear address:
>- Cases need to untag address
>  Operand(s) of VMX instructions and INVPCID.
>  Operand(s) of SGX ENCLS.
>- Cases LAM doesn't apply to
>  Operand of INVLPG.
>  Linear address in INVPCID descriptor (no change needed).
>  Linear address in INVVPID descriptor (it has been confirmed, although it is
>  not called out in LAM spec, no change needed).
>
>Note:
>LAM doesn't apply to the writes to control registers or MSRs.
>LAM masking applies before paging, so the faulting linear address in CR2
>doesn't contain the metadata.
>The guest linear address saved in VMCS doesn't contain metadata.
>
>Co-developed-by: Robert Hoo <robert.hu@linux.intel.com>
>Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
>Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
>Tested-by: Xuelian Guo <xuelian.guo@intel.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>

>--- a/arch/x86/kvm/kvm_emulate.h
>+++ b/arch/x86/kvm/kvm_emulate.h
>@@ -230,6 +230,8 @@ struct x86_emulate_ops {
> 	int (*leave_smm)(struct x86_emulate_ctxt *ctxt);
> 	void (*triple_fault)(struct x86_emulate_ctxt *ctxt);
> 	int (*set_xcr)(struct x86_emulate_ctxt *ctxt, u32 index, u64 xcr);
>+
>+	void (*untag_addr)(struct x86_emulate_ctxt *ctxt, u64 *addr, u32 flags);

Nit: using 'gva_t *' as the second parameter would eliminate the need to
cast to 'u64 *' repeatedly.