Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <11d3a7e2-557f-4f4f-333a-f6cd1b8e6db8@linux.intel.com>
Date:   Thu, 11 May 2023 10:01:02 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH] i2c: fix crash with msgs is NULL points
To:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        wangyouwan <wangyouwan@126.com>
Cc:     andriy.shevchenko@linux.intel.com, jsd@semihalf.com,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230510084057.17313-1-wangyouwan@126.com>
 <20230510090241.GO66750@black.fi.intel.com>
 <1943ca04.6ce1.18804f327f0.Coremail.wangyouwan@126.com>
 <20230510092344.GP66750@black.fi.intel.com>
Content-Language: en-US
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <20230510092344.GP66750@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi

On 5/10/23 12:23, Mika Westerberg wrote:
> 
> On Wed, May 10, 2023 at 05:17:04PM +0800, wangyouwan wrote:
>> After waking up from sleep, 100% of the time it occurred. I suspected
>> that there was a firmware issue with the machine I was debugging, but
>> other machines did not notice it. Therefore, I attempted to make a
>> modification here to avoid it
> 
> Okay then I suggest to investigate what causes the ->msgs to be NULL and
> fix that. When the transfer function is called we expect there to be
> something to be sent out so this should not happen.

Does you kernel include commit 301c8f5c32c8 ("i2c: designware: Fix 
handling of real but unexpected device interrupts")? Vanilla kernels 
after v6.1 have it and also linux-stable v5.15.75 and after.

I'm asking since issue sounds similar and wanted to clarify the kernel 
version you are using.