Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7e58646d7ae4cad32ae30e2e7b54806cc1272d63.camel@physik.fu-berlin.de>
Subject: Re: [PATCH] irqchip/jcore-aic: Fix missing allocation of IRQ
 descriptors
From:   John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To:     Marc Zyngier <maz@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Rich Felker <dalias@libc.org>, linux-kernel@vger.kernel.org
Date:   Thu, 11 May 2023 11:03:01 +0200
In-Reply-To: <86zg6bmezz.wl-maz@kernel.org>
References: <20230510163343.43090-1-glaubitz@physik.fu-berlin.de>
         <479a18513b9d8c6e8ccb96093a0f0dd7@kernel.org>
         <3c76bea5e45a5ae9ea58b3ff87f9971955a3a021.camel@physik.fu-berlin.de>
         <86zg6bmezz.wl-maz@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.1 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-05-11 at 09:47 +0100, Marc Zyngier wrote:
> On Thu, 11 May 2023 08:22:20 +0100,
> John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote:
> > 
> > Hi Jason!
> 
> ???

Sorry, I was confused by this:

> > > [- Jason]
> > > 
> > > It really begs the question: how has it ever been working before?
> > 
> > Users already used a locally patched kernel to work around this problem.
> 
> You're not answering my question. Does it mean JCore never worked
> upstream?

It did still work which is why the previously suggested change was to make a
failing call to irq_alloc_descs() non-fatal. The boards still booted up.

> > > Is there any plan to modernise the port and get it to allocate
> > > irq_descs on demand, as we do on most architectures?
> > 
> > Yes, there are plans to modernize the port. We're first working on
> > upstreaming all kinds of patches that have been queuing up over the
> > time.
> 
> I'd rather you skip that step and focus on making it work as a modern
> architecture. This really looks like ARM circa 2007... :-/

We have a patch-set for switching it to device tree in the pipeline.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913