Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230428060938.98198-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20230428060938.98198-1-yang.lee@linux.alibaba.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Thu, 11 May 2023 11:08:09 +0200
Message-ID: <CAMRc=MdMm4hwSWV4PpzEVeXmAmTSRbLEODj4G_m4rR0rYUVNKA@mail.gmail.com>
Subject: Re: [PATCH -next] gpio: ixp4xx: Use devm_platform_ioremap_resource()
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     linusw@kernel.org, kaloz@openwrt.org, khalasa@piap.pl,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 28, 2023 at 8:09=E2=80=AFAM Yang Li <yang.lee@linux.alibaba.com=
> wrote:
>
> Convert platform_get_resource(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/gpio/gpio-ixp4xx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
> index 56656fb519f8..1e29de1671d4 100644
> --- a/drivers/gpio/gpio-ixp4xx.c
> +++ b/drivers/gpio/gpio-ixp4xx.c
> @@ -199,7 +199,6 @@ static int ixp4xx_gpio_probe(struct platform_device *=
pdev)
>         struct device *dev =3D &pdev->dev;
>         struct device_node *np =3D dev->of_node;
>         struct irq_domain *parent;
> -       struct resource *res;
>         struct ixp4xx_gpio *g;
>         struct gpio_irq_chip *girq;
>         struct device_node *irq_parent;
> @@ -210,8 +209,7 @@ static int ixp4xx_gpio_probe(struct platform_device *=
pdev)
>                 return -ENOMEM;
>         g->dev =3D dev;
>
> -       res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       g->base =3D devm_ioremap_resource(dev, res);
> +       g->base =3D devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(g->base))
>                 return PTR_ERR(g->base);
>
> --
> 2.20.1.7.g153144c
>

Applied, thanks!

Bart