Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <55489ae6-dddc-ca72-07ea-761bf1e40912@linaro.org>
Date:   Thu, 11 May 2023 11:53:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v1 1/3] ASoC: Add ESS ES9218P codec driver
Content-Language: en-US
To:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
        lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230510112349.939991-1-aidanmacdonald.0x0@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230510112349.939991-1-aidanmacdonald.0x0@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/05/2023 13:23, Aidan MacDonald wrote:
> The ES9218P is a 32-bit stereo codec featuring an integrated
> headphone amp with analog volume control and up to 2.0 V rms
> output, and a low-power bypass path for passing through an
> analog signal from an alternate source.
> 
> The digital audio interface supports 16/24/32-bit I2S inputs
> ranging from 8 KHz to 384 KHz, and DSD inputs. This driver
> only supports I2S operation.

...

> +static const struct of_device_id es9218p_of_match[] = {
> +	{ .compatible = "ess,es9218p" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, es9218p_of_match);
> +
> +static const struct i2c_device_id es9218p_i2c_id[] = {
> +	{ "ess-es9218p", 0 },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, es9218p_i2c_id);
> +
> +static struct i2c_driver es9218p_i2c_driver = {
> +	.driver = {
> +		.name = "ess-es9218p",
> +		.of_match_table = of_match_ptr(es9218p_of_match),

Drop of_match_ptr or add __maybe_unused to the table.

Best regards,
Krzysztof