Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 12:10:11 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>,
        Peter Geis <pgwipeout@gmail.com>,
        Frank <Frank.Sae@motor-comm.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 1/3] net: phy: Allow drivers to always call
 into ->suspend()
Message-ID: <ZFy/A9vuxBl7WKt9@corigine.com>
References: <20230509223403.1852603-1-f.fainelli@gmail.com>
 <20230509223403.1852603-2-f.fainelli@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230509223403.1852603-2-f.fainelli@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jCZUfVHQoA9M3lnp9/qlHtW2vkWhvc6K59kcyNF8wO/LYNebmPIIPnvBiqRz?=
 =?us-ascii?Q?O9lmEgmR+dnCb9dZQ8OQg2FCqw9o+EmiAw+xhDVNMoreMiHNNEHTkjwscdSO?=
 =?us-ascii?Q?gcyiPNBbIJ6fkNFw+oFb8r04mgXRY0xJ25k5arkyRFxzOKYgQaqSd0ExWSUZ?=
 =?us-ascii?Q?GBC4iCxcNrqLIatyrStC8fr3I2IByAg5mP9oZhgfmortqzXRg/RXJ0NtzX2R?=
 =?us-ascii?Q?IOs4wF4mpEelPAG08Wm1UMXeMNSz0NaaPYQSpqXBbNGrkNAi0XQlFQvkMhec?=
 =?us-ascii?Q?T8kawX25G4jBIrB6iSmhnOTqsxUR3mXPQq08OA9rT/e/WUSTKmJzmFGcqCNz?=
 =?us-ascii?Q?6+Bo5Nb54fVNv0bnuHLHYjPMMMy9AGECjOV0QJvrLN5rg+BusDn+mTOghtfQ?=
 =?us-ascii?Q?j9Ajk34R5YWKne6xaXuNaJxd2AtcL2cw0hBnQfn3diUUrEebjLgAUTpKUGU6?=
 =?us-ascii?Q?XRHqjemZCwe/ualLEDtZOSE2H/jO9Ip7ORW1N+CI57h8WfnaN1igbQlnH6Fn?=
 =?us-ascii?Q?spjagktSzRyy4YyYQIMWkE8SqxhYGButjq6zlI4FhKC9kGBECmbzu8u7sG9n?=
 =?us-ascii?Q?i7KRaKRiP8SlfzpQ/R5fG/chWOk5M3b6VzpUT5J+7cI012CWDpz2lMle+GHI?=
 =?us-ascii?Q?V7eIsaRPeRiWWb6vEROJ6PMy1j1QeUgmmQh76hnhENBkTj9ilsl5+ZhhbTgN?=
 =?us-ascii?Q?u+7HVAV7o6pIeaNs81s0UGLUEN38+twurBlSOh5nUgLs64QtRi653nVqSMxc?=
 =?us-ascii?Q?pbFRUK88XLuIpqi7xLKqMkvCFFO36/5q61PwjvWyFrWsKWOxyCIym2UgyemA?=
 =?us-ascii?Q?ql7KvlZljHR2OQvYk1n7ZyBjcNRSe+omGTmqkV5qcfpVhWcX9GQtNsvAZv5c?=
 =?us-ascii?Q?/hHPqrYM56+thQQ0j8cEbuW53w7ahsbCqTGt/VZUz43fWeM3XMaQCHYUzU6j?=
 =?us-ascii?Q?GHb5QTP4G3Mr3CTopdUAqccwGmyebmVnKDkU6y+B39RV/Oo3p1bX//wFSKN9?=
 =?us-ascii?Q?efOYEVxs+M5SWaclHlrsWtIMsEXhmn9FMEAHkf3ST4QoiFRZbtfRJybCLeXJ?=
 =?us-ascii?Q?toYT7r+opm8aDSgq810pRDb4yb6IkRm5k/PGst0/hoBatD7smJZfsSaxgjDU?=
 =?us-ascii?Q?RDNddF1Tgad/L9+EL/vbIxa9ADpPy6p803VlTMDaWT5xfhfEd1G0lCcM9F7Y?=
 =?us-ascii?Q?dLMTq29jO+RjxjiifgXVznkv5KnsPDxg2n930rxEfqOW+N5rPEiOEy1dDoJ/?=
 =?us-ascii?Q?C2a/LTuCUAFBOG9LK2sWmeqmgAyTS/95QiO04EJq7/x3YEKDmOvw/Z2eOFCK?=
 =?us-ascii?Q?o8FpMwgex0wYYyfle5Crd3tG+Gdw0i0Hw8cHUVd9H/ia1y52ENq2FF/N3IBV?=
 =?us-ascii?Q?g7YkD3yznJo+66F2yIgXs7f48CDMTxkyBCbd2Af7/jRHwgqD/OZmRX1epaac?=
 =?us-ascii?Q?C2GfJiRqU/Z/mSy7IZqsZ00at4dBjaqYHP3lqiMZ6z2Nk0IcE/GGPmCirrOr?=
 =?us-ascii?Q?MHcRVRRq4n5ync9IjmKeVqzLf8i4F+gE9/TW4+3V71514o1o95dY4wrC4c5+?=
 =?us-ascii?Q?OxE7kP5yH4B9WIYPYlYqEPgfD1xvQRaT7Re2htEzYXZoK8FvrZlUGvOVO/or?=
 =?us-ascii?Q?KKMbAnM/UE8JWpVeWHrgITTENRrUXGttOMHubtk8MD7Xhvj1AVrgWOmXm3Zo?=
 =?us-ascii?Q?IhelWA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aca7599f-8eae-42c2-80f1-08db5207ebfe
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 10:10:18.3162
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UsfJKcvhcH7DI+26MH07FPIaUg1BkiF78b66jEsN5K8NNWj9qeiCrbuT0H5jA9tMuRqZsNyEfpmWMzI0rP7agBcxXyfedBeX2MtSbPvPAwo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3848
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 09, 2023 at 03:34:01PM -0700, Florian Fainelli wrote:
> A few PHY drivers are currently attempting to not suspend the PHY when
> Wake-on-LAN is enabled, however that code is not currently executing at
> all due to an early check in phy_suspend().
> 
> This prevents PHY drivers from making an appropriate decisions and put
> the hardware into a low power state if desired.
> 
> In order to allow the PHY drivers to opt into getting their ->suspend
> routine to be called, add a PHY_ALWAYS_CALL_SUSPEND bit which can be
> set. A boolean that tracks whether the PHY or the attached MAC has
> Wake-on-LAN enabled is also provided for convenience.
> 
> If phydev::wol_enabled then the PHY shall not prevent its own
> Wake-on-LAN detection logic from working and shall not prevent the
> Ethernet MAC from receiving packets for matching.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>