Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 12:39:23 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] driver core: Call pm_runtime_put_sync() only after
 device_remove()
Message-ID: <20230511103923.hvibdyo5ges4bab2@pengutronix.de>
References: <20230511073428.10264-1-u.kleine-koenig@pengutronix.de>
 <CAJZ5v0gNPt=rq+pQtmoGL5nxzDQboOK4d6h7=NoY=LueVhZjAQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7m2fk3b3fmff72si"
Content-Disposition: inline
In-Reply-To: <CAJZ5v0gNPt=rq+pQtmoGL5nxzDQboOK4d6h7=NoY=LueVhZjAQ@mail.gmail.com>
Precedence: bulk


--7m2fk3b3fmff72si
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 11, 2023 at 12:18:09PM +0200, Rafael J. Wysocki wrote:
> On Thu, May 11, 2023 at 9:34=E2=80=AFAM Uwe Kleine-K=C3=B6nig
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > Many drivers that use runtime PM call pm_runtime_get_sync() or one of
> > its variants in their remove callback. So calling pm_runtime_put_sync()
> > directly before calling the remove callback results (under some
> > conditions) in the driver's suspend routine being called just to resume
> > it again afterwards.
> >
> > So delay the pm_runtime_put_sync() call until after device_remove().
> >
> > Confirmed on a stm32mp157a that doing
> >
> >         echo 4400e000.can > /sys/bus/platform/drivers/m_can_platform/un=
bind
> >
> > (starting with a runtime-pm suspended 4400e000.can) results in one call
> > less of m_can_runtime_resume() and m_can_runtime_suspend() each after
> > this change was applied.
> >
> > Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>=20
> I'm not against this change, although I kind of expect it to trigger
> some fallout that will need to be addressed.  So caveat emtor.
>=20
> Anyway
>=20
> Reviewed-by: Rafael J. Wysocki <rafael@kernel.org>

Thanks for your review tag. I wondered if there will be some fallout,
and don't know what to expect yet. Sounds like getting it into next soon
is a good idea?!

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig         =
   |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--7m2fk3b3fmff72si
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmRcxdkACgkQj4D7WH0S
/k7jXAgAqiN5Sx0I4QVbgbmz3wNVPRVsHVwlqohYzZRSi/SoXrO5XouqiedZTlxb
N+rfTwegroja2y5jUYhZ6t/g6G6a76fXzwgYV8Mit/bcspRd7oxAlvgGVOzzi8DC
qUEWRVzDXgTTnZO++4TIxv55SVV0+fYGi87LzObnh/Iq7URXNjlnCpLNgUZGgdoI
fUPjs6NTmEOFVh6BbC60/7ArxaLwJJLjo4gHzfjt+BaCr8GjwtUoxjgmst3kfV4x
v8Cjx6JANS4QLSPv5oZ7HGjzAZLEX5bBnvGwmEvufFPyEt04F6ypOe2k7Df9/0r0
DIZm1vX5Ce1vQEI72CJWBZPRUL0/Mw==
=Sp3J
-----END PGP SIGNATURE-----

--7m2fk3b3fmff72si--