Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230510112349.939991-1-aidanmacdonald.0x0@gmail.com>
 <20230510112349.939991-3-aidanmacdonald.0x0@gmail.com>
 <7b3a37e8-0210-c539-5b5b-bf8e587707ea@linaro.org>
From:   Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] dt-bindings: ASoC: Add ESS ES9218P codec bindings
Date:   Thu, 11 May 2023 11:15:38 +0100
In-reply-to: <7b3a37e8-0210-c539-5b5b-bf8e587707ea@linaro.org>
Message-ID: <7Zga7RBqLNcaG5ylTIY4Qn7CUdE1IJsW@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:

> On 10/05/2023 13:23, Aidan MacDonald wrote:
>> ...
>> +  ess,max-clock-div:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description:
>> +      Sets the maximum MCLK divider for generating the internal CLK.
>> +      CLK must be at least 20x the I2C bus speed or I2C transactions
>> +      will fail. The maximum divider should be chosen to ensure that
>> +      CLK will not fall below the limit.
>> +    enum:
>> +      - 1
>> +      - 2
>> +      - 4
>> +      - 8
>> +    default: 1
>
> Why do you need to customize it per board?
>

There's no generic API to read or change the bus speed (SCL frequency)
for I2C adapters, so it's impossible to calculate a limit on the MCLK
divider automatically.

Defaulting to 1 is always safe, but means wasting power at lower sample
rates. If you know what the bus speed is you can use a higher divider
limit to save power, and it has to be done at the board/firmware level
because that's the only place where the bus speed is known.

>> +
>> +  ess,oscillator-pad-bias:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: Sets the oscillator pad drive bias. 0 - full bias, 15 - disabled.
>> +    minimum: 0
>> +    maximum: 15
>> +    default: 0
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - "#sound-dai-cells"
>> +  - avdd-supply
>> +  - vcca-supply
>> +  - avcc3v3-supply
>> +  - avcc1v8-supply
>> +  - clocks
>> +  - clock-names
>> +  - reset-gpios
>> +
>> +additionalProperties: false
>
> Instead: unevaluatedProperties: false
>
>
>> +
>> +examples:
>
> Best regards,
> Krzysztof

Everything else agreed, I'll send v2 later today.

Regards,
Aidan