Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05057f6d-cb38-8e4a-5d30-82863e0cda44@kernel.org>
Date:   Thu, 11 May 2023 15:16:14 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 1/2] dt-bindings: cdns,usb3: Add clock and reset
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Minda Chen <minda.chen@starfivetech.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Pawel Laszczak <pawell@cadence.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Chen <peter.chen@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
References: <20230510132816.108820-1-minda.chen@starfivetech.com>
 <20230510132816.108820-2-minda.chen@starfivetech.com>
 <9cf5965a-8290-dfff-9f92-07ed2df66650@linaro.org>
From:   Roger Quadros <rogerq@kernel.org>
In-Reply-To: <9cf5965a-8290-dfff-9f92-07ed2df66650@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/05/2023 12:26, Krzysztof Kozlowski wrote:
> On 10/05/2023 15:28, Minda Chen wrote:
>> To support generic clock and reset init in Cadence USBSS
>> controller, add clock and reset dts configuration.
>>
>> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
>> ---
>>  .../devicetree/bindings/usb/cdns,usb3.yaml         | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> index cae46c4982ad..623c6b34dee3 100644
>> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> @@ -42,6 +42,18 @@ properties:
>>        - const: otg
>>        - const: wakeup
>>  
>> +  clocks:
>> +    minItems: 1
>> +    maxItems: 8
>> +    description:
>> +      USB controller clocks.
> 
> You need to list the items. And why is it variable? Your clock choice in
> the example is poor, I doubt it is real.
> 
>> +
>> +  resets:
>> +    minItems: 1
>> +    maxItems: 8
>> +    description:
>> +      USB controller generic resets.
> 
> Here as well.
> 
> You had one clock last time, thus the review was - drop the names. Now
> you changed it to 8 clocks... I don't understand.
> 

Different platforms may have different number of clocks/resets or none.
So I don't think minItems/maxItems should be specified.

-- 
cheers,
-roger