Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 14:13:40 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Daniel Golle <daniel@makrotopia.org>
Cc:     netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Qingfang Deng <dqfext@gmail.com>,
        SkyLake Huang <SkyLake.Huang@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH net-next v3] net: phy: add driver for MediaTek SoC
 built-in GE PHYs
Message-ID: <ZFzb9Fnc3mJAQal9@corigine.com>
References: <ZFwVwlN0eHjo_xB4@pidgin.makrotopia.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZFwVwlN0eHjo_xB4@pidgin.makrotopia.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IKHxoiGSaDV36chD1wbSuHEtXfOciGQxCrGLFsdXi3zD3RNi0qUBTir7KI50?=
 =?us-ascii?Q?AdEnkqRM6Forfyc5I1lKkSFQvUqXB6FNaHdMzAnom3TDHTaUqOiqAnhAWZRC?=
 =?us-ascii?Q?Ss+IwnwMrDJEswlkGy5jimSOru9HAyr23cQP0PPGuYaNpcg/Xx7KzPaGIota?=
 =?us-ascii?Q?4FekkTAwEGZzhw4XhqnoI0Eum90XIQY/TYqZCEsppVlBQXjuyUeh/XkjI9pN?=
 =?us-ascii?Q?L0lqYvO65S8fe7ta2DK8Hv1WxiWLKiv1axVRtp5jbItDGfNQseeciOAzbIZf?=
 =?us-ascii?Q?ORi2TNHySUmOAYlOX8eyBDYOSQfdY+0pCtfE8mCjEYH6pf87O7mQ6Lw1lQRo?=
 =?us-ascii?Q?KDvuDU4/n6S4RukoEvUpsIo11bt1YcMiss2pB64V6TA33DchmX3oHk1Y/7Ee?=
 =?us-ascii?Q?3qaWd7xjLvS/7z/0bBXP9hs6dGhgffeyZO0R7jiMHqxKcrlRXMPLob7Dhl4o?=
 =?us-ascii?Q?pZqCxx7wpog1t6PsAMl3Jja4SNFGKrT8ktjgdRribSu2hn7HLxarkmjnVwIs?=
 =?us-ascii?Q?4j/1bcj7u2wjHXBvWoohIYpXt6wwaIyCZV222RY6oQTobj3BaY+b0eE92LpW?=
 =?us-ascii?Q?Veqac7I6DmwFlJSTOP56/DWaFGyTl8AaipG89BZwBs3JGJpbPR3YhQWT7RL7?=
 =?us-ascii?Q?eoZjDtaPuXpasHUE6HGswDhdIMnMIOnrbnNuZ1LuquPXsuQy3/qCgeb+ipI8?=
 =?us-ascii?Q?i4UEDe8ffYmktcNDJ17d37ert/xZ+hijDDJrXr8gqzfkEbEpcEXDMQWmoM8K?=
 =?us-ascii?Q?ByLkb94JdXG6dOD30+Vrz3NY1FUVf2TD+oSQau2vnaeGrblnYa5JNSfS68ZI?=
 =?us-ascii?Q?D6MPIvQWZkCoja9SYh10NtKVbXdQTdcLVWG2eCqF5Ppyqvys86NhMdxWYZxL?=
 =?us-ascii?Q?bMr7WaTt3Yy4a+jPHGuE6Y7zGUbT1a88Ufr8omJh73gQ9F5T7/70QD5VDKb5?=
 =?us-ascii?Q?IGql7ZsMEDfSA7OF04Wrokk1YTWr9ht12HB+jR0DfEhIlZpInQvXe/qILzf0?=
 =?us-ascii?Q?N6dD6ODafLEjyawmRhOkWi7+NfDJICb1TgwZmQHNGJX3X6Z9vomqriEHjyrg?=
 =?us-ascii?Q?8VrboY6WP8BhilJlGoMDzDB9qf1szY3VhX/BorWK250kVm9mGMVrtcvWNnhN?=
 =?us-ascii?Q?Jgf33qDr5c/QNNJeUJJalO+GFe8/p0ZvuhRZED4ls6+m1q++YW9gdK1akezA?=
 =?us-ascii?Q?Gszkp3vejDaWBQ9P65eyxxeAjlg0z+8fOMa0jDfAP7WdWveh3tO5NB1Xfodv?=
 =?us-ascii?Q?UPW6oQkM2IBml01/BGBLm9TIRVFcLfvc/GnjU7rcqHS+bK2PYSWN/u7KQ5Fd?=
 =?us-ascii?Q?5rN/yd+NE1vXrSyyHjaK3jqjLT6J4rp2nJMJX6G2rxKD6Q+H54kANJCm5nGT?=
 =?us-ascii?Q?fIKpI8FVz9+RzoDGQVu/tGxDN3wcftOymOJiTZR175kHBke+wsFCx1Kiq826?=
 =?us-ascii?Q?t6hc5jRtp5vZMBITAKHZvDk/KLsniLBukYYbDF646r3SAYIJ86cPUKoxyo+2?=
 =?us-ascii?Q?ih4gN/uXa5q/MAfV9oOEO9wSZe4GEJB4J8PNjA5fZMJcDbewMzcpXARstqgM?=
 =?us-ascii?Q?jbg3Eowqr4lwA8CEBPUJrFBfRjiYElvKUAWlSfGaBcyLQVDdUokzfu8uOxA3?=
 =?us-ascii?Q?cpWbnEGbUpPDUqz7Q5ZuHpYtPQFB82J7/uwNIfb9lLc+UaiKTakgi1Qc2GCb?=
 =?us-ascii?Q?cVMLBA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f467e58-d4a6-4c1a-7d1a-08db52192c37
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 12:13:47.4910
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ah1p6q+vHjaItZyavnU2GDvr2GpCFcON7FgWlqdqCe6Wo+svmyMyM4V/QsmvyaatiwELzjJ4nHNRyQdtyVXX6qUEfc91ej1zS0oNXDNcgQU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR13MB6245
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 11, 2023 at 12:08:02AM +0200, Daniel Golle wrote:
> Some of MediaTek's Filogic SoCs come with built-in gigabit Ethernet
> PHYs which require calibration data from the SoC's efuse.
> Despite the similar design the driver doesn't share any code with the
> existing mediatek-ge.c, so add support for these PHYs by introducing a
> new driver for only MediaTek's ARM64 SoCs.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

Hi Daniel,

some minor nits from my side.

...

> diff --git a/drivers/net/phy/mediatek-ge-soc.c b/drivers/net/phy/mediatek-ge-soc.c

...

> +#define MTK_PHY_RG_BG_RASEL			0x115
> +#define   MTK_PHY_RG_BG_RASEL_MASK		GENMASK(2, 0)
> +
> +/* These macro privides efuse parsing for internal phy. */

nit: s/privides/provides/

     Please consider using checkpatch --codespell

...

> +static int tx_amp_fill_result(struct phy_device *phydev, u16 *buf)
> +{
> +	int i;
> +	int bias[16] = {};
> +	const int vals_9461[16] = { 7, 1, 4, 7,
> +				    7, 1, 4, 7,
> +				    7, 1, 4, 7,
> +				    7, 1, 4, 7 };
> +	const int vals_9481[16] = { 10, 6, 6, 10,
> +				    10, 6, 6, 10,
> +				    10, 6, 6, 10,
> +				    10, 6, 6, 10 };

nits: Please put a blank line here.
      Please arrange local variables in networking code in reverse xmas
      tree order.

Link: https://github.com/ecree-solarflare/xmastree

> +	switch (phydev->drv->phy_id) {
> +	case MTK_GPHY_ID_MT7981:
> +		/* We add some calibration to efuse values
> +		 * due to board level influence.
> +		 * GBE: +7, TBT: +1, HBT: +4, TST: +7
> +		 */
> +		memcpy(bias, (const void *)vals_9461, sizeof(bias));
> +		break;
> +	case MTK_GPHY_ID_MT7988:
> +		memcpy(bias, (const void *)vals_9481, sizeof(bias));
> +		break;
> +	}

...