Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 15:02:40 +0200
From:   Simon Horman <horms@kernel.org>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
Cc:     Shenwei Wang <shenwei.wang@nxp.com>, Wei Fang <wei.fang@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Alexander Lobakin <alexandr.lobakin@intel.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        imx@lists.linux.dev
Subject: Re: [PATCH v2 net 1/1] net: fec: using the standard return codes
 when xdp xmit errors
Message-ID: <ZFzncPmqH1C5HAyf@kernel.org>
References: <20230510200523.1352951-1-shenwei.wang@nxp.com>
 <20230511072452.umskoyoscsxgmcoo@soft-dev3-1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230511072452.umskoyoscsxgmcoo@soft-dev3-1>
Precedence: bulk

On Thu, May 11, 2023 at 09:24:52AM +0200, Horatiu Vultur wrote:
> The 05/10/2023 15:05, Shenwei Wang wrote:
> > 
> > This patch standardizes the inconsistent return values for unsuccessful
> > XDP transmits by using standardized error codes (-EBUSY or -ENOMEM).
> 
> Shouldn't this patch target net-next instead of net? As Simon suggested
> here [1], or maybe is just me who misunderstood that part.
> Also it is nice to CC people who comment at your previous patches in all
> the next versions.
> 
> Just a small thing, if there is only 1 patch in the series, you don't
> need to add 1/1 in the subject.
> 
> [1] https://lore.kernel.org/netdev/20230509193845.1090040-1-shenwei.wang@nxp.com/T/#m4b6b21c75512391496294fc78db2fbdf687f1381
> 
> > 
> > Fixes: 26312c685ae0 ("net: fec: correct the counting of XDP sent frames")

Hi Shenwei,

I agree with Horatiu.

Also, this is not a fix. So it should not have a Fixes tag.

After waiting for further review please send a v3 with these updates.

pw-bot: cr