Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c40fdde7-52d6-c50f-03f4-58584f11ba4d@amd.com>
Date:   Thu, 11 May 2023 15:25:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [RFC PATCH V5 11/15] x86/sev: Add a #HV exception handler
Content-Language: en-US
From:   "Gupta, Pankaj" <pankaj.gupta@amd.com>
To:     Tianyu Lan <ltykernel@gmail.com>, luto@kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        seanjc@google.com, pbonzini@redhat.com, jgross@suse.com,
        tiala@microsoft.com, kirill@shutemov.name,
        jiangshan.ljs@antgroup.com, peterz@infradead.org,
        ashish.kalra@amd.com, srutherford@google.com,
        akpm@linux-foundation.org, anshuman.khandual@arm.com,
        pawan.kumar.gupta@linux.intel.com, adrian.hunter@intel.com,
        daniel.sneddon@linux.intel.com, alexander.shishkin@linux.intel.com,
        sandipan.das@amd.com, ray.huang@amd.com, brijesh.singh@amd.com,
        michael.roth@amd.com, thomas.lendacky@amd.com,
        venu.busireddy@oracle.com, sterritt@google.com,
        tony.luck@intel.com, samitolvanen@google.com, fenghua.yu@intel.com
Cc:     pangupta@amd.com, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, linux-hyperv@vger.kernel.org,
        linux-arch@vger.kernel.org
References: <20230501085726.544209-1-ltykernel@gmail.com>
 <20230501085726.544209-12-ltykernel@gmail.com>
 <3ec60d7a-c5e7-2570-a0f2-ef435d904cfd@amd.com>
In-Reply-To: <3ec60d7a-c5e7-2570-a0f2-ef435d904cfd@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2FmRitLd2RVNm04aVFHMWdRZ3AxQlhwQlBWbmFwZFZXYno0SkkwNmdQWmZu?=
 =?utf-8?B?dlkwZ1NZajFIbXBoNDJXOUtmTUliMmdRZnpBYXZzQk1PODF2cHAxTFliT3Fn?=
 =?utf-8?B?c1pyOWVCcCtIeHl3ZmYzSTFibkp6bFFWU0Z4WEtBZ2YxeVJ1UGRDVy9zM3dM?=
 =?utf-8?B?MlRyeURIR2ovL0JPRDJyMkhmcTMzeTJCNWYwVmlPQ0RqWlZKZ1VybVNGQ1l2?=
 =?utf-8?B?dU9uRTMxeVU5a3JmMmxIc1VyUFp4Z28yUTJDTDVkZFNJR0tBRjVxTTZuV1Fv?=
 =?utf-8?B?SFJUbmkxRkdGeGcvUnZpZ3VHeHpKb3pPYzc0R0psMGdRQkZDWGdUL3pxS0Fx?=
 =?utf-8?B?bFV4Q1QrRnFiSytzRjVseWZUbVAzdHNNUTdKQS8vdCtOSkpwTWx0dFYyeDNB?=
 =?utf-8?B?TUplZnBzaUlJZ0VBV3RMQVJkOXkxOFp6dFhPMXR4ay9DTFQreTJmdmFXai9V?=
 =?utf-8?B?RnpBbzNjdElIQ0hjbkhOOWkwMmViNVJoNHVjVURRVXEwbGRwQ1Fqa0ttZnZH?=
 =?utf-8?B?TU93bWo1M3ZQT0ZsNFdGKzRJNDNxWlZFclRRWmQyUnBWSjl0dEpScTJ5Nnht?=
 =?utf-8?B?NkZUM1RLUmRHMXRzcTBvNGF2M1RCM3lxMHByREFqZ3RwNFRZdHJqWVNDSnR4?=
 =?utf-8?B?VUNRR2hhblRZTytZVGJmcklkSU44RWcydHY3Rlo3bE9iSHV6S2NLN3B6UnY2?=
 =?utf-8?B?Qlh4SDlKWVp1N0M4b01VdkdXL2tabWhkZUNvY3E5WHR4RXJmN0hOeDgzYnZi?=
 =?utf-8?B?dTZkSGJuUklpZXVlbnU2MlBDTkVJMWh0RUc1QXZLaE5PR3RrZW1KRFRRVytR?=
 =?utf-8?B?WEFwb2lIWjRETXE3dzhEcERNN0FVSUZQL0tTVDZJWlVFQzM1L3RIMnJBaDFz?=
 =?utf-8?B?ZEFKT3pjU0FOaytCRWdlc3EwNXlaNHpYRVVFR1F6bWlyUG5FL2JZMkJlWVpY?=
 =?utf-8?B?Q2lqV1lIQXZpc1BjenFDUlNqajV0Rkg5K0VvVk5oakI5Qmt4alJXbDdqWWZi?=
 =?utf-8?B?L2VPZnRNd3pnRUVDY0VGTmNGN29pWGJ0QU5OM0ZTNGVGeUFiK3BINW5TUHUv?=
 =?utf-8?B?K1h5MFlNM1NCbi8zLzVvNzdBaVZIVmZteFYyYW4xTEdkb1B6ME5FZWptb055?=
 =?utf-8?B?eVFrcU1VbDJmVXA4aG5ROWpvVjgyaEZpb3A3RU1rakJCM1dMWVNLOWhNY3l1?=
 =?utf-8?B?am54Ni80ZldxaEI3aVljMVdWcjRCanhzdXdMcFpNQjRsOEN6cHE3aFA5eG9I?=
 =?utf-8?B?OVZpZmorR0tDb1pKek9oYkhmdXpDejdnSGJzOGN1bHM5SXRYaUc2VGhRUkg3?=
 =?utf-8?B?aDFFRkVpSkIzL3VsZWMwTnVhRmpyeUlITTh2ZE51dU81bnViSjAwcis1WDVv?=
 =?utf-8?B?ZHFtMEpkVmpoYXdNV3pjdm9PM0dpYWg3V25yaVB5MGg0dEZSUFpnakNadUsz?=
 =?utf-8?B?bzhkWGpxV1U3NXRsTkx5bTN0NExVWGMrZFp0a0lCMWlpWVhReTU4VVlMTW1V?=
 =?utf-8?B?aFJ2SEp2RXE4SktDVVNnbS9wT2FoV0xiZHNDS1dQOEJTb0E4cnZMUU1wNExi?=
 =?utf-8?B?ZHVvd3BmRnpyWFo3ZCtHYXpvNGhybm56Smo0bVU5ZnlsZ2VIR2xDcW9iNjVX?=
 =?utf-8?B?aEo2d2VKb0FhVVZlQlZVVHpTY3pwRHNrem5rc2crNXpiL2NxNlhjVVVnZERL?=
 =?utf-8?B?TGJGMjNYWGlnQ1NzV0toWmVlclhXNGhkbUx5Ny9Fd3FFWlFvU0xZck1JSTdp?=
 =?utf-8?B?ZHFodm5reXVqeGpWbDNpY3JaOEJmNTBBaWFPYUd6d0d1WGZtVUFjblBoSmZo?=
 =?utf-8?B?bmJkOHVBK0JKRkNGcVZhUEZ2bkU2bXlYOWNhQVZtWGdmMGFtSlRtSjJDTVFU?=
 =?utf-8?B?NVEzRDB5STAwY1dHaENCbHU3cHZwcWpJM0RVSWk4YjZPdUM2MGNJYkZ5RWxH?=
 =?utf-8?B?ZjNuV3dQU3k1N0gydVNUVWZNMTFWamtrWTlyTTg1YTVERzl2TkEzdmwvR1Fs?=
 =?utf-8?B?TDVrZmdNeGNWRm5FSk5EZWJwd1JWb2dGckd6Ym1nRVdnc0s4VGh0OWRPYVJQ?=
 =?utf-8?B?UWl2OGtVN1hCdDkvclByc3pVMlB0SnVYSzRaUG1SU3JTZklzb2VOLzNsbTl1?=
 =?utf-8?Q?IHw868iyiVIkXf55zTKGOJ5Np?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3233ecf1-3b14-4fe5-4244-08db52235b6d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 13:26:41.8046
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: llq9EMqs8TIFIu/JiS9CkVpR5u1Gx6CRAHBb/EH/+/A+pLUQ2RKtej6w+lrkv9nDSgwuBF/jrN6O34U/ZyWYdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8086
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/5/2023 12:59 PM, Gupta, Pankaj wrote:
> Hi Tianyu,
> 
> I tried to understand some details of this patch. Please find below
> some comments/questions.
> 
> Thanks,
> 
> 
>> Add a #HV exception handler that uses IST stack.
>>
>> Signed-off-by: Tianyu Lan <tiala@microsoft.com>
>> ---
>> Change since RFC V2:
>>         * Remove unnecessary line in the change log.
>> ---
>>   arch/x86/entry/entry_64.S             | 22 +++++++----
>>   arch/x86/include/asm/cpu_entry_area.h |  6 +++
>>   arch/x86/include/asm/idtentry.h       | 40 +++++++++++++++++++-
>>   arch/x86/include/asm/page_64_types.h  |  1 +
>>   arch/x86/include/asm/trapnr.h         |  1 +
>>   arch/x86/include/asm/traps.h          |  1 +
>>   arch/x86/kernel/cpu/common.c          |  1 +
>>   arch/x86/kernel/dumpstack_64.c        |  9 ++++-
>>   arch/x86/kernel/idt.c                 |  1 +
>>   arch/x86/kernel/sev.c                 | 53 +++++++++++++++++++++++++++
>>   arch/x86/kernel/traps.c               | 40 ++++++++++++++++++++
>>   arch/x86/mm/cpu_entry_area.c          |  2 +
>>   12 files changed, 165 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
>> index eccc3431e515..653b1f10699b 100644
>> --- a/arch/x86/entry/entry_64.S
>> +++ b/arch/x86/entry/entry_64.S
>> @@ -496,7 +496,7 @@ SYM_CODE_END(\asmsym)
>>   #ifdef CONFIG_AMD_MEM_ENCRYPT
>>   /**
>> - * idtentry_vc - Macro to generate entry stub for #VC
>> + * idtentry_sev - Macro to generate entry stub for #VC
>>    * @vector:        Vector number
>>    * @asmsym:        ASM symbol for the entry point
>>    * @cfunc:        C function to be called
>> @@ -515,14 +515,18 @@ SYM_CODE_END(\asmsym)
>>    *
>>    * The macro is only used for one vector, but it is planned to be 
>> extended in
>>    * the future for the #HV exception.
>> - */
>> -.macro idtentry_vc vector asmsym cfunc
>> +*/
>> +.macro idtentry_sev vector asmsym cfunc has_error_code:req
>>   SYM_CODE_START(\asmsym)
>>       UNWIND_HINT_IRET_REGS
>>       ENDBR
>>       ASM_CLAC
>>       cld
>> +    .if \vector == X86_TRAP_HV
>> +        pushq    $-1            /* ORIG_RAX: no syscall */
>> +    .endif
>> +
>>       /*
>>        * If the entry is from userspace, switch stacks and treat it as
>>        * a normal entry.
>> @@ -545,7 +549,12 @@ SYM_CODE_START(\asmsym)
>>        * stack.
>>        */
>>       movq    %rsp, %rdi        /* pt_regs pointer */
>> -    call    vc_switch_off_ist
>> +    .if \vector == X86_TRAP_VC
>> +        call    vc_switch_off_ist
> 
> I think the stack switching logic is similar for #VC & #HV.
> So, we can use common function. Just the corresponding fallback
> stack switching is different. Maybe we can pass the hint as an
> argument (%rsi?) to something like "sev_switch_off_ist()", and use
> the corresponding (#HV or #VC) fallbacks stack?

Also, Please include the below patch from Ashish for #HV
reentrancy check.

https://github.com/ashkalra/linux/commit/6975484094b7cb8d703c45066780dd85043cd040

Thanks,
Pankaj