Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp8854874rwr; Thu, 11 May 2023 07:05:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5txvsl2lTlyziPhUziM0iSTpq/WW//JHjyz8JXxQhLdFVaH2O+X3EhbccCEFLVyFa0uyTn X-Received: by 2002:a25:1f05:0:b0:b9a:affd:64d3 with SMTP id f5-20020a251f05000000b00b9aaffd64d3mr22417664ybf.15.1683813943020; Thu, 11 May 2023 07:05:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683813943; cv=none; d=google.com; s=arc-20160816; b=0q0zPKt0yxwVPOaSrAivTwqyvs7yT4mrRQP2XN8kWBNOftGr6DNXm+UPgJt9OM8tc8 m6Y0aTtm6xpvXIVWkd2j+BI3hh5evGb6vgxXl8iurgJ7UNMg91fS5hXULaUvmTeNUQPZ RkoqocMxw5PcHLdDE49cLam/18UjYJ0sCFl3+nJBBhkjfgR7Ma4eI/i2gU0WBgzvnnRT em25stWLN+KcgyF+d3WU+bXhwomyPUuKRbZSa4EJIVpSsF/uLy84P+0B7FTVYtgLQ7iY 51Zq5TEXDj+gW86Py21aubhTZw8tGFyJf/BqAYivtUmu1Nd2Z4ky26bAusD0ohRbWpp5 Msgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=RbRyh5JxCzRNKwywrJitBFStmeMc03vJfDZhpriQN1M=; b=Y8EG4OPW9Ccd1wPwRoqHLUCfiALbmnekBsE0OklAPPGH9fH6wAZ9huLq4JfB/Kl+Pk 5rlledEK5+KC9UGFOxDEEBDQVWy61UZwVj2t43/v+iVfONZd8kEw9/1muJa7ju1w/QLw VoFmgAVYt05SK21XCbsa1uvVDtO45UgsWiStv+1y6keVxsqYEYD+wIC1AVhJLqMqJkSu novh+4AdVHhvXk/eNy0kbVh9pv1Re9IhvsdrM3yggCFRVQhekWMP2Hp3TrSiUvZFg90C UEXAcvyP3KZVIaDJmbK9d88TThckHCOdmuVaPFA72gT/6xBSmcHfabMffjZOWO7XEhjc H72w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cr1qQlAs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g203-20020a2552d4000000b00ba27ddb2eadsi9681127ybb.400.2023.05.11.07.05.25; Thu, 11 May 2023 07:05:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cr1qQlAs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238172AbjEKNwi (ORCPT + 99 others); Thu, 11 May 2023 09:52:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238040AbjEKNwf (ORCPT ); Thu, 11 May 2023 09:52:35 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D6283A89; Thu, 11 May 2023 06:52:34 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34BDUUJS000533; Thu, 11 May 2023 13:52:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=RbRyh5JxCzRNKwywrJitBFStmeMc03vJfDZhpriQN1M=; b=cr1qQlAs0Rq2b4wcmbJLi2HiKlajTYyjBBOF/HwRrWO/NyhguG7Txy/fACyEK7P2qRg4 ObQVJmr7kMs9DzXvvAF0FF3dv+Nq4nRpBKkwbStORra3nNfpzZ94SbxTvRYdVAJSC7YZ 7czl5YMalBMw/bw0gHAvhBe3eV+pXGT12OUmYhrbjKwO5+xuLshdl3Kdh5XkWsZzwML5 uNF8uhKgt41QPPUvz96TyclRefQenfkDxQtbvxC33ukDUr7XFkLuv/PIqKK5bigfvOva evgY76f6VDXAXPgGlwNjxe92/HGA+xcYHX8MVqbVzrDGrNiTYt5a2rZWQPGSNggG/PJd Xw== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qgv1u8vgs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 May 2023 13:52:28 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34BDqRh1027265 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 May 2023 13:52:27 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 11 May 2023 06:52:26 -0700 Message-ID: <73f6b38d-b968-ccad-c00f-86afa883a07d@quicinc.com> Date: Thu, 11 May 2023 07:52:25 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2] bus: mhi: host: Skip MHI reset if device is in RDDM Content-Language: en-US To: Qiang Yu , CC: , , , , References: <1683772404-13192-1-git-send-email-quic_qianyu@quicinc.com> From: Jeffrey Hugo In-Reply-To: <1683772404-13192-1-git-send-email-quic_qianyu@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: bvoZugI4VqJIpH50vtlBfniE9K-RWs0K X-Proofpoint-ORIG-GUID: bvoZugI4VqJIpH50vtlBfniE9K-RWs0K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-11_11,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 phishscore=0 mlxlogscore=948 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305110119 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/2023 8:33 PM, Qiang Yu wrote: > In RDDM EE, device can not process MHI reset issued by host. In case of MHI > power off, host is issuing MHI reset and polls for it to get cleared until > it times out. Since this timeout can not be avoided in case of RDDM, skip > the MHI reset in this scenarios. > > Fixes: a0f5a630668c ("bus: mhi: Move host MHI code to "host" directory") This doesn't seem like the correct fixes tag. That commit looks like it just moves code around, but does not add code. What is the commit that added the relevant code? That commit probably predates the move. > Signed-off-by: Qiang Yu > ---