Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp8885748rwr;
        Thu, 11 May 2023 07:24:41 -0700 (PDT)
X-Google-Smtp-Source: ACHHUZ4E5VIttcbTuzNxri2dM3SP2fuDxaq8MewXJxK4nnqihGXjWu/FDIfA6f7+qsQySgkoEg7M
X-Received: by 2002:a17:903:185:b0:1aa:db0f:1aba with SMTP id z5-20020a170903018500b001aadb0f1abamr26474936plg.47.1683815080676;
        Thu, 11 May 2023 07:24:40 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1683815080; cv=none;
        d=google.com; s=arc-20160816;
        b=qKEvfFOqkheirurJThQPcPjfisyanWQmkLI86Gylsxrxksl7tWZmURSfMuQ+/gamyR
         fD6cVY4YHXaxSLlBt+A49nQGHP843djctQ37TBxGdMxYegX612BkqARqdIs8iSbxEMa5
         8xnbwPzPozcj51Ce5jnoC4hWXuboXjXqlSeR7W5M/XutUrp8+vs3KeTgFRa4y/RM1u2q
         ruvjlPulIbuRuXOC1+kEtb5Cdn/vkVmnB/FX+/Ku9HyLBV5PLhyaDw4RKBG7/7MIrH0f
         70bZNjSb194SHxGFPpvaO+ET/qlhl8FMY8rTVaRsHNYgSb/3lhEm9h/1hGbnU2o5MNZP
         v//A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=9xKlrKhFYqLyQTlWQo4MBtluka9IvgO2ZSWgQPkAczs=;
        b=UdqFabgmRwGPTTB/zKOEB8aZlxwWi8JZRoFxY3Y31aOCJ5RuFDQbojNLk08TiVARr+
         8LtdOuqeTnEOlr3R7b3shuST1ke7ZJx7y4tCakM8RvL7Vz3rYsqLbzRWXT3FO3+sKsTD
         uPxAjOsSLhfdUQHwx1dTQspNi5AXioY3dHpI6Kj9UWJfv8MoK29W0lMlofFu/z5k5G2Z
         U2nMa533Y41NLDgP84ZvnNCEh+zSVKQRTu1NRrtzhawuzugWPqKzSBr7Md59aBRrfqgC
         nxU3t6qyGGdfgkx/iaH33Bv1iLA5kITSulzCXjbT/hTxgW91wZj5xBh62gLRuH9laQ1U
         hPiA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=FPoI5diA;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id w10-20020a170902904a00b001a63a7b7025si6631322plz.30.2023.05.11.07.24.26;
        Thu, 11 May 2023 07:24:40 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=FPoI5diA;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S237978AbjEKOQa (ORCPT <rfc822;recursive.nomad@gmail.com>
        + 99 others); Thu, 11 May 2023 10:16:30 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33546 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S238499AbjEKOQU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 May 2023 10:16:20 -0400
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD311BE;
        Thu, 11 May 2023 07:16:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=9xKlrKhFYqLyQTlWQo4MBtluka9IvgO2ZSWgQPkAczs=; b=FPoI5diA/0zZy8JMmK+sAC9n+G
        C6uTsBO8yEpp/fYSDyMQrvRMplR23ccV6M495JzZwzexuX36dvw5iWI29VG52MbK7ysvIA4z6uakM
        NeuY7gGAdkIaQ5Hu+6X4sfqYYtS36zuxGxbGcueP24TrcDXp6jPnBmyLcrsqe8AZ0dus=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1px75P-00CZ0N-89; Thu, 11 May 2023 16:16:03 +0200
Date:   Thu, 11 May 2023 16:16:03 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Harini Katakam <harini.katakam@amd.com>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        kuba@kernel.org, edumazet@google.com, pabeni@redhat.com,
        vladimir.oltean@nxp.com, wsa+renesas@sang-engineering.com,
        simon.horman@corigine.com, mkl@pengutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        harinikatakamlinux@gmail.com, michal.simek@amd.com,
        radhey.shyam.pandey@amd.com
Subject: Re: [PATCH net-next v3 3/3] phy: mscc: Add support for VSC8531_02
Message-ID: <3a8e10f6-ea98-4c6d-b89e-06d659365acb@lunn.ch>
References: <20230511120808.28646-1-harini.katakam@amd.com>
 <20230511120808.28646-4-harini.katakam@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230511120808.28646-4-harini.katakam@amd.com>
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 11, 2023 at 05:38:08PM +0530, Harini Katakam wrote:
> Add support for VSC8531_02 (Rev 2) device. Use exact PHY ID match.

Please add a comment:

Rev 2 requires its own entry so that...

Just to make it clear why the existing PHY_ID_VSC853/0xfffffff0 is not
sufficient.

	Andrew