Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 07:40:23 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Georgi Valkov <gvalkov@abv.bg>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Foster Snowhill <forst@pen.gy>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: net: usb: ipheth: add CDC NCM support
Message-ID: <20230511074023.5217e972@kernel.org>
In-Reply-To: <0A1C2108-75F2-46B7-8712-616FE6464294@abv.bg>
References: <0A1C2108-75F2-46B7-8712-616FE6464294@abv.bg>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 11 May 2023 12:47:56 +0300 Georgi Valkov wrote:
> Can you please review, and accept the following patch. I=E2=80=99ve been =
using it for one year.
> I added the author Foster Snowhill to this mail, as well as a link to his=
 Github [1].
> If needed, we can ask him to add the tag Signed-off-by:
>=20
>=20
> From 257d843a7f90e4e519635f82fe5b73fba918ec33 Mon Sep 17 00:00:00 2001
> From: Foster Snowhill <Forst@users.noreply.github.com>
> Date: Fri, 22 Apr 2022 23:50:09 +0200
> Subject: [PATCH] net: usb: ipheth: add CDC NCM support (PoC)
>=20
> Recent iOS releases support CDC NCM encapsulation on RX. This mode is
> the default on macOS and Windows.
>=20
> When reconnecting a device from a macOS/Windows machine to a Linux
> machine, the device stays in NCM mode. Therefore to correctly support
> such a device, the driver has to either support the NCM mode too, or
> somehow put the device back into legacy mode.
>=20
> To match the behaviour of the macOS/Windows driver, and since there
> are no documented control commands to revert to legacy mode, I chose
> to implement basic NCM support.
>=20
> With this change, the device is attempted to be put into NCM mode by
> default, and falls back to legacy mode if said attempt failed.
>=20
> Tested-by: Georgi Valkov <gvalkov@abv.bg>

Take a look at submitting patches, the best way to send a change is
with git send-mail. And make sure you CC the right lists
(./scripts/get_maintainer.pl)