Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zi Yan <ziy@nvidia.com>
To:     Ryan Roberts <ryan.roberts@arm.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        SeongJae Park <sj@kernel.org>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, damon@lists.linux.dev
Subject: Re: [RESEND PATCH v1 3/5] mm: Fix failure to unmap pte on highmem
 systems
Date:   Thu, 11 May 2023 11:01:33 -0400
Message-ID: <2E10F2A8-D954-451D-9CA7-042E55394FF7@nvidia.com>
In-Reply-To: <20230511132113.80196-4-ryan.roberts@arm.com>
References: <20230511132113.80196-1-ryan.roberts@arm.com>
 <20230511132113.80196-4-ryan.roberts@arm.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_C184A589-30EE-40FC-B337-3E77EE76A2DB_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XLUx2pYtht2fQ0zMJaca1ICxrQP60hdUpbfc2hVazkfWNJWU6U+U7eJnzEMy?=
 =?us-ascii?Q?51IwqsqaHJgSImXJj5OUXIGUH5EjrqqcMx5SUkC+n5Weqb909cWJ0JAQ+BTm?=
 =?us-ascii?Q?Syi/IJijvcZ0AsuSu1Y1Whmv38BiHZ7NpTNbyQcKjrZ9H5aEG7maO7UwZHp5?=
 =?us-ascii?Q?oiPinCtvKJ8odhlh2bhykSzNhtsTgVw2Ena1io//tJHJStrjfjKX+R4+Dcdy?=
 =?us-ascii?Q?x5M5pRN1CoilgitXimVmOyzfkuVCX5iNNmIrqzSOxQVDd1KjGcyIMtQlF6XN?=
 =?us-ascii?Q?nANFpgHdHSA/zzuVPL8akgqnnaZFsJliq9Zzd3+YD4sTahQdcsYStIza9KmX?=
 =?us-ascii?Q?QJT2U5sADntLxIdEUno4rTbNROOnn0LYZ4m8mHz4KKYJq7vUc1MPz7S65hKg?=
 =?us-ascii?Q?G7+kAgiW6CH62Ab/bJZ7YaK9alWA4rId/jsk1eGKHWOFW3D9X1sdq90vrEGh?=
 =?us-ascii?Q?6zxYNKptzLihbw13x3OQ2KIAhVejK5j8hP+eyAwaGNgsz0P/ZAUp7j7N/WaA?=
 =?us-ascii?Q?mcCqNleDTe3yWJhKAZd7mfj8ZiS9KhaEuchYj7wnhmGNfUqtdij8H5nV5s2+?=
 =?us-ascii?Q?FYOt3d+5oVEe8mJxi+ekKuIu/aVN8WUVa8ru7/c1C3d+ExWI9zy/a34Sp7YZ?=
 =?us-ascii?Q?cqSurfCrW11EWEpbLL5ouyYtT0HrOhyudi9pQsGGmyTj9Q7/cZPcKGVB8kyU?=
 =?us-ascii?Q?/N3q4HZ3qgA/KyWxGiKosiLX91O96vPOzbAdeStU95Te0t6Qu+OjLJ8h+u6H?=
 =?us-ascii?Q?CkmxEvY4ZdnoPzn0YLKYk/mqf+ZRWnoiVK5Mn6bSevCjctNHlvjlXodGJ8K/?=
 =?us-ascii?Q?AC9sGzZVadHEjhUB8f/wEfMiTqqEFQinVd7j/CycQAPSH396X/B5GCXcUATm?=
 =?us-ascii?Q?Etipcn1i8/XRretIsAXnWjCUtVKiM51GL9vXDNTxztIbiIUu/jhx/ceU/ipP?=
 =?us-ascii?Q?9DtS4Gbdd2J/mRP5WjO9+Egji9JjxDWwUJUtR3QBovbo6/JO8aizBsKS9vR/?=
 =?us-ascii?Q?KnI/jqgMb0iVXADTD1fIEaT55iIOW50aYfFrkzhEEtf2dpI5mY8opGjBM2+y?=
 =?us-ascii?Q?uFGnljGmhtrxrCfqh5VZjgumyMxKg0LKxLPZuW3IY0MBg66Lky4qR3du0PQ3?=
 =?us-ascii?Q?nmB1HIcDhIy8fACwn0zsS9ltbSxCKkNTyZ4e+zC4Syht6KkgIo9cSzgfFcBn?=
 =?us-ascii?Q?rlhMOF6Hto7aCjAG30/BXrbW1AxVXJ8JCtEGTyS+NLCZrkGZCimPOxT61S+v?=
 =?us-ascii?Q?MhgaNAfToUwunsQbxXKXnNn3RCUTGl0+IgGo31xZZ5JiWYIPmGs55O3l31U+?=
 =?us-ascii?Q?f8ZlB2DaOqCmoVTRuwHg6SNwKx9C6CHsGd55tLM/CaG9a34Bt2d//wIytCW9?=
 =?us-ascii?Q?ss1ZgM9scQ+4t6YgMDa+teQUZLUpetZhw2zEe6ZmxePmL060SX6QZyu0wCfo?=
 =?us-ascii?Q?YrgL2QaBrHtJvI/FcprGqCCQ7De3vKka9pcxeLCT9K0HAE/cg6fNHcNYx9dx?=
 =?us-ascii?Q?jBrpsZFfxkUiILd7+a9pNBfbmEgOkWjc36g9DMVEn5HV0HABiFWKuf8yV/+J?=
 =?us-ascii?Q?YmxUyd5PA+MfdFqxWIFCBkFszSwCAxvmrvBaQyAo?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 314a0f29-6337-4a7a-a7f8-08db52309c71
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 15:01:34.1175
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: laXLfhUTOkHffBiyRaNTu5i5DDARhzubTgvgywm+hTQ72mwVeSQ+q0ZGFr0C7A95
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5638
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_C184A589-30EE-40FC-B337-3E77EE76A2DB_=
Content-Type: text/plain

On 11 May 2023, at 9:21, Ryan Roberts wrote:

> The loser of a race to service a pte for a device private entry in the
> swap path previously unlocked the ptl, but failed to unmap the pte. This
> only affects highmem systems since unmapping a pte is a noop on
> non-highmem systems.
>
> Fixes: 16ce101db85d ("mm/memory.c: fix race when faulting a device private page")
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
>  mm/memory.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_C184A589-30EE-40FC-B337-3E77EE76A2DB_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmRdA00PHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUVrgP/2z30A6J/GERdz8FtEp4mnwSF7udKoBM5nwA
0VJ6aDhJf32/XcZujHW4FOtcDPMpRKjGgb38Gw7EF73zJy7Vl7USeGadv1dtwDog
4y71m8QWv59UwfnxUrp/tptJLcLFFqs5pPmRZCzEKCroN7d+ixLrulxCpROehHEi
3Q2RPBvnjgcEgRa+/Ua3GMF/BXLDABo/aloKrfcKCuRwl3urVdPFaWHKs9a+IQ0o
4s7BwYTDAIMTFidQVQLIZJ5e5i9Vwljkp6dXzdYk883RL/8bGBmAACn/3Ukk986h
FPWtnsQHvvOKkz20ZLGwjib3UXkp5Vk31UCt/PpBmGNcToKXAklUJPqZXS7YlD/M
mo+NvgiEcLwMHeeM96O4bl8UdZJhAbL4ytnVD9eqQCzzJrlcecfwGO/WCHXcDy5A
Wf2oXJiXKlzhAN4LlxX/sabWSv+EyR+bdba5n2QiKHsV9uCIQC87qc/uDEKEgUlB
QA/xYwbkzNOIL0aexZ7RGJCXz5DA+IsVMJq7Cla1OicSrmOIJTMEOJQ2PI439vzi
n05+IqVw2dM2UIh/9IMwnd26zisQGthGp4nxdfGzSQsa6+LZSVhphdjiUfSk/+zg
ESM+ngNRxVjemYzO+rMshbCsZOHLHLAKbpLeolfTCe+XoGxGY+wlwtwMUdm1+uLD
ZR61gEMU
=nuDq
-----END PGP SIGNATURE-----

--=_MailMate_C184A589-30EE-40FC-B337-3E77EE76A2DB_=--