Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "zbr@ioremap.net" <zbr@ioremap.net>,
        "brauner@kernel.org" <brauner@kernel.org>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "socketcan@hartkopp.net" <socketcan@hartkopp.net>,
        "petrm@nvidia.com" <petrm@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering
Thread-Topic: [PATCH v4 1/6] netlink: Reverse the patch which removed
 filtering
Thread-Index: AQHZZCxJt7hHR9OT2UmzMPODBe2VMK8V1x8AgADu1gCAAA1sAIAAevWAgALFEQCAJFpdAIABHiYAgBXwRAA=
Date:   Thu, 11 May 2023 16:04:29 +0000
Message-ID: <472D6877-F434-4537-A075-FE1AE0ED078A@oracle.com>
References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com>
 <20230331235528.1106675-2-anjali.k.kulkarni@oracle.com>
 <20230331210920.399e3483@kernel.org>
 <88FD5EFE-6946-42C4-881B-329C3FE01D26@oracle.com>
 <20230401121212.454abf11@kernel.org>
 <4E631493-D61F-4778-A392-3399DF400A9D@oracle.com>
 <20230403135008.7f492aeb@kernel.org>
 <57A9B006-C6FC-463D-BA05-D927126899BB@oracle.com>
 <20230427100304.1807bcde@kernel.org>
In-Reply-To: <20230427100304.1807bcde@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hyt+VA3ex3JvDwcVVQ1hykmAHr4FX1P+Wi2/t8yloZl4hHo/Rre77Jcc5ZyK?=
 =?us-ascii?Q?Tx1wQahMs4teGLEE49LXELzWFshqDINEG0E+qM6jV6r3sZf5/t5xC4ASeQ6F?=
 =?us-ascii?Q?2RkbDqmePWGzrIQPPD5JZD34eJvE48pRS/t9e1uHAk1tL0e7aH9tJ9BCk3CY?=
 =?us-ascii?Q?jeYY82MEBd+T1a7DfakGzXSdRIwm/laNGhJslFkQJedIrZJzfUY0o3iYYweD?=
 =?us-ascii?Q?6L8NamakrQmII26soJ7cGIpfIAGhSk1oN4HOpybmRy0i5pQe2ZZ0XgKkjvkC?=
 =?us-ascii?Q?6gwi5omicffSlEjIAuRcZZ7M9oZFQAjKG+Ooiv42JvZpGlhMAFB+AKGs9F+0?=
 =?us-ascii?Q?qWrwRUs/pRMqPcTyBcQyNEkF/Bl0ti98UECnU3uHweaSn/TMleuyR2dkARaS?=
 =?us-ascii?Q?y4QIDXC7WpYnBauWddJ6vujnjhSjzLGMegjNCdWa+QGPDDReGcZQjyDD8d0D?=
 =?us-ascii?Q?MRqaz/gjNysYEF4T8xen07r58vDD3HM7IN/vfLZoZ0teU+NE60dnSuRzhiYv?=
 =?us-ascii?Q?BRWIff+6ViKFzrQUu9rH9RWMTCNmgGt7YgDx/PLMLsrNYpsAj9ETlm4ACJ3m?=
 =?us-ascii?Q?VwtlfVXV28aaGrEalZqabTtB539iBxx2RTCF2QX1s78OraB1amp3NWicM6Ca?=
 =?us-ascii?Q?FH3kSACKYnqZC4E7yFbsvcWyJfhaS4gP9ScbrBjoCP+jej562nFWBDiMkwqe?=
 =?us-ascii?Q?FmzmYbanLaJsu0xGnmiOBgu3HkQOkTgJbnhl3LwlcnOBfUbvoYCggnJnATdQ?=
 =?us-ascii?Q?BMLmXMGTA4G5AARFZ4MU/JkIvMqaRkEG19Y29rYNckj8hIxTw/9tDmE9cvyW?=
 =?us-ascii?Q?O1Pyx65hcnKx6t1zS0CNxgaBCeE3Z1ggR0ee5bsdbdfIfIpSEypGVINwecP3?=
 =?us-ascii?Q?wvYqWG28w6JP7bJF3DR0rJbQDiYKu8qeVVNP4ZLV0rf4OFgyi5Ea7VYUPu0l?=
 =?us-ascii?Q?hU/YJFj741dHSycBn3vVSC+8IoU1m01e2gbR1OXpJ3Rsq/tGua1QTcvJJDE7?=
 =?us-ascii?Q?KIbg2QGVKqmZxJd7uL0ivVHZzW14QqBP90qS0AYgx7K4FDDvr90vdNooDbpD?=
 =?us-ascii?Q?hV1AcelZbH85oobIQ6a1t4qqmD8NyyuVlQT+J5hwHwdnBEUNZ3dNFmMEIX8q?=
 =?us-ascii?Q?arW/bSas0NeTAZz5NTUqcyuLiTQdEWeync0mldMk1xn3keVdS8cqZLTfKffi?=
 =?us-ascii?Q?hnRngWQI1CEpN1qrR/IlKVD14f7SXMQ7xBi9xbXrrLal4FZY28TMUJVRXcGk?=
 =?us-ascii?Q?BufUg/dCebwH+mglyJIyP/0AXCc3oRi1hImPw5JK1nnyHtyPt2Mb79hucvLX?=
 =?us-ascii?Q?gsKvTDMV+LTJkiyrzsNppOIYVD0Ht30NdJglJ7lBzk6zoRiyTdKhiYFOSbla?=
 =?us-ascii?Q?BDwMrpWoiG2BK0J/febawTrKRL12aq2j8IEl/hbNmhGukpdWtzXdEY6EIg60?=
 =?us-ascii?Q?U6fBq4b46qslQF276b5ExCiqUgw00jOEHrqQxSuBNbAPjrFuE6UweoFB045p?=
 =?us-ascii?Q?w+dAZDX1i9uBCVlbuebvlREa+eSH8NOmsmsWaeelUeRkKyyMYYMkrmGoZ1UH?=
 =?us-ascii?Q?gIyZmOHrXt18iQFhnPoN807GPK0Vk5Kt7Fyv0xVf2qGVdeIz3+R6Nw1loAGI?=
 =?us-ascii?Q?iNppvafU3crZxHTXT76iLWdAsn5XI/koQLiJHKl6d3/ue4I/ujmq+RrvY3kZ?=
 =?us-ascii?Q?jKT2i2/1OLv/beJ/MPwllAJMRGA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1BA2829F5D8B6C49BDB21E69DE4AEE3A@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?TtudZrgyvUv54+NHDBnKfzQGzaULFa8yHTCqSYPn+B85WlKddAUehPde9t0c?=
 =?us-ascii?Q?dKSqzoLidHOpmngF2Hb40VCbwvZ8K5OP+KylV/AQQWyEPQAtne/jpK+wl5YS?=
 =?us-ascii?Q?O39v1vpNZpKSif1hI7ky4MK0fkjWM58gX8/iqa+0ndNxalufaT7Alx6CZHOq?=
 =?us-ascii?Q?19+ipGugyswh46Yzms4Wbx23O+e63x/0v2NgWffFYnPL35XNXOfXTi7Ba1To?=
 =?us-ascii?Q?PDhYvgmBZfWuzlzFBPOCVGGCRgqNjfe/b5Es9OC6EGPJFLRwgZQKg3VtUajY?=
 =?us-ascii?Q?ECMH0aR/npxIrxueLOlTZk3KJ45ZnTACniD6hL+yjU/jK+4dD+tYwb8eFSUU?=
 =?us-ascii?Q?ku56v+qdYrsnqA4qra2hj6xM46HgjI8oFYAiGf++Qe5+EpD/162XRMWpyydF?=
 =?us-ascii?Q?7m4Od1o9wOjQQ9C/Vl+t5yOhRu7/7zd1q7GXMJwgGGklBz4X4GkljdJEMz5T?=
 =?us-ascii?Q?gMrRYJkrSTF83uYeDt9Q1VjvO1zLlr4Cphm3Vhk9YCp8q9IM7pEByvFLFiBf?=
 =?us-ascii?Q?RsoX6i25tdZa6YhUeAJPsD3nyPsB5BtvCeFA8ssGPhqzb08fg8fMx3/RgPHJ?=
 =?us-ascii?Q?EkLaUguOtzU05AU4QRfGuwOXnCbpjuYrz4wD4nAfhnHeKQJaev4h+6G38akd?=
 =?us-ascii?Q?gD+e7E2K3ZIyiO9TGz/wAuG2g5wmeVyhZ6aDf4j7G7qVyrhKqPvUbnpWrQ1+?=
 =?us-ascii?Q?jos2i+S6akPoPlW6o5pSDO5EQC8IGpMTvESW4IZqVFpvCSFndYrcM7Lh/B3Y?=
 =?us-ascii?Q?2GwtUrPhtKDfjj97h80aL6J4t2HS0xKtrN8uTQPFTdoGus4b57BI3KZuw2dR?=
 =?us-ascii?Q?AAOuBbp8+A+lC4TTp6T4pVI1gX5k4AFqy9m1l0NGx8l30zhUStvycbLGXb48?=
 =?us-ascii?Q?jagNRXrKwa+V2Z7U/8KTYMxcK5IfvUG4uaiEH69aj9I1s4i6pa/g7TbBeKNt?=
 =?us-ascii?Q?EMC2i2PtkxE8qxBU7hclsi6Q/mt81EDDtYF94A55NfM2DGOVCe5sTvD6c75g?=
 =?us-ascii?Q?yeQCh3r+s5DOH+RR6hBc4cnzDWlj7H1XlzsTxFrvLrm47sXfSuDClfyn6NET?=
 =?us-ascii?Q?xDj3dttnhgqpfKh05Eed5pwuiGLH7Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4129.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0335bd04-66d9-4f95-fde9-08db523966b1
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2023 16:04:29.2217
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0MgE75EKwyTqeoiz51y2t4DPo1pgnBC28gRigUh6qUb3bFx9wUw9TO6oIWgqY4Me72dn6lj/SRYelnC3fjy4ksFxTEBHRFm5ggpcxVJvhMc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5896
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-11_13,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2304280000 definitions=main-2305110139
X-Proofpoint-GUID: 4_LypqmEH_e9idxwSSNnoQpFkSAd8Vav
X-Proofpoint-ORIG-GUID: 4_LypqmEH_e9idxwSSNnoQpFkSAd8Vav
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 27, 2023, at 10:03 AM, Jakub Kicinski <kuba@kernel.org> wrote:
>=20
> On Wed, 26 Apr 2023 23:58:55 +0000 Anjali Kulkarni wrote:
>> Jakub, could you please look into reviewing patches 3,4 & 5 as well?
>> Patch 4 is just test code. Patch 3 is fixing bug fixes in current
>> code so should be good to have - also it is not too connector
>> specific. I can explain patch 5 in more detail if needed.
>=20
> I don't have sufficient knowledge to review that code, sorry :(

Is there anyone who can please help review this code?=20
Christian, could you please help take a look?
Thanks
Anjali