Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 18:06:14 +0200
Message-ID: <87ednm4zux.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     nemesis@icequake.net
Cc:     alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Stefan Binding <sbinding@opensource.cirrus.com>,
        Meng Tang <tangmeng@uniontech.com>,
        Andy Chi <andy.chi@canonical.com>,
        "Luke D. Jones" <luke@ljones.dev>,
        Philipp Jungkamp <p.jungkamp@gmx.net>,
        Kacper =?ISO-8859-2?Q?Michaj=B3ow?= <kasper93@gmail.com>,
        Yuchi Yang <yangyuchi66@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15
In-Reply-To: <ZFvD/HwNPd6xuCMo@icequake.net>
References: <ZFvD/HwNPd6xuCMo@icequake.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 10 May 2023 18:19:08 +0200,
Ryan C. Underwood wrote:
> 
> 
> The Pavilion 15 line has B&O top speakers similar to the x360 and
> applying the same profile produces good sound.  Without this, the sound
> would be tinny and underpowered without either applying
> model=alc295-hp-x360 or booting another OS first.

The code change looks OK, but could you give your Signed-off-by tag?
It's a legal requirement and mandatory for merging to the upstream.

Also, you can reduce the recipients in Cc a bit more.
For this kind of trivial change, just maintainers and ML should
suffice.


thanks,

Takashi