Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <4cb758c7-f4f5-820c-c7e7-5b900ccc2534@kernel.org>
In-Reply-To: <4cb758c7-f4f5-820c-c7e7-5b900ccc2534@kernel.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 12 May 2023 01:15:49 +0900
Message-ID: <CAK7LNATQeT8MaQr450x0SpHJV=QU7nrfWfDO1ZRKimppVZG4KA@mail.gmail.com>
Subject: Re: make localmodconfig doesn't work for thunderbolt
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        andreas.noever@gmail.com, michael.jamet@intel.com,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        YehezkelShB@gmail.com, USB list <linux-usb@vger.kernel.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

+CC Steven Rostedt, author of streamline_config.pl


On Wed, May 10, 2023 at 8:01=E2=80=AFPM Jiri Slaby <jirislaby@kernel.org> w=
rote:
>
> Hi,
>
> if I use localmodconfig for example like this:
> mkdir /tmp/tb/
> echo thunderbolt >/tmp/tb/lsmod
> make O=3D/tmp/tb LSMOD=3D/tmp/tb/lsmod localmodconfig
>
> I get:
> using config: '.config'
> thunderbolt config not found!!
>
> $ grep 'USB4\>' /tmp/tb/.config
> # CONFIG_USB4 is not set
>
> I believe it's due to:
>    obj-${CONFIG_USB4} :=3D thunderbolt.o
> in drivers/thunderbolt/Makefile. I.e. ${} used instead of more common $()=
.
>
> But even if I change the parser:
>
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -317,7 +317,7 @@ foreach my $makefile (@makefiles) {
>          $_ =3D convert_vars($_, %make_vars);
>
>          # collect objects after obj-$(CONFIG_FOO_BAR)
> -       if (/obj-\$\((CONFIG_[^\)]*)\)\s*[+:]?=3D\s*(.*)/) {
> +       if (/obj-\$[({](CONFIG_[^})]*)[)}]\s*[+:]?=3D\s*(.*)/) {
>              $var =3D $1;
>              $objs =3D $2;
>
>
> I see:
> module thunderbolt did not have configs CONFIG_USB4
>
> and:
> $ grep 'USB4\>' /tmp/tb/.config
> # CONFIG_USB4 is not set
>
> So two questions:
> 1) is ${} supported and should be the above change sent as a patch? Or
> should be drivers/thunderbolt/Makefile fixed to use $(). (And maybe
> other Makefiles too.)


I believe streamline_config.pl should be fixed.

There is no good reason to support only $(), but not ${}.


In fact, the comment line around line 395 of this script
uses the curly brace style.

  # a loaded module. This is a direct obj-${CONFIG_FOO} +=3D bar.o


> 2) how to fix that 'thunderbolt did not have configs'?

That warning is CONFIG_USB4 was unset in the resulting .config.

Was CONFIG_USB4 enabled before running localmodconfig?

In my understanding, the purpose of localmodconfig
is to slim down the .config file.

It disables unneeded CONFIG options, but
it does not enable needed CONFIG options.


If I start from allnoconfig (i.e. CONFIG_USB4 is unset), I see the warning.

$ echo thunderbolt >/tmp/tb/lsmod
$ make -s O=3D/tmp/tb allnoconfig
$ make O=3D/tmp/tb LSMOD=3D/tmp/tb/lsmod  localmodconfig
  GEN     Makefile
using config: '.config'
module thunderbolt did not have configs CONFIG_USB4


If I start from allmodconfig (i.e. CONFIG_USB4 is m), I do not see the warn=
ing.

$ echo thunderbolt >/tmp/tb/lsmod
$ make -s O=3D/tmp/tb allmodconfig
$ make O=3D/tmp/tb LSMOD=3D/tmp/tb/lsmod  localmodconfig
  GEN     Makefile
using config: '.config'


--=20
Best Regards
Masahiro Yamada