Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Katakam, Harini" <harini.katakam@amd.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
        "wsa+renesas@sang-engineering.com" <wsa+renesas@sang-engineering.com>,
        "simon.horman@corigine.com" <simon.horman@corigine.com>,
        "mkl@pengutronix.de" <mkl@pengutronix.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "harinikatakamlinux@gmail.com" <harinikatakamlinux@gmail.com>,
        "Simek, Michal" <michal.simek@amd.com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
Subject: RE: [PATCH net-next v3 3/3] phy: mscc: Add support for VSC8531_02
Thread-Topic: [PATCH net-next v3 3/3] phy: mscc: Add support for VSC8531_02
Thread-Index: AQHZhAFVaEeZnn4aeEyZcvSiQUtANa9VHQcAgAAW1qA=
Date:   Thu, 11 May 2023 16:17:21 +0000
Message-ID: <BYAPR12MB47731D5AAC7091F89C2CA9AC9E749@BYAPR12MB4773.namprd12.prod.outlook.com>
References: <20230511120808.28646-1-harini.katakam@amd.com>
 <20230511120808.28646-4-harini.katakam@amd.com>
 <ed6cd234-1d75-47f4-a808-6a152a63af0b@lunn.ch>
In-Reply-To: <ed6cd234-1d75-47f4-a808-6a152a63af0b@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e4otYyQeGKke/94dBoNDTo5lvGzMQG0ubcIDMAIT1UgHAvwdb80q51DYXKIa?=
 =?us-ascii?Q?j6VUOkvR4ixwuNYB6kwT3idqT/utOkbf/Ti+2OM9uVY2wk0nXG7WvQbJBlMc?=
 =?us-ascii?Q?OMNYZgAZX7DGCSG8asUSl731caALfObvvH6UjOBcgyoWklLp79qzaDhsxag6?=
 =?us-ascii?Q?8egYnhc4FXN7QdBSzJME0u/vOHZOeZI9uO5yhQ/Txs5s+mBSb+UUJYnkxj6j?=
 =?us-ascii?Q?CP4NhsOkY9TOz1jtZAYFVTgFXjgkBkRjGPTTx1ljGbpWkrMx/5Ge+PEmlefe?=
 =?us-ascii?Q?HM8efsPqvjVSDGyLyIfF9hKK5RskG74+v/r5pBIqhx594e8Uiy4uJ0h7JpHk?=
 =?us-ascii?Q?SKcvcShwC3KahuYQmQKVCgDkmrt6qq0JliEQA76owxIY6MlxS6qAGEfvHgYv?=
 =?us-ascii?Q?E3goOSIdsxu8nEymqnFJLDhxvxp8Z8+VmEFH/O3BrHGOoRs4C/pivke8OkAt?=
 =?us-ascii?Q?stzR5F5VoHpkPFLHUDhq6sBkX5uOI1O0Huas7clytpVOpaN1OeVJr08oyctq?=
 =?us-ascii?Q?o18+/909eenWsQ+VA/YuUs4EBAQOKsQl2cA4PjLFPyrq1NJQzIBUYPNJ56LA?=
 =?us-ascii?Q?uZEscdaSX3C/+m9XwJVCr0qk+NLlpVFB1MW4bIRcLeRl15KT0QKOdkEOx72P?=
 =?us-ascii?Q?o34yZB4uCb/dUpAyX+H6ywW9yAXrKN74YVZCWHLvIxy4t9gyYp77wF/Y4f/l?=
 =?us-ascii?Q?pSTglfY9QFbZhJoXE7KZgG5RZHK2ppqGlHZ7NwgIqa4F/4PYnn0dVVIaxPGP?=
 =?us-ascii?Q?U3jCb9iJaJvsVZY8YfSczcBPTqrgEGWNsWP59cUpNvbuyWQVtV2y61IO8XGk?=
 =?us-ascii?Q?oF93GVtBxI/oMdlJnsJr9n+Uom+bQRC+sExCImYjh75HIyl/mod9kUpsjrQB?=
 =?us-ascii?Q?x0m0nA+gZ5NVIhIAoXpuwNhvH3l9OWWd14w6a9u0oSh/TB1ettkY7TdWUpMa?=
 =?us-ascii?Q?zilqRaApz5pwK9nd0ZNV54mSOrxkGaptcPmgP9i14tjn42UANd7jO7MyTrBo?=
 =?us-ascii?Q?KGqwU0TT5kh8kn0kVNMlgLk9MTSeB0SjYBEhYJmTA8K7+tWV6Utt/cOcgTiD?=
 =?us-ascii?Q?KBHYmX6sha8hi5drepXclsH+A0JiXCdEC13ESgAXJ/iZSEsyPEqTCe3VWFIX?=
 =?us-ascii?Q?PdkBw0qWD1E1GE5u6GfwRyNrLh7hAJ8hjmnoexgSWiroKnCFU8LHA3nZgJco?=
 =?us-ascii?Q?i+IFsyQuJynQrcEUu+nguN9dLKNPZK+fvnMEvDBtCVlWhQQpwsUhjl735FVw?=
 =?us-ascii?Q?mE2Cp9AkkB50/FdDtygmwt3jQ8eiZYD98HCfjoKl4CfIsWm5x9cxBmKm6klo?=
 =?us-ascii?Q?3m32qtbXVIKpwVNQUQbvwznKGxjSqp2cveQL/EZ17EmTlPftF9qWfsQkot2X?=
 =?us-ascii?Q?mJ9ar1f+ndCExQzba2xkixD93Vw5mZG44NtHLikDsDpcIg7keG6l7BYcMyoh?=
 =?us-ascii?Q?t9GmLy4XYwQ4vtPOnVHpkWQjh5rUIExEcpSXMWYXP9GRSbVPVbwm2ibrAna9?=
 =?us-ascii?Q?yCEt3vvLdjWLKSUCyeIpCFBRdgrz4oZWeQ0oT2p9fVZPTMB3L/GuRZAyHTQ2?=
 =?us-ascii?Q?xS+XHR1TN9caCFMDaZI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4773.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c0b64ed-27c5-4ac1-e8cd-08db523b32bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2023 16:17:21.0815
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i+6uRrHLf9fHcqWbTtCUfwpTl/MeB3G9u8RUi7mAAwwIYf1J62O+lVTMsGZudrqP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7354
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, May 11, 2023 7:42 PM
> To: Katakam, Harini <harini.katakam@amd.com>
> Cc: hkallweit1@gmail.com; linux@armlinux.org.uk; davem@davemloft.net;
> kuba@kernel.org; edumazet@google.com; pabeni@redhat.com;
> vladimir.oltean@nxp.com; wsa+renesas@sang-engineering.com;
> simon.horman@corigine.com; mkl@pengutronix.de;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> harinikatakamlinux@gmail.com; Simek, Michal <michal.simek@amd.com>;
> Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Subject: Re: [PATCH net-next v3 3/3] phy: mscc: Add support for VSC8531_0=
2
>=20
> On Thu, May 11, 2023 at 05:38:08PM +0530, Harini Katakam wrote:
> > Add support for VSC8531_02 (Rev 2) device. Use exact PHY ID match.
> >
> > Signed-off-by: Harini Katakam <harini.katakam@amd.com>
> > ---
> > v3 - Patch split
> >
> >  drivers/net/phy/mscc/mscc.h      |  1 +
> >  drivers/net/phy/mscc/mscc_main.c | 26 ++++++++++++++++++++++++--
> >  2 files changed, 25 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/phy/mscc/mscc.h b/drivers/net/phy/mscc/mscc.h
> > index ab6c0b7c2136..6a0521ff61d2 100644
> > --- a/drivers/net/phy/mscc/mscc.h
> > +++ b/drivers/net/phy/mscc/mscc.h
> > @@ -281,6 +281,7 @@ enum rgmii_clock_delay {
> >  #define PHY_ID_VSC8514			  0x00070670
> >  #define PHY_ID_VSC8530			  0x00070560
> >  #define PHY_ID_VSC8531			  0x00070570
> > +#define PHY_ID_VSC8531_02		  0x00070572
>=20
> Does PHY_ID_VSC8531_01 exist? The current code would support that,
> where as now i don't think any entry will match.

Yes, PHY_ID_VSC8531_01 exists:
https://ww1.microchip.com/downloads/en/DeviceDoc/VMDS-10494.pdf
And I'm sorry I realize now that this patch breaks that version.

Also considering your RC on the other thread,
" Just to make it clear why the existing PHY_ID_VSC853/0xfffffff0 is not su=
fficient."
Currently there is no difference in the phy driver structure between
VSC8531 and VSC8531_02. Let me double check the identification on
my board and skip this patch if possible. The RGMII delay support in
2/3 is generic anyway.

Regards,
Harini