Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 09:33:52 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc:     agross@kernel.org, konrad.dybcio@linaro.org,
        linus.walleij@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com,
        manivannan.sadhasivam@linaro.org, andy.shevchenko@gmail.com,
        linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH v7 2/4] pinctrl: qcom: Remove the msm_function struct
Message-ID: <20230511163352.kfjpvagh2rysyelo@ripper>
References: <1683730825-15668-1-git-send-email-quic_rohiagar@quicinc.com>
 <1683730825-15668-3-git-send-email-quic_rohiagar@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1683730825-15668-3-git-send-email-quic_rohiagar@quicinc.com>
Precedence: bulk

On Wed, May 10, 2023 at 08:30:23PM +0530, Rohit Agarwal wrote:
> Remove the msm_function struct to reuse the generic pinfunction
> struct. Also, define a generic PINFUNCTION macro that can be used across
> qcom target specific pinctrl files to avoid code repetition.
> 

Looks nice! No need to carry our own structs for things that has made it
into the framework.

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

But, ipq9574.c has made it into linux-next now, so this breaks the build
of that driver. So please update this patch. And please send the two
refactoring patches on their own, followed by the SDX75 based on that,
so we can get those merged quickly, before any other impediments are
introduced.

Regards,
Bjorn