Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
        Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests v3 11/12] nvme/rc: Move discovery generation
 counter code to rc
Thread-Topic: [PATCH blktests v3 11/12] nvme/rc: Move discovery generation
 counter code to rc
Thread-Index: AQHZgTyFD/YYYRDKLEuLLtG7PZkYY69TxfyAgAGHWQA=
Date:   Thu, 11 May 2023 16:44:52 +0000
Message-ID: <74gmncf3mmoymdj2ranyzgzohv4m3osnnyckiwj55a6j7pi2lg@524euomat43i>
References: <20230503080258.14525-1-dwagner@suse.de>
 <20230503080258.14525-12-dwagner@suse.de>
 <4zt5oysmqw72l4xzfja2oer72hryisz6zzbboz7dmhhzfypuwx@yrf2utjkv66b>
 <5mizvgs3mwoxbkgb3axuhgkmjjxa6svi4laksdccg3oue5fwf7@4mqtz2dm6phj>
In-Reply-To: <5mizvgs3mwoxbkgb3axuhgkmjjxa6svi4laksdccg3oue5fwf7@4mqtz2dm6phj>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?28e6ZiZuo4PEGJzXtGX5+qjN4LZ961LTXuY1xksvlcMUFgADT2u0MTv6gQeo?=
 =?us-ascii?Q?S8loD0SnJ7c6n129rYueg59Vn+FoIZ2NvwP4dTXycQybIQu0lLRaKduWUdjL?=
 =?us-ascii?Q?c6IaQmm83ProFfh4AFfB5+r3a3kYDgZJREZDFXcj2jxpCJZcYtp/jykMjjVr?=
 =?us-ascii?Q?DrKjx80UtLIgA6GMvp2GfWQ0lZf7kPDItJWuNFJfyhWao5Otkg7uVuqKmtck?=
 =?us-ascii?Q?7xIgPGZiNI71Ube8oStlgVyIlcQqsFmZERM9SWe7n+ni8wYMRAzAWu3H2XZs?=
 =?us-ascii?Q?OtVFu2sanWVREP4YAO9/bylw9Law8ozPP9vviMHByp4XapmtlRSZj1GvrI3F?=
 =?us-ascii?Q?yfQbiMex3AhFuDzILcdQlzDptl1P+hd5DlzdLo66SXldUrH7gbH3dYqiNEKA?=
 =?us-ascii?Q?Xv1jqKUg+rkO1JnXga2xuM3izc5vHwJp5SRSL7fsa8J8DCoNivNkOePoCFpN?=
 =?us-ascii?Q?5f8tcXJPHa6OAZOmsSZqvqA8l5K6qkZAwWRfn/gkPR3ujus1mkprsp4etVoq?=
 =?us-ascii?Q?mmaGoBWf7PFdKV6RURVTcdWmxH8Qs1UpEMm2Yr6PjhsbZvSRY9fqdicC0Q8j?=
 =?us-ascii?Q?DFfawGU2N72b01LiQI5ejXNfqFO7PGSzvAubJBDNl3pO/A9q4Vgm5rv8wfnM?=
 =?us-ascii?Q?ssGDEUjZYl9PbJooiPcziCBzin8AuSfdVSUvAgE7x/7o4jkEsgHVJJ4u6pbX?=
 =?us-ascii?Q?XJZjlUIJG55Ke1zyoClyJLH7HVaNCYufH2p1O17OXGZ7CKTCSarNam0IgbaW?=
 =?us-ascii?Q?wuK50b1L0k/3OWflOcav8jop1+EjHe3lvHv4UJ3ytmpIBvykUUIlLPFBfai8?=
 =?us-ascii?Q?7t57kLu7ZGrPFy9aETMkCprRwk82ib/+aBojQLLro9Wu4+ITgvY4HUnb32+R?=
 =?us-ascii?Q?jrcUOFI//y98ub66pYCthDJv4EXu6nyLEkMvuBTkuRSVlBd4AO9fS+/nED6u?=
 =?us-ascii?Q?GNZjen1o680To2oxw5mD5QRJz2zGp/tW3tQAEHnpMBQIoo+VNfRjZFZj5z/q?=
 =?us-ascii?Q?Uv9CLlY0Ip1XCR7dk3pDboAtrk2u5pX+CZZTZ9A9xdrErskGbAC2InKuePAi?=
 =?us-ascii?Q?TTehTgUfSWpLXFc5H+VjYMuTFjY+wHZF/aBjfEifUOD9AvehR3UfsEYdrjwU?=
 =?us-ascii?Q?6f75J6c/4MkZliCRmIqfGVe33UxR6Vya79azOHTAcpOilwcd5c3EyHB8URnk?=
 =?us-ascii?Q?cNhSQJfAXqZNh4nAVeSPu3624eB6pWbXjSAgFfvmRqUocVRGIN1R6kDlOPHs?=
 =?us-ascii?Q?89zYqTJBMc+IubHo5UTUgbR5tupDTnicA1DDp66HAZbK7fvHLT/hWTb39Iay?=
 =?us-ascii?Q?0dun2H6f1nlV4dT60aQYaaDPh80wrlYDFHMv1AZxZevZ7eX7riciYjFydowe?=
 =?us-ascii?Q?pFqEdfCGg7RpPlF5loeLyMEoe124wwe18lwdIqD1pszGkBKwXiQVvNkaG8jx?=
 =?us-ascii?Q?8dQyE6GxkwMA5lC/DeG7n8rvn7gucR9IPlm7dAKfZNMaAdzPy0MWt7Z3FUef?=
 =?us-ascii?Q?KygJFLxR6EZy7hAOcC8MV7AcesHclFPFiVhRZKXUv03kd2TOyvM1SCKdboV/?=
 =?us-ascii?Q?OuJEQNYVA9JXaypAUA0QYqxlHwjOlrnC2nKktQu0u65jZ1lWCkr+Mg7GkRKH?=
 =?us-ascii?Q?PrNFsDYRiTklhybVbG/pFts=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9BC9B46033DEAF4B9F5713C0115112D7@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: s8mhuDEhURXz/oOntCZnYg3rdYsTOg2fKRzHAUdkZPbuyRObQSt0QCfWF+3LuAOJHOM5qf25Gqfg369POxTt3hPIplz4XHqQBhKCkEdguQy4dyBim3uzAkltonCQS1MBPMOqgLIlZA4Qq6XLITRF9d03vgfxq1PNftQeArg2afyr4lo+T2x2d299K1f+pESYmf6RcjfM2GObPV4FtyQIxpcZbIYV5km8K+VTZ5MEy+JL+/p+Fx1KlF18yTxGJjY7/yEO/hXlrqkAflr6OWfJMm5JKrClzNosxhKSACC/I4wUYhQeqyxyryDdIvplIY/M3uMxHWc2bvgdhx+w0npZHFfSwRBTFMRzIyfD8bqBtrHNgZsce9qD6M28O8ZdPX3uxH0rd0NjHzZ5cwR6NPgjw2eufBASDRlfbtqpKQ2kpvaRGDjZepSJS+Zv5ss/dQuFSaRAlXqWsiMSwaSfEoYLc+PrqqCbaAoPSY+UOwE4g35e9nueVEnS+JheV2Sp3gzzjbhoiSn8CIT/tKY2lVK6oBfLQlJgibHpPo90PZsGbiebMQWkr619SMuIMEDJedPCHyc8qMVwUakspxCP2Yi9tAoyAyaM9DVKwIQqMrvxnLfAOX6+osnn8fR4UXHeB0poNfWbZBjBVX8RylcF2tlhK5LuLNx6A7Gi4ju3/xd701Guyi7xuZ/BAZ8XXHhf9YjXSBSsbmHyMnIOnLdef2waQs5GWtwdStcwL7m55kWhcS3KgPgJLi0X4AJEiczFHMvCpMLYE6gX4pojkVYQ0ioM56FtMd7RcjHEGjxwNdcSYA2dFK3ts+X9YjES0+KlaLL4k4TFW9+0GTb++6jicHzCbvrA4cbZqDFk5fAtIc/khqvZWq18TwxVFzLWwCuZg52t7sg+uHkX8sHvp9MwvIrXL/vJhG8wrpVu+sS7yOCf608=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9384eeeb-ea1e-41de-09e7-08db523f0b28
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2023 16:44:52.6242
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ycGWChTYSh41soWyIsF3NMv3u7R6WwG1cVvz31HaTtkYztD+LDlgt6c5ZETr4sHpKFz2862pt7SQrioJpSKQ7Pb2d6WvBHhspQj0IKrui20=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7118
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On May 10, 2023 / 19:24, Daniel Wagner wrote:
> On Sun, May 07, 2023 at 11:34:51PM +0000, Shinichiro Kawasaki wrote:
> > On May 03, 2023 / 10:02, Daniel Wagner wrote:
> > > Move the discovery generation counter code to rc so that we can reuse
> > > it in 002.
> >=20
> > The last #12 patch no longer touches nvme/002, then I'm not so sure thi=
s patch
> > is valuable. IMO, the lengthy 002.out has the role to check all of the =
1000
> > times discoveries are successful. So it looks the better to keep curren=
t
> > nvme/002 as is.
>=20
> While we don't update the counter anymore, I still think it's worthwhile =
to
> do some cleanup. We have two tests which do the same thing so why not use=
 common
> code?

Now nvme/002 checks 1000 discovery logs, and nvme/030 doesn't. For the comm=
on
code clean up, this patch removes the 1000 logs check from nvme/002. It loo=
ks
for me the check to remove has some value. Do you think the check is
meaningless?