Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp9098622rwr; Thu, 11 May 2023 09:57:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7SHJHm7ipic4T6KVvId+2eXF+J3hoNG+MdlF8URO3IVDcjpV2Y2TxVXbd2wEf4lUsh19Ir X-Received: by 2002:a05:6a20:8f13:b0:101:3fe5:8776 with SMTP id b19-20020a056a208f1300b001013fe58776mr12822878pzk.17.1683824256045; Thu, 11 May 2023 09:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683824256; cv=none; d=google.com; s=arc-20160816; b=CyeEiHAyhAAlBMZSbEe2cdPcHELIXCoAfOQYuv3aJi7PmmEm50yX8qbFIoHas1nkXo Y+Ar6CRhFJdJ7rG1pmjOPn5bZDXDUhMJrFqdLzDIQdADun++nB0t11elA9rrGpIE22jE SXcnHoU1egsaoS/hF9wcn6Bw/rbWjXKr+qo/MT/YHyC2sd5Wge1l5Z4qbVgb850Z4nwS mwWpV+kQ6lE12dU+sacY51OEqwYGT/9sg8LJdu0xLIDZrN81zmDoM7HmDJ0hgoe2Jhdh gcamuVghB9i0r78s7HGEH4sg1j7IMg0GfRTwTkm8BUxn3XDldy5S9KGUeCyaplFW6Sag QOMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4fgEyVhbQQTYAEae/733MFFSy1WIuilHUuz2O27TPQk=; b=wgQNjiaPLquw/kLpL0UzT2yoaVF+j5j18FEkkS4h2ppEsATJd7pg+RtbcknGsXctIA CDwCDoTTMACttm6+sQpJsmtiNixxjnHcaH4Er8ZuZL2AL9Au9WTWvKkeea1bpFpUxOzH +3udUlGx1PxEV5fPCtFb+Y8K+z43xZMYzwrlbrZCfz5jbdj6TrM7OlN/zf8Xccd0nhKC LlCfdXyeK0fYvDhITi/5ABwQ3/nD3N+JmC+R9MdP/6fGlv+SwmZ5dPjTAwjYgcyA8OOx KfDu6KcZBfMOgBIO7AhFcV/UpTgvS1cdReIfLZEZma9jrTdNbOuVODqsU/1dQ66fTOtg e3jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GdKv2OPh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020a056a00009100b0063cdf2e10fasi8197246pfj.212.2023.05.11.09.57.23; Thu, 11 May 2023 09:57:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GdKv2OPh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238496AbjEKQpm (ORCPT + 99 others); Thu, 11 May 2023 12:45:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238475AbjEKQph (ORCPT ); Thu, 11 May 2023 12:45:37 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A857769D; Thu, 11 May 2023 09:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683823531; x=1715359531; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UczabKdilmgU9aiW6/OArG+bSHVPW/I0DRgqu9f1Ry0=; b=GdKv2OPhCYnMvNzoZ62pMoa+f6wfmjmNYimbbbTSLM2MZiijhcckdjaW jHUJvB19QV+1FgK3maUIUMKDOhqx9Me+H17VW+wC7x9/VSaN8PkFmPagC Yzfvh/73heAw7+eJ+tnxBJS7f4F0t6LIG8CF9e6ZzibGd4i78XSbbEGi6 0emaVbJWoNsmn4BXUplYBdImXr+H85B1wPdQmtAx5a9h4SpXUHLSTTRnY Vd16ewSkflor3CsvqCqhxBK/+Ghbrr/Roc545FKlmFk54O063n1rocQcB yQT5bdJuUa18knSRRDsnh4saWubUrFzJzdubgq20BUUSBQFjwYvGwoe2u A==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="348038401" X-IronPort-AV: E=Sophos;i="5.99,268,1677571200"; d="scan'208";a="348038401" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 09:45:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="824043617" X-IronPort-AV: E=Sophos;i="5.99,268,1677571200"; d="scan'208";a="824043617" Received: from agluck-desk3.sc.intel.com ([172.25.222.78]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 09:45:24 -0700 Date: Thu, 11 May 2023 09:45:22 -0700 From: Tony Luck To: Dave Hansen Cc: Sumeet Pawnikar , rafael@kernel.org, srinivas.pandruvada@linux.intel.com, rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powercap: RAPL: Add Power Limit4 support for Meteor Lake SoC Message-ID: References: <20230215123249.4473-1-sumeet.r.pawnikar@intel.com> <28ead36b-2d9e-1a36-6f4e-04684e420260@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28ead36b-2d9e-1a36-6f4e-04684e420260@intel.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2023 at 07:55:08AM -0700, Dave Hansen wrote: > Could you please fix this up? As penance, you could even fix the _ANY > defines so that people can't do this accidentally any longer. See the X86_MATCH_INTEL_FAM6_MODEL() for how to do this right. -Tony