Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 14:47:48 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     Yan Zhao <yan.y.zhao@intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, kevin.tian@intel.com,
        yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com,
        =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@redhat.com>
Subject: Re: [PATCH] vfio/pci: take mmap write lock for io_remap_pfn_range
Message-ID: <ZF0qRLtteE4mtRdT@nvidia.com>
References: <20230508125842.28193-1-yan.y.zhao@intel.com>
 <ZFkn3q45RUJXMS+P@nvidia.com>
 <20230508145715.630fe3ae.alex.williamson@redhat.com>
 <ZFwBYtjL1V0r5WW3@nvidia.com>
 <20230511100706.63d420db.alex.williamson@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230511100706.63d420db.alex.williamson@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2jVkcj34JvADKYr1THERsXc0Hp8kodl1//nSpDdm7q3iiTvYYu5wl6aPEKlQ?=
 =?us-ascii?Q?panmtYWACjuYirYmxLFE2UkS7r9iYajZTMQvRp0NJzyfgDPiCMd8bZsBgcwT?=
 =?us-ascii?Q?TtGHHkJtxVtPxPGUdD4/YCFOYGZfYeNFcdkFint1UGAKBWnfd41Y0XkFTZZ1?=
 =?us-ascii?Q?o/QnMw7eAmdxN0/Hvr6d+dnsRL+d57AybTJxMIJ5iSN52yk5KKZxxYWWx3TT?=
 =?us-ascii?Q?Hd7sza8aVRkxZvZG2J11PvsUy+6dgT5REe9yY/W0MuybJGpGtJR2yKBC+ngP?=
 =?us-ascii?Q?aIq0kSgookvnNrLofB0WogY4xEi6V+OBkCyCagh5GDjD5MQty2C6JJfQqkoB?=
 =?us-ascii?Q?C0vPnidUxOeI8IZPxSal8YNKL1n9fMJirMACdRKa0o0QxSyiRi6onrHS5j2o?=
 =?us-ascii?Q?aomcapuYl5jA3cpMYFme1RyteB9zo49RiGRDKheqTloXY9A8xEot4huD2Svi?=
 =?us-ascii?Q?uE3owO0N152sp8RJBxgmev+I6ty8nK9oa8HVt9+xvvY4/N+jGDRofxfIiUIC?=
 =?us-ascii?Q?i9XK6H9J8hFe83IXBiOdWMd03D+mSKy2OPVkR70EwWXoEp9FLwtDXHkNKktM?=
 =?us-ascii?Q?lKYMyW7pZDHF2AEaKhfkKLpRAqoB8YrlrIUZcNUBDp11X/JGHMClCpCIrhn4?=
 =?us-ascii?Q?s32k/zBuJjC5Hm4kAnKANtOp8c6mfMys/ElZ2Gis39nrzgPCL4nMnk/9X54f?=
 =?us-ascii?Q?WpoWM3XvfBe9XWme5gXbFfKhMSMPIJsnXndN90++/xwbiov9tG/S6nonv+HH?=
 =?us-ascii?Q?fa8qRB5iSSQjy1G1+0waqrbO8xv++bydMW1O6rtiT4mTPspLmWzSU8VagHSY?=
 =?us-ascii?Q?69lh3Dkb3zy/OEN9fk9A5Qx5EzfbEe4rBN2Tqe6UmHzikEHeypj2TJHqfIiA?=
 =?us-ascii?Q?TqGXYUry0/7Y7zLO39Q/cMSxSBLhOvvdbTLuOJexINd7p2qmKU1ahvJNFy/Z?=
 =?us-ascii?Q?nRn17bVGpIkLpnMm6soSgck1kNeitMsAOVqxPs/zqhgmPpeQzZbR8tPtPWQj?=
 =?us-ascii?Q?HHcDyu1kGKGt9yrNGuBrLgMJYfA5dBFjkY3tResDP9mY+r7MvTNUWykScwcL?=
 =?us-ascii?Q?6kfb7Yc49umNX9eO5vO9l5BKt1bcLjnsDMVJZ/e30N99hyV83MTnNe5ZN1Jo?=
 =?us-ascii?Q?Z02FTsihm5JYYIrbvcVXdXjDX2RBicz2Vu37R6u5ZY2Qaso9G0/ScWuYlObe?=
 =?us-ascii?Q?x58hCf+2vx8Q96yHm3uoyLwbPhP9fj0AWOA5PpWFflKKppKl61P3efbH5XIb?=
 =?us-ascii?Q?2SP4kf8RIpjQw4D+qTE3JlCsNITD/Hv/ghtuanecDF8xoZRI2bSgGsqXzvw+?=
 =?us-ascii?Q?880ttUqyA4kwxbMGKAmdsR4v5tzZ1kMd5jUqaZhuNy9Kxu446gNjkj1BsEy3?=
 =?us-ascii?Q?4gQM2rCn4D93+613IxIZTn4sz5tuHBMnV/2ocuWGujr4owFIfggVP33etk+A?=
 =?us-ascii?Q?Hxf8MyKotMPQc2QkGHg5+SEL5rSMH6FOgfWBOoXlTrms7AJCuiFw7K9Z7fD+?=
 =?us-ascii?Q?do0BOiww57t2AHaEA6NlVxZRKZuBgD50kiifgMQugDZwM5+PdPXaGCFIVSyu?=
 =?us-ascii?Q?o/vZjHCbPzV8W9xxQiep4rRCWwJkWjCSlLX3zZnY?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6147bd2-ddf1-4601-6523-08db5247d672
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 17:47:49.8866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cPmX9rAsI7Rzja+9+an7RbqOB8Q2sdtqBztmXd5Q2zIA2mPNCRWBRM/9rVH46A+R
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6301
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 11, 2023 at 10:07:06AM -0600, Alex Williamson wrote:

> > I vaugely remember the address_space conversion might help remove the
> > fault handler?
> 
> Yes, this did remove the fault handler entirely, it's (obviously)
> dropped off my radar, but perhaps in the interim we could switch to
> vmf_insert_pfn() and revive the address space series to eventually
> remove the fault handling and vma list altogether.

vmf_insert_pfn() technically isn't supposed to be used for MMIO..

Eg it doesn't do the PAT stuff on x86 that is causing this problem in
the first place.

So doing the address space removing series seems like the best fix. It
has been mislocked for a long time, I suspect there isn't a real
urgent problem beyond we actually have lockdep annoations to catch the
mislocking now.

Jason